Re: [PATCH net-next v2 1/7] net: phy: add PHY_F_RXC_ALWAYS_ON to PHY dev flags

Andrew Lunn
2024-01-30T13:56:15Z

> @@ -768,6 +768,7 @@ struct phy_device {
>
> /* Generic phy_device::dev_flags */
> #define PHY_F_NO_IRQ 0x80000000
> +#define PHY_F_RXC_ALWAYS_ON BIT(30)

It is a bit odd mixing 0x numbers and BIT() macros for the same class
of thing. I would use 0x40000000, or convert PHY_F_NO_IRQ to BIT(31)

Andrew