From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BC72C46CD2 for ; Tue, 30 Jan 2024 23:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bqjPUMXgqPfkuaHK4WeQMgbRh+0uTPWwTBgYOrWvbGM=; b=aIHKZVqUkKo8q8 Wx7KtB/9oxJyE0AsX+3/d9zLw2fC2DrWiVLhuOLC4lqAGG8EhELx4b4NnUgno4TJaEuGkLq9keN86 4b37OuaymCF3vHFflK4sp3OKuEjc41lmegcyXlgQdAjR/eyTTWElQSn5aU5V3PT1T5wbusDy9CSUn ccthSYlRuUj9wG+1pR92YQcxYPxrgLDLpkxqJbVjci1a60VM8hiYTrc05v6A69eptUqdklLZ6cPa2 rH0Uu3Ec8/X6mhA8o9kPIA0DaWu5wuUnqYk6mjdUz5GRcKtr/lYpUpK+9cu5Ib1mj8mC0L/iYMeYK S+a0bB4DVty/1oij8DWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUxlC-00000000wM2-0VyM; Tue, 30 Jan 2024 23:43:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUxl9-00000000wLJ-0bd7 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 23:43:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 447A361190; Tue, 30 Jan 2024 23:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B25B7C433C7; Tue, 30 Jan 2024 23:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706658197; bh=V5PsE4TKDcZtDMie0XfyAU5qN0ZPlNLmQZMQgv0iDF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xgF1qJE+D6myzL5YrBxw3WpTob9OuCFY3Qv3gPhJBJSd/tqoR8RSpDHeOgDiVvwdb vBiBcormrRz1MEylxdsnL2BeR9pYMgbR91zit109+s8BWs5jNM+eK1zMxydJBqtfsJ LbYHDCMtEa+MGzqo1dTsLA8xCw/maflTuFIunteI= Date: Tue, 30 Jan 2024 15:43:17 -0800 From: "'gregkh@linuxfoundation.org'" To: "Corona, Ernesto" Cc: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "'oleksandrs@mellanox.com'" , "'jiri@nvidia.com'" , "Castro, Omar Eduardo" , "'omar.eduardo.castro@linux.intel.com'" , "'pombredanne@nexb.com'" , "'arnd@arndb.de'" , "'bbrezillon@kernel.org'" , "'rdunlap@infradead.org'" , "'johan@kernel.org'" , "'axboe@kernel.dk'" , "'joel@jms.id.au'" , "'palmer@sifive.com'" , "'keescook@chromium.org'" , "'vilhelm.gray@gmail.com'" , "'federico.vaga@cern.ch'" , "'Jonathan.Cameron@huawei.com'" , "Luck, Tony" , "'christian.gromm@microchip.com'" , "'linus.walleij@linaro.org'" , "'zzyiwei@google.com'" , "'rubini@gnudd.com'" , "'viresh.kumar@linaro.org'" , "'mika.westerberg@linux.intel.com'" , "Filary, Steven A" , "'vadimp@mellanox.com'" , "'amithash@fb.com'" , "'patrickw3@fb.com'" , "Chen, Luke" , "'billy_tsai@aspeedtech.com'" , "'rgrs@protonmail.com'" Subject: Re: [PATCH 30 1/7] Add JTAG core driver Message-ID: <2024013039-tractor-subside-4535@gregkh> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_154319_252476_EE2E1CE5 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 30, 2024 at 11:26:19PM +0000, Corona, Ernesto wrote: > +/** > + * union pad_config - Padding Configuration: > + * > + * @type: transfer type > + * @pre_pad_number: Number of prepadding bits bit[11:0] > + * @post_pad_number: Number of prepadding bits bit[23:12] > + * @pad_data : Bit value to be used by pre and post padding bit[24] > + * @int_value: unsigned int packed padding configuration value bit[32:0] > + * > + * Structure provide pre and post padding configuration in a single __u32 > + */ > +union pad_config { Bad name for a global structure, don't you think? > + struct { > + __u32 pre_pad_number : 12; > + __u32 post_pad_number : 12; > + __u32 pad_data : 1; > + __u32 rsvd : 7; > + }; This obviously does not work, please don't do that. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel