From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D96ACC47DDF for ; Tue, 30 Jan 2024 23:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9jh8ZDa0WM4kMOCL5KSg3G8y5BRUF83JxtDDVxD+pEI=; b=DWt05kPyf2myyr zHxoxAdAKSBEfgNfAjQgJpEzCHvPMPigRsvo8qFFd1a38zqqhKnTraQHnlSVCmGJwrjU2p2zN6sZ5 gOyU6d/VIsdNT0w0ASKxqwA/0mQi/nOQ/zN3JEPlZ2bTg9COAPocs98mtpkyXoIN9cEb51BiTiAKx +dYjhKPLAQ7nVxdrMCExyLjUjGSG4oX8jodysyP7zn0O2adTEehUJFExSslmI2/5Lf0xj/Y2PmFyJ NcMb5DOKw11T6/Y/zmZ6BWF2oWFx/1FtgOI9T5r/NWR4sxsmMudaytEjitQABmxDVRsfqIqHgsK5w utNJtC02TzX3XCFo8F/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUxiu-00000000w7z-2goV; Tue, 30 Jan 2024 23:41:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUxis-00000000w7L-0gVJ for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 23:40:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A703061198; Tue, 30 Jan 2024 23:40:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 369D7C433C7; Tue, 30 Jan 2024 23:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706658057; bh=Nx0CiS6ywPNVMOvWJqQQzTBmYRvePR93fgFNjSqYYgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ivpu/CkGkLqC39CsG3MjaC2hHG7pbDn8WkrZYJK3iaqvehvw8Gm5VAVTKaIaZFb5I 0E+P/oJ4c77I+2CT9J0bwZSeGwWidTWCt0dZa96DXbPSscdQhAikOvShiH/cfNXRn5 NJe+DCa81BZcly21+sC4j1T45DI70NyfVGvxp6Fk= Date: Tue, 30 Jan 2024 15:40:56 -0800 From: "'gregkh@linuxfoundation.org'" To: "Corona, Ernesto" Cc: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "'oleksandrs@mellanox.com'" , "'jiri@nvidia.com'" , "Castro, Omar Eduardo" , "'omar.eduardo.castro@linux.intel.com'" , "'pombredanne@nexb.com'" , "'arnd@arndb.de'" , "'bbrezillon@kernel.org'" , "'rdunlap@infradead.org'" , "'johan@kernel.org'" , "'axboe@kernel.dk'" , "'joel@jms.id.au'" , "'palmer@sifive.com'" , "'keescook@chromium.org'" , "'vilhelm.gray@gmail.com'" , "'federico.vaga@cern.ch'" , "'Jonathan.Cameron@huawei.com'" , "Luck, Tony" , "'christian.gromm@microchip.com'" , "'linus.walleij@linaro.org'" , "'zzyiwei@google.com'" , "'rubini@gnudd.com'" , "'viresh.kumar@linaro.org'" , "'mika.westerberg@linux.intel.com'" , "Filary, Steven A" , "'vadimp@mellanox.com'" , "'amithash@fb.com'" , "'patrickw3@fb.com'" , "Chen, Luke" , "'billy_tsai@aspeedtech.com'" , "'rgrs@protonmail.com'" Subject: Re: [PATCH 30 1/7] Add JTAG core driver Message-ID: <2024013050-humped-tibia-50a9@gregkh> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_154058_313497_3C688BEA X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 30, 2024 at 11:26:19PM +0000, Corona, Ernesto wrote: > JTAG class driver provide infrastructure to support hardware/software JTAG platform drivers. It provide user layer API interface for flashing and debugging external devices which equipped with JTAG interface using standard transactions. Again, properly wrap your changelog please. And your patch series isn't even threaded, how did you send this? Just use 'git send-email' please. > > Driver exposes set of IOCTL to user space for: > - XFER: > SIR (Scan Instruction Register, IEEE 1149.1 Data Register scan); > SDR (Scan Data Register, IEEE 1149.1 Instruction Register scan); > - GIOCSTATUS read the current TAPC state of the JTAG controller > - SIOCSTATE Forces the JTAG TAPC to go into a particular state. > - SIOCFREQ/GIOCFREQ for setting and reading JTAG frequency. > - IOCBITBANG for low level control of JTAG signals. > > Driver core provides set of internal APIs for allocation and > registration: > - jtag_register; > - jtag_unregister; > - jtag_alloc; > - jtag_free; > > Platform driver on registration with jtag-core creates the next > entry in dev folder: > /dev/jtagX That's a lot for a single patch to do, please break this up into reviewable chunks. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel