From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6BF6C47258 for ; Wed, 31 Jan 2024 14:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=df374M2Kg+p4XeYaqoe4AYMvCZH32/12gz+zSyilNXQ=; b=xZZZsMsGMDRGaK +6OKp+xyR3BVx7MUUDe0VLYPBmnDX/rSBhN7/Z84a5Cl8hhwrbX3AOirAF6NZgwgzwc9pJNCQlyO5 lRmBilPDVTTP7GXI/yWBArjE+dnFmR0U/jcIgAD7Tky8ivlckY2K1UItiecEaFBhWyD2gEwMRT+Nm G4qdbYvko6K0kPCRv3tu7d9703XyPI3IhFnuozZEqu7REyosFcEorO0hDgpI41bt+3XUtsSoSsmPb 89AZc4BlzYpPF9CnOa7Ast5scRS0axiVyriCe6FdmpdZ9fRMlj+EQXvPnI8F2VIbgZjPooZ+nLOsi 40K0h+dFvfMwmFlzTcIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVB8C-00000003kXu-2SQ1; Wed, 31 Jan 2024 14:00:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVB8A-00000003kXC-0no5 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jan 2024 13:59:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8FF16617A7; Wed, 31 Jan 2024 13:59:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3262FC43142; Wed, 31 Jan 2024 13:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706709597; bh=cX2K5w9GWrdNEUyfrUG6IelYh8NLqv5j8lI66oywVPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r4QN5TZCtY7/sLO9kwHjCm1yV84yTjejctGfEctgi6U1G8d+B+ls+W+CURrrZMweO Xg3My6YVDAGTjBxtTIHoPpI8b0HPctgJgxXU0JvN7qnIOpZSKVWDtLmfZT9CAPjJ8w IuGiaX3U/9QbPXiXpDiHg1MEPxXne9lHEFvg27Iv0sv1SRydlUDYUH1fZ8OHrZk3g+ nbr+GxJRgv9cJ9uosjPtuhNnPAy1fCXo4m1pmBZzQuS9TWL2yes3WVMQI/79OLEM++ mROaw2KnRrEDPKuHV6XGdjVhUxAUaIaxjuxeAHk1UkWZ52NSWx8itb9pL/CFeXdUEP TuyrF7Y/oXPyA== Date: Wed, 31 Jan 2024 07:59:55 -0600 From: Rob Herring To: Johan Jonker Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, mripard@kernel.org, markyao0591@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property Message-ID: <20240131135955.GA966672-robh@kernel.org> References: <6626d288-ecf1-436b-b0a3-3417308a8633@gmail.com> <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240131_055958_291958_74C2F252 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote: > Most Rockchip hdmi nodes are part of a power domain. > Add a power-domains property. Fix example. > > Signed-off-by: Johan Jonker > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index cd0a42f35f24..6f421740b613 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -94,6 +94,9 @@ properties: > - const: default > - const: unwedge > > + power-domains: > + maxItems: 1 > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -141,16 +144,18 @@ examples: > #include > #include > #include > + #include > > hdmi: hdmi@ff980000 { > compatible = "rockchip,rk3288-dw-hdmi"; > reg = <0xff980000 0x20000>; > - reg-io-width = <4>; It makes more sense to keep reg-io-width together with reg. > - ddc-i2c-bus = <&i2c5>; > - rockchip,grf = <&grf>; > interrupts = ; > clocks = <&cru PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>; > clock-names = "iahb", "isfr"; > + ddc-i2c-bus = <&i2c5>; > + power-domains = <&power RK3288_PD_VIO>; > + reg-io-width = <4>; > + rockchip,grf = <&grf>; > > ports { > #address-cells = <1>; > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel