From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 594E1C47DB3 for ; Wed, 31 Jan 2024 14:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TMltXkAXQiX4n7tBakEPW22G8xwa5szD2vAipNa8938=; b=gJ1eImBNmSai5X RRxo6Pop3whQSJctMT217xVWxHDqTa9ZVsbn+5qH3sNKZnr0lLQtpt3Hyzt0PCOTXrngJFpUtiUIy snphBHo/WRJsRem2r6OGHR3hXCGvkq6KUd1ELdFsvc2u47+he/rRWeUnYyCxglI5wW3ElC693Z50b hTXFuwFzAEaWCm0AM7Y3FuSvi2brLb0+VdzOe/s6LKCw3XMuENtx9YXLPQip8NGMXUAEcH4yYH98G pCpOOYBbdmXTg7VyzL9008tcc8yPTO0nEGidNh96WdRlh6YThrHLXc6rqSyTb/GMzU/gXq8yvSx4M dlxVWQcdx564GBO+9tag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVBN8-00000003pFE-3O0G; Wed, 31 Jan 2024 14:15:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVBN6-00000003pE9-2Wen for linux-arm-kernel@lists.infradead.org; Wed, 31 Jan 2024 14:15:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B7D65CE1F5C; Wed, 31 Jan 2024 14:15:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0D88C433F1; Wed, 31 Jan 2024 14:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706710505; bh=ab7imJk06Aq8BClWfw1+COONXRv86lAFnRitwwNKZ20=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LN4XxyPnvDNtHC5lLts6xq3PdjkeOuf8MF48OfdOSQY/zB/xqrre8HfU2YaMN14v+ 70AGSIrkyCGfsl9ux3ydXKr9qvlLKvCUdO4/HcOSGwAxl2HMilm6TiIMEh1g07TDev fkvpNwJWUZjoRlPhVDX2MeX6pwdcCL6+LUtR+hHNfrgD0tVgtYGH2Gx7ERn38OPI/d o/G9Uuky2iBd8LgQe08BH2b1xxC/l16Zclk17U3uqbXiFAxWXyq9mqhg9gtMqu/Xex t8Wzi7FdxwNfrudlpUKCV9Z9Ghk0tVSNOUonihMmMYIpoP7lav9vo05XeUdTCm2S+O lyk5CAaD5Q+zw== Date: Wed, 31 Jan 2024 08:15:02 -0600 From: Rob Herring To: Conor Dooley Cc: Johan Jonker , hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, mripard@kernel.org, markyao0591@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property Message-ID: <20240131141502.GB966672-robh@kernel.org> References: <6626d288-ecf1-436b-b0a3-3417308a8633@gmail.com> <20240130-denim-capacity-e1617595ac9f@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240130-denim-capacity-e1617595ac9f@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240131_061525_020976_996CFD6F X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 30, 2024 at 06:18:49PM +0000, Conor Dooley wrote: > On Tue, Jan 30, 2024 at 03:55:43PM +0100, Johan Jonker wrote: > > The hdmi-connector nodes are now functional and the new way to model > > hdmi nodes with, so deprecate the port property and > > This doesn't really explain what makes having hdmi-connector nodes > replace the usecase for "port". > > > make port@0 and > > port@1 a requirement. > > Why? That means the deprecated way will always have warnings which makes documenting the deprecated stuff a bit pointless. Technically, new required properties are ABI break and something I'm working on making the tools check (by comparing 2 versions of schemas). That said, if all the upstream dts files are fixed already, then I don't care too much. > > Also update example. > > "Also do x" is a red flag when it comes to commit messages, as it > immediately makes me think that this should be more than one commit. > I'd probably write this as "Update the example to avoid use of the > deprecated property" or something to avoid bad gut reactions. > That's not worth resending for though obviously... > > > > > Signed-off-by: Johan Jonker > > --- > > .../display/rockchip/rockchip,dw-hdmi.yaml | 27 ++++++++++++++++--- > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > index 7e59dee15a5f..cd0a42f35f24 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > @@ -97,8 +97,11 @@ properties: > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > - patternProperties: > > - "^port(@0)?$": > > + properties: > > + port: > > + $ref: /schemas/graph.yaml#/properties/port > > + deprecated: true > > This change makes the deprecated property's description incomplete, > since it doesn't cover the endpoints any more. It also doesn't make > port@0 and port mutually exclusive. graph.yaml has a check that effectively does that. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel