Re: Aw: Re: [PATCH v3 1/2] dt-bindings: reset: mediatek: add MT7988 reset IDs

From: Conor Dooley <conor.dooley@microchip.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Conor Dooley <conor@kernel.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Frank Wunderlich <linux@fw-web.de>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sam Shih <sam.shih@mediatek.com>,
	Daniel Golle <daniel@makrotopia.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: Aw: Re: [PATCH v3 1/2] dt-bindings: reset: mediatek: add MT7988 reset IDs
Date: Thu, 1 Feb 2024 13:11:39 +0000	[thread overview]
Message-ID: <20240201-goes-passable-0ba841d36bc3@wendy> (raw)
In-Reply-To: <0EA6A126-DDC0-4E9F-BEBC-FD018B08CA84@public-files.de>

[-- Attachment #1.1: Type: text/plain, Size: 2100 bytes --]

On Thu, Feb 01, 2024 at 12:40:17PM +0100, Frank Wunderlich wrote:
> Am 19. Januar 2024 18:04:36 MEZ schrieb Conor Dooley <conor@kernel.org>:
> >On Fri, Jan 19, 2024 at 10:28:30AM +0100, AngeloGioacchino Del Regno wrote:
> >>
> >> The resets are organized on a per-reset-controller basis, so, the ETHWARP
> >> reset controller's first reset is RST_SWITCH, the second one is RST_something_else,
> >> etc. while the first reset of the INFRA reset controller is PEXTP_MAC_SWRST.
> >> 
> >> That's why ETHWARP has a reset index 0 and INFRA also starts at 0.
> >> I think that the numbering is good as it is, and having one driver start at index 5
> >> while the other starts at index 12 would only overcomplicate registering the resets
> >> in each driver, or waste bytes by making unnecessarily large arrays, for (imo) no
> >> good reason.
> >> 
> >> This is one header, but it should "in theory" be more than one... so we would have
> >> one for each hardware block - but that'd make the reset directory over-crowded, as
> >> other MediaTek SoCs have got even more resets in even more hardware blocks than the
> >> MT7988. That'd be something like ~4 reset headers per SoC (and will increase with
> >> newer ones)...
> >> ...and this is why we have one binding header for resets.
> >
> >That's okay. The commit message leaves me, who clearly isn't a mediatek
> >guy, with no information as to why these are not one contiguous set.
> >IMO being for different reset controllers entirely is fine.
> >
> >> On the topic of leaving space to allow grouping RST0/RST1: -> No. <-
> >> The indices have to start from zero and have to be sequential, with no holes.
> >
> >Agreed.
> 
> Hi,
> 
> Just a friendly reminder.
> 
> As far as i understood, Patches are fine so far and do not need any rework,right?

I suspect I was asking for a commit message that explains why these
numbers don't continue in sequence. With that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> 
> But i have not seen them picked up yet in linux-next.
> regards Frank

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel