From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95F7AC4828D for ; Thu, 1 Feb 2024 18:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5FlbQLOQe+f/HPoDxMoRX81Cl4Tcf4MZXW9GFBfXwn8=; b=qJBAjARTFFlNxopGyVoVYMwLkm PMCiIrACmulsiDr3XtkQm3vfbC+4fB+T7BhiqpRHPKipq816q8nhsNDypruqcp/Vs6Arj6iTwmQXj akL6b+SP6Uk1IZpcjTOuplt3kyxvEJPmSowlzSK0hKY+YPnVP/3ofdaAG10iSA4xdRvOkyCijQ0WK qdeiJl1vQ9FkJB4yUUou3gfDQxRH5lrPUjGt3dXJXmxvMzEnK8yj7wZKRPnViBtsqHItOLMFUbLEP JfEscvA9QfWmYUSEqe7ZBhNjXxV5ycQOFsLW9VjtFMF0yWrWqrhJh66ksn/NonJft9R4rRV31KA59 gpllQcAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVbde-00000008z8c-0rNv; Thu, 01 Feb 2024 18:18:14 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVbdb-00000008z81-2iYs for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 18:18:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0DCA762063; Thu, 1 Feb 2024 18:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F372BC433C7; Thu, 1 Feb 2024 18:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706811490; bh=z6WKuU1HFI/4wMnCCTZC8GXV1OCBNqKCE/QSX/bD25s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l7872NvYaajmupe/mwjNS5jZxcZxKpSbZJlZ/OQobph41jOrTusBjPsuCZO3LzHDd pCv2eDP7sYXlAkiUlcMpIwNgqtVg23CkyD5kFrq95GDUcBBGlzyY5UQZVHboA3hRNe 8wQwK9xfhHnGFFsQ1xScPvnTmvGro8Jj9PnAltk0tyoiIEYOJ+1WHk5Y+ydsRvbmb7 EMxsQAJPVC/P2Z1Hkhh1gL5zfifd2wSBZj7fD3QFu0EH8Aneb7gSFmh7TvOS5t96kb 1wJeF7+9Fdys0HhVQolTtJtn7kcblyYV3an02muu4PVcOLDk4eVwNAF3tSeZsKgh6f FWGpxd84fwufA== Date: Thu, 1 Feb 2024 18:18:05 +0000 From: Conor Dooley To: Roger Quadros Cc: nm@ti.com, vigneshr@ti.com, afd@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srk@ti.com, r-gunasekaran@ti.com, b-liu@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space Message-ID: <20240201-violet-chalice-51a73f113e7b@spud> References: <20240201120332.4811-1-rogerq@kernel.org> <20240201120332.4811-5-rogerq@kernel.org> <20240201-viewpoint-upload-fb714f650ff5@spud> MIME-Version: 1.0 In-Reply-To: <20240201-viewpoint-upload-fb714f650ff5@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_101811_795829_60239941 X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6226041749494288313==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6226041749494288313== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8eQ0qgWYbjjWzvr3" Content-Disposition: inline --8eQ0qgWYbjjWzvr3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote: > On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote: > > So far this was not required but due to the newly identified > > Errata i2409 [1] we need to poke this register space. > >=20 > > [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf > >=20 > > Signed-off-by: Roger Quadros >=20 > Acked-by: Conor Dooley Actually, where is the user for this that actually pokes the register space? You're adding another register region, so I went to check how you were handling that in drivers, but there's no driver patch. >=20 > > --- > >=20 > > Notes: > > Changelog: > > =20 > > v3 - new patch > >=20 > > Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/D= ocumentation/devicetree/bindings/usb/ti,am62-usb.yaml > > index fec5651f5602..c02d9d467d9c 100644 > > --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > @@ -14,7 +14,9 @@ properties: > > const: ti,am62-usb > > =20 > > reg: > > - maxItems: 1 > > + items: > > + - description: USB CFG register space > > + - description: USB PHY2 register space > > =20 > > ranges: true > > =20 > > @@ -82,7 +84,8 @@ examples: > > =20 > > usbss1: usb@f910000 { > > compatible =3D "ti,am62-usb"; > > - reg =3D <0x00 0x0f910000 0x00 0x800>; > > + reg =3D <0x00 0x0f910000 0x00 0x800>, > > + <0x00 0x0f918000 0x00 0x400>; >=20 > Why the double zeros btw? >=20 > Cheers, > Conor. >=20 > > clocks =3D <&k3_clks 162 3>; > > clock-names =3D "ref"; > > ti,syscon-phy-pll-refclk =3D <&wkup_conf 0x4018>; > > --=20 > > 2.34.1 > >=20 --8eQ0qgWYbjjWzvr3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbvgXQAKCRB4tDGHoIJi 0sdAAP9CwtjgDQiVIVOeUV887o2JKyoIPBrTD8GYnJlNJha6DwD9GbpvvnGm33n9 XM3cVekUSO7RnwTFzob/dvmPCq/PrQM= =Qazv -----END PGP SIGNATURE----- --8eQ0qgWYbjjWzvr3-- --===============6226041749494288313== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6226041749494288313==--