From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72B94C4828F for ; Thu, 1 Feb 2024 14:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h900njdG1B1mmsBL+3qPH1tUJdabbWrRITzQN84N6qY=; b=jDcIeid1izkAc5 Uw2/rkXBiWUDVS0LheH7NJIlcEqdzdeJNmR1KtZ1/tUKj+LIZJmW88LCB/V80/shgS+1HA5qpMzAk Dl637JKEylBEHLRsIxW/Zrq0qtuoexEMmbuC6L9SPebwgD3mc1RRBBrnL4XMKFCfLQLV6XSeybuCn STIxsj5vZyw2E+ziqtVZ5rakb5oYBs72bS6rOfXsLXKLJCIYC3xMN5b3hEee1mkEJt1v3OGnL2j9K VbHtQczAuybagQaOWKerbc91/itgLnnqBCuGzgkEv7idy71IbPs4DSx9Qss8avMeoQvioFCIJO967 m2NGbqR9nkcZgkQQSRRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVYVH-00000008LPu-1SkQ; Thu, 01 Feb 2024 14:57:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVYVE-00000008LPG-0iaA for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 14:57:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AAB84615ED; Thu, 1 Feb 2024 14:57:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49727C433C7; Thu, 1 Feb 2024 14:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706799438; bh=586MbdCr4ab+GUo95iwkYyM7AH0vvm3SwJZaU8WxvQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KwWQ48H7tx9fTyOaCsv1FUdP1bHTxEF1PYIlDkUz+Wb/uVQ6Jm0JDWPzvJxbybfhC TpEkzpHbFWkTdFUKDlZ6+J2R3Q8YQPJT6tIPFDFMJRubcIyBwjd5eYYspk4HVLhlfh sTNiKs78cA6Zf6Fa2y6i1CZ22vgHz+oITh0B8J9g= Date: Thu, 1 Feb 2024 06:57:17 -0800 From: Greg KH To: Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Emil Kronborg , Shawn Guo , Sascha Hauer , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Fabio Estevam , NXP Linux Team , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/2] serial: mxs-auart: fix tx Message-ID: <2024020103-dictation-magma-d8ed@gregkh> References: <20240201105557.28043-1-jirislaby@kernel.org> <20240201105557.28043-2-jirislaby@kernel.org> <3935b841-77b7-4265-a727-98a358cd56be@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3935b841-77b7-4265-a727-98a358cd56be@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_065720_336292_6F33760A X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 01, 2024 at 01:05:42PM +0100, Jiri Slaby wrote: > On 01. 02. 24, 11:55, Jiri Slaby (SUSE) wrote: > > Emil reports: > > After updating Linux on an i.MX28 board, serial communication over > > AUART broke. When I TX from the board and measure on the TX pin, it > > seems like the HW fifo is not emptied before the transmission is > > stopped. > > > > MXS performs weird things with stop_tx(). The driver makes it > > conditional on uart_tx_stopped(). > > > > So the driver needs special handling. Pass the brand new UART_TX_NOSTOP > > to uart_port_tx_flags() and handle the stop on its own. > > > > Signed-off-by: Jiri Slaby (SUSE) > > Reported-by: Emil Kronborg > > Fixes: 2d141e683e9a ("tty: serial: use uart_port_tx() helper") > > Closes: https://lore.kernel.org/all/miwgbnvy3hjpnricubg76ytpn7xoceehwahupy25bubbduu23s@om2lptpa26xw/ > > Am I unable to send a proper patch anymore? > > I forgot to add mxs+arm maintainers: > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: linux-arm-kernel@lists.infradead.org > > I can resend with those fixed, if you prefer... Nah, this is fine, I'll take this as-is, thanks! greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel