From: Francesco Dolcini <francesco@dolcini.it>
To: Carlos Song <carlos.song@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
"broonie@kernel.org" <broonie@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"benjamin@bigler.one" <benjamin@bigler.one>,
"stefanmoring@gmail.com" <stefanmoring@gmail.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode
Date: Thu, 1 Feb 2024 09:52:05 +0100 [thread overview]
Message-ID: <20240201085205.GA3906@francesco-nb> (raw)
In-Reply-To: <VI1PR04MB5005EB37DD02F4E32D94336FE8432@VI1PR04MB5005.eurprd04.prod.outlook.com>
On Thu, Feb 01, 2024 at 02:02:36AM +0000, Carlos Song wrote:
> > From: Francesco Dolcini <francesco@dolcini.it>
> > Add #include <linux/bits.h> given you are using BITS_PER_BYTE
> >
> I found that <linux/property.h> has been included in spi-imx.c driver.
> And <linux/bits.h> has been included in <linux/property.h>.
> So I didn't add the "#include <linux/bits.h>" on purpose.
I think you should be explicit and include this header.
Code get refactored all the time and you can prevent issues this way.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-01 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 10:19 [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode carlos.song
2024-01-31 19:42 ` Francesco Dolcini
2024-02-01 2:02 ` Carlos Song
2024-02-01 8:52 ` Francesco Dolcini [this message]
2024-02-01 9:58 ` Carlos Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201085205.GA3906@francesco-nb \
--to=francesco@dolcini.it \
--cc=benjamin@bigler.one \
--cc=broonie@kernel.org \
--cc=carlos.song@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefanmoring@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).