From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9103C47DDB for ; Thu, 1 Feb 2024 08:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2Dis1kEYbrDz9KPbcbmx/s9CqzlIMWRXXU3lbyhmlE=; b=v6s+sseBkOqQi+ K5Hch7aZaHPTCT/OsGwljzs1vJKF6EwAzhWcTxRRsThb5ESOQq/EwR1cwek/maSs1X71DvtwuRByD XUU0DyWGFVb3fzwliSnEpPVY3Ap5AN29EHzIf6w/uqnqNh5TMSfpyfSLgTZZ8PuowSYxXz0btFc7o 9fihW/GEiTd1hzd820dgZUPaQ1i/RrVjdcle4WH4jEI1/DT8i8Vf+wriZTSsMVYMzBH2wOwOKpvw9 xyuQ/zBY/sqhHXqucXMbm1DkWujd3tZeYyTWoO8sEpPDcBMkMnoRz+U8cdAdx7hBNIZd0gyD2XqRC JxsZwGGTm3o0KDHjW9fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVSo3-00000007A07-3iZl; Thu, 01 Feb 2024 08:52:23 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVSo0-000000079ys-3Ccc for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 08:52:23 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 97D8F21597; Thu, 1 Feb 2024 09:52:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1706777536; bh=mEEupIMEH/i7kGo9lESs51Pok88ap/wDkvXExYpqB6c=; h=From:To:Subject; b=nUaY49pE37chEBYH8+n5sOOBXEAToefJYv9tDDSpOJTacwiuUGfCE0VG5Yz42kycG OJUuTvGqNaAQRd0stbkWc4TS8YlPnlF+hiVS4lGfi1I91xi+Gf2i81ezCU4i8QA/6p AJlSAfRYI61qFgBui+F58Y5KAVDU/VS/q7AO4sNECCvhkG7KY3anQRME19SnzYci+u 49LQMvkDbU49ezszAejG9dKLTFOeUCuDKxeDT8oHPIQMzGZ6XTGKuLy8hWuYeZxL7e Ft1jgoC9EAQ0KugT0/spYIAYFcyIiM14hJs5zvDE73n1aRmUDqZ10u/q7b2uXEFDvt CWaLwovoEMCzw== Date: Thu, 1 Feb 2024 09:52:05 +0100 From: Francesco Dolcini To: Carlos Song Cc: Francesco Dolcini , "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , dl-linux-imx , "benjamin@bigler.one" , "stefanmoring@gmail.com" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode Message-ID: <20240201085205.GA3906@francesco-nb> References: <20240131101916.437398-1-carlos.song@nxp.com> <20240131194207.GB12870@francesco-nb> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_005221_883384_A7CCDB07 X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 01, 2024 at 02:02:36AM +0000, Carlos Song wrote: > > From: Francesco Dolcini > > Add #include given you are using BITS_PER_BYTE > > > I found that has been included in spi-imx.c driver. > And has been included in . > So I didn't add the "#include " on purpose. I think you should be explicit and include this header. Code get refactored all the time and you can prevent issues this way. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel