From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51BC8C4828D for ; Thu, 1 Feb 2024 13:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q+n8xklukdypsY4YY1keSwLGH+sL2v6NQVBDoLwOQtE=; b=yhtsJlsc0KreDC cIQBfR5w33aiysnm+v0M3U6z74lrbzR25aXW7KmnL7gC2yGBRt01TrDiivTRhM0uQXC+KuDUybVCx P/wDnOimKhk3cHNOTdGuuZrBA8e/HSCtFTNHodSR6I610ts7Gu+Gz5NWbLBi4bQb45tynKpzr5ZsS kjqhDja5OXQtoTTDB7xnGjp+s4/OQpEnFbogUVTwebeB4/W44G5wx3KWt9gMGNHEYDeWmadX+wuGp XKstPs8oyDzEywGgagdEKdMPF3SuV6oYRpRmrWqGT2OTHkStabNIvV3Az6aACEkB9Il7FAX3ut/au 1jNkeSVh7S94g7YRWdlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVXMc-000000089bz-3JVO; Thu, 01 Feb 2024 13:44:22 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVXMa-000000089az-2Qwr for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 13:44:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 85C82CE269B; Thu, 1 Feb 2024 13:44:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A3CDC433C7; Thu, 1 Feb 2024 13:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706795055; bh=Msf2lTT82pvd+Y2JFn9SvqSk+OAHLJCSOGfkBm5c9aE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BpvwpqNHfGxpiG5WFFWI74s4F2ZciU5GrmZYIAennh8bH+DenvJ9lfuxHSuVXgIwI ulX4YyFhwDseSLSpCyQPCPtbv274afIykVymHUM1DpTRsYQQin4sKAIY/zrd5JFH7L piRAEUXENuq49IRH58HqIYwuP8fxLft0aizTUlydFWzbXRcXOk8Q54C4CIilr14eZ6 rwiPUhqkKFh8IDptO2xiEh60BkAD1xYQ6quOyvasDjn8PfnMun669laS1zUnUc0oNG +nBhNUTLiwLGbEeS5WUuvxxr4uDNGVNBEFRumokVgqzHysJ5taoYCOVmHiE12QhU6r pm9pS7cygFoPQ== Date: Thu, 1 Feb 2024 14:44:09 +0100 From: Simon Horman To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Serge Semin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net v3] net: stmmac: xgmac: fix handling of DPP safety error for DMA channels Message-ID: <20240201134409.GD530335@kernel.org> References: <20240131020828.2007741-1-0x1207@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240131020828.2007741-1-0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_054420_828837_46411EE9 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 31, 2024 at 10:08:28AM +0800, Furong Xu wrote: > Commit 56e58d6c8a56 ("net: stmmac: Implement Safety Features in > XGMAC core") checks and reports safety errors, but leaves the > Data Path Parity Errors for each channel in DMA unhandled at all, lead to > a storm of interrupt. > Fix it by checking and clearing the DMA_DPP_Interrupt_Status register. > > Fixes: 56e58d6c8a56 ("net: stmmac: Implement Safety Features in XGMAC core") > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- > Changes in v3: > - code style fix, thanks Paolo Abeni > > Changes in v2: > - explicit enable Data Path Parity Protection > - add new counters to stmmac_safety_stats > - add detailed log Thanks for the updates. Reviewed-by: Simon Horman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel