From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 089AEC48286 for ; Thu, 1 Feb 2024 16:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=O7LnWDcjdN5TkyEnqF7bh+6jricWmc6GLBWxsiMty5w=; b=Ma6Z/XvnuVpzAk JcsVoFJcGeu5GnctB0B5uFrjZ4n83gRMhEZBhwI1/9XPGueLFvm0POXNBveSxOM5e34Ma9liKMqY/ 7vbh2t05zEBud2oyeijo3M2aE+RqYPdRyiU8z+uyuCWuEH9dmIPp1BfJz8muCbgptlZzMa3aApWl+ /KDYYBj/jM12/F5joVZ42/k9LpQ1q1f/6q72h/RYRKLG1wPE/hvpRFZOwuruMEeZbjf4TZlMgEeoR K0XBw+Crrylt8Ri434zVxab7JNLCF2gluMvQNPVeC0ofvJ4QU2JqfTtQCkQ180S2JnvW6FS2mCf3B 6bPmoGixE3Xe04dnjw6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVaGr-00000008hF2-0HyS; Thu, 01 Feb 2024 16:50:37 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVaGo-00000008hCD-0fQc for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 16:50:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D7506CE274C; Thu, 1 Feb 2024 16:50:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF6D9C433F1; Thu, 1 Feb 2024 16:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706806228; bh=9noK8opVgPqGaHN9hN9yvsJ2bJf6zwggh7pEkAy13bo=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Pl+W0pkOEzU2WA+lrrXlssxS7tk1FrPRyMuIr2QxW4ybWPHZ2fq0u8JnW0Nxq6FF7 5HvNeWqOMZjbtw0B6U2wAb01lm2H+mFQgehHTeI+jb1korrjKesM7mDlucouhV4PSS T57vP0PgxcAPodLjWwdN+sLCRSK8KcnjzWNviOhF2bO2qxbxrdaz933fSP4+7VI6BI A4TRenzME0sCNdT5mp59iJmnl5RVGwoTaOg3d8YMvv0XKG1jBpCBQtzpyiirrdw7Q5 vEphZHusKx7VjImi3ITbTWVlEYrE56T9LSUGiijYORA5QBUfum5K+4RUAytQrLbT9V QR825PYKa1hYg== Date: Thu, 1 Feb 2024 10:50:25 -0600 From: Bjorn Helgaas To: Frank Li Cc: bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, imx@lists.linux.dev, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mani@kernel.org, manivannan.sadhasivam@linaro.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: Re: [PATCH v12 2/3] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions Message-ID: <20240201165025.GA637154@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230821184815.2167131-3-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_085034_393699_7E06BD56 X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 21, 2023 at 02:48:14PM -0400, Frank Li wrote: > Introduce helper function dw_pcie_get_ltssm() to retrieve SMLH_LTSS_STATE. > ... > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index 615660640801..91d13f9b21b1 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -364,6 +375,7 @@ struct dw_pcie_ops { > void (*write_dbi2)(struct dw_pcie *pcie, void __iomem *base, u32 reg, > size_t size, u32 val); > int (*link_up)(struct dw_pcie *pcie); > + enum dw_pcie_ltssm (*get_ltssm)(struct dw_pcie *pcie); This has already been applied as https://git.kernel.org/linus/4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functionality"), but this .get_ltssm() pointer doesn't seem to be used anywhere. Should we remove it until we need it? > +static inline enum dw_pcie_ltssm dw_pcie_get_ltssm(struct dw_pcie *pci) > +{ > + u32 val; > + > + if (pci->ops && pci->ops->get_ltssm) > + return pci->ops->get_ltssm(pci); > + > + val = dw_pcie_readl_dbi(pci, PCIE_PORT_DEBUG0); > + > + return (enum dw_pcie_ltssm)FIELD_GET(PORT_LOGIC_LTSSM_STATE_MASK, val); > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel