From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EBBEC48286 for ; Thu, 1 Feb 2024 17:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=ATyQrC1xDp1KdTrKZ8N5x0opbXDRTZofVg/LO+aBFyo=; b=j/sOLCvBJBC7kZ RIg807x+u7lc3bR9nPnpyx7qu2cWv7kgnqpI1+U+1CAiT4eKZtwZkIJIDM1IsvmFjs8ePgxF93YcF pclfEmTDGSZ3cbGjI3SUSAUSQe7KxaYzxMV6B0+i15vwsar+a+0jX4DoiGik6D/rteKn2RVIku/Ky 0z3T4ZlSHzvJjrZ3VvR9i4jWi65rZevQJhMH51F8KDgsJvfTeW3iLtHdvvTNpBXShMbeeCvQ+8Km9 SxAQ5JLWvthjAcJIywaHcXYwsmUoRCJ4gUe3Cc6BdqfMOw4GzDXcqJi3ilmBxaTcMiqRL2tQWescI lnyZm/AsYTUzXLh1ieUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVbGF-00000008s4w-0tVC; Thu, 01 Feb 2024 17:54:03 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVbGC-00000008s4Y-2zkd for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 17:54:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BAECECE27B5; Thu, 1 Feb 2024 17:53:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7583C433C7; Thu, 1 Feb 2024 17:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706810037; bh=9EOnkhCzyYiI6zRhXrV/SeBRJIFsUA/4cCERx+sXZ3w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QobJeH8Dplg/9zLkUmbKPeEZ0oueAYIF9WhAIPCmHtB8S1ePwgS+V5+ADBrMP8p1/ N7l0WVYCA6TIZj0tVyab6lmAi3RG2QChkl08aFbzzF8i47YetxR/0fpDgkO2RznpNP iRm7cwf0R8TwLzv7iSCMQ2Lxs3fi2aXekoeEGJeiA2PzFaD76pofKq/nzGub77Bvv4 UNO4KTFtfZ3BjmtLV6H/iI3azJkHPUcGZRG+6w+fHQWmvqOFscHcgLucPgd8PagiQL GfiL8HeAlULf16zUVU1mQatGU3cFnOmLKqAEb7XW0HsLJSsy5aFnve7TTxD2dOq76b ZYR6x+N5hWYpQ== Date: Thu, 1 Feb 2024 11:53:55 -0600 From: Bjorn Helgaas To: Frank Li Cc: bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, imx@lists.linux.dev, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mani@kernel.org, manivannan.sadhasivam@linaro.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: Re: [PATCH v12 2/3] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions Message-ID: <20240201175355.GA639928@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_095400_943717_629765B5 X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 01, 2024 at 12:08:23PM -0500, Frank Li wrote: > On Thu, Feb 01, 2024 at 10:50:25AM -0600, Bjorn Helgaas wrote: > > On Mon, Aug 21, 2023 at 02:48:14PM -0400, Frank Li wrote: > > > Introduce helper function dw_pcie_get_ltssm() to retrieve SMLH_LTSS_STATE. > > > ... > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > > > index 615660640801..91d13f9b21b1 100644 > > > --- a/drivers/pci/controller/dwc/pcie-designware.h > > > +++ b/drivers/pci/controller/dwc/pcie-designware.h > > > > > @@ -364,6 +375,7 @@ struct dw_pcie_ops { > > > void (*write_dbi2)(struct dw_pcie *pcie, void __iomem *base, u32 reg, > > > size_t size, u32 val); > > > int (*link_up)(struct dw_pcie *pcie); > > > + enum dw_pcie_ltssm (*get_ltssm)(struct dw_pcie *pcie); > > > > This has already been applied as > > https://git.kernel.org/linus/4774faf854f5 ("PCI: dwc: Implement > > generic suspend/resume functionality"), but this .get_ltssm() pointer > > doesn't seem to be used anywhere. Should we remove it until we need > > it? > > Could you place hold on for a while? I am working on imx PCIe. One old > imx6 may need it! > > If not, I will submit patch to clean it. My new patches depend on > > https://lore.kernel.org/imx/ZbJ+tFPn3aOYHCwf@lizhi-Precision-Tower-5810/T/#t > > All already reviewed, could you please pick up these, so I can continue > my futher work. > > Another > https://lore.kernel.org/imx/20240201-pme_msg-v2-0-6767052fe6a4@nxp.com/T/#t > was under review. OK. I don't see .get_ltssm() used in that series either. But if you will need it soon, no point in removing it right now. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel