From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AB17C4828D for ; Thu, 1 Feb 2024 18:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6CO7yZmXxwjoepZhoosOeLQpd0sGJy/+idNOLgUX+Ug=; b=TiG57/QjyroodJ Kg6MCBhlDnGY13OuGfBf7eoVSyTkYIYjh2uw5nnzD6man5hrVYuUCpWrU16l2qeMOXbexaPzaUZy3 T1G3H8LR+/vfWwJc97i2x8MNwpcgamCuaIULyuRs5cARhOAB5g86oJ31Wa1sBwGQWnVPl35f1Eufq XL6vTvNs7GlM/Rzx3B3mQgoIytr4A6TjdTLlwVCV/CfIGjvJJpyojkuWqySqFTeccT5QhHFxPNcQX zL1nYQ6H1Gw/9+ZQ2jM+i6xsKwma9GgppJYEHsgRvs+aEFcw1yatmQBK4ipmvzSbty8OMD5eV5p9r bV3v2k3NDJB1NZhQ9yog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVbuN-000000092O8-15Ti; Thu, 01 Feb 2024 18:35:31 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVbuK-000000092La-2aaK for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 18:35:30 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 411IZMsW079208; Thu, 1 Feb 2024 12:35:22 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1706812522; bh=rGyK0t8FjhIkG4Ozo6jyOaqYGyp+BnLZYVxHBLTGdgg=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YPTD4j/+4U6wC022MX60ny9ih+0NKv5dh99zxCWvAZCg3fcf3ywlhzGIWAwOk0cDF 3iv9e3A7OHdH5NvYNuWdPTwB6BnKBt9+acBKXa0aZo+KsARyD52l8K4g2rZd+E0F3s xDZzH713gOB3jG4X5O3CbGEMlnQFMgGeHt5ml8gY= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 411IZMQ4089686 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Feb 2024 12:35:22 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 1 Feb 2024 12:35:22 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Feb 2024 12:35:22 -0600 Received: from localhost ([10.249.33.168]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 411IZM7Z032688; Thu, 1 Feb 2024 12:35:22 -0600 Date: Thu, 1 Feb 2024 12:35:22 -0600 From: Bin Liu To: Conor Dooley CC: Roger Quadros , , , , , , , , , , , , Subject: Re: [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space Message-ID: <20240201183522.ssj553rwefr2wuqi@iaqt7> Mail-Followup-To: Bin Liu , Conor Dooley , Roger Quadros , nm@ti.com, vigneshr@ti.com, afd@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srk@ti.com, r-gunasekaran@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240201120332.4811-1-rogerq@kernel.org> <20240201120332.4811-5-rogerq@kernel.org> <20240201-viewpoint-upload-fb714f650ff5@spud> <20240201-violet-chalice-51a73f113e7b@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240201-violet-chalice-51a73f113e7b@spud> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_103528_775540_98FEA151 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 01, 2024 at 06:18:05PM +0000, Conor Dooley wrote: > On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote: > > On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote: > > > So far this was not required but due to the newly identified > > > Errata i2409 [1] we need to poke this register space. > > > > > > [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf > > > > > > Signed-off-by: Roger Quadros > > > > Acked-by: Conor Dooley > > Actually, where is the user for this that actually pokes the register > space? > You're adding another register region, so I went to check how you were > handling that in drivers, but there's no driver patch. See Roger's another patch set 'Add workaround for Errata i2409' posted on 16th. -Bin. > > > > > > > --- > > > > > > Notes: > > > Changelog: > > > > > > v3 - new patch > > > > > > Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > > index fec5651f5602..c02d9d467d9c 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > > @@ -14,7 +14,9 @@ properties: > > > const: ti,am62-usb > > > > > > reg: > > > - maxItems: 1 > > > + items: > > > + - description: USB CFG register space > > > + - description: USB PHY2 register space > > > > > > ranges: true > > > > > > @@ -82,7 +84,8 @@ examples: > > > > > > usbss1: usb@f910000 { > > > compatible = "ti,am62-usb"; > > > - reg = <0x00 0x0f910000 0x00 0x800>; > > > + reg = <0x00 0x0f910000 0x00 0x800>, > > > + <0x00 0x0f918000 0x00 0x400>; > > > > Why the double zeros btw? > > > > Cheers, > > Conor. > > > > > clocks = <&k3_clks 162 3>; > > > clock-names = "ref"; > > > ti,syscon-phy-pll-refclk = <&wkup_conf 0x4018>; > > > -- > > > 2.34.1 > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel