From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC04BC4828F for ; Fri, 2 Feb 2024 20:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ADh8t5fc576JYLsAW5zrBv7UtlylblbT89c6Q5KhDlA=; b=LJhZ3+ocIWMNpV ynKL58Bb+9fiLmXgzrCKFhP6mbhr9eo8wIqLhgo5Eb3ge0eXUsxmEBQcDBHtugCToEKHgqyMdEGU1 K9q5wmi+Ats8XjgB1KF1/5ZfkNTM6knO4MzOnrONkEiNM41jOnj0sXwHzgRqirWbibUKE2/h7D4ET pr/nyDhOgLaCLXvAPRWa30feB5R52UQuaWhqKaL5Gs9H+Fjwv7MUxu2kmZZx4t9DgY7+S0xpilOdf t5idDPzDtZ6SWjat1VWsOpKnxX9WvkI3Dvt4677XOCB65vjyd1ZER2xkXpUNfo/TohA1ePAk1jG5q swnls436Bn1piO3NqAFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rW0SN-0000000DQ4w-2pI0; Fri, 02 Feb 2024 20:48:15 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVzMc-0000000DEPN-1Xzh for linux-arm-kernel@lists.infradead.org; Fri, 02 Feb 2024 19:38:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 54A10CE2D99; Fri, 2 Feb 2024 19:38:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B896C433C7; Fri, 2 Feb 2024 19:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706902690; bh=cXSewaIhyGydS5Gw01kUhO+TK9P0kL9oR3wsJgkpSXw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ovi+0ekJPZurgLg8k360G3rdBWysmMIochoK+bC4Dcn43HvlSf4ueyyed1iL/BIKp pxEKuGpZMJgyE5VB2iyakVKzVkI2z27TLziSvsZ4MBVpP8XEWYFAY5S0rSaNa7I0UG SKlElFrz4Z9VulT1xnl556sxrDbnc+j8TwwhaKH4uSReLWdLMGT2fi1fd8C7dP5jrO rM+V/ev1Bil/ScnFXez9obyL29t300jIRIfkQUgX4ZB9faRUULT7KshaFJKNwYCoHV JObzf2YabL/I7Jf8mWG8M//XHvb2ipLKSxgKCp88Y6Q7G7+p85bTJwyv93zIvOThvZ bwDBvEtB+tMRg== Date: Fri, 2 Feb 2024 13:38:08 -0600 From: Rob Herring To: Mao Jinlong Cc: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang Subject: Re: [PATCH v3 2/2] dt-bindings: arm: Add device-name in the coresight components Message-ID: <20240202193808.GA581322-robh@kernel.org> References: <20240131082628.6288-1-quic_jinlmao@quicinc.com> <20240131082628.6288-3-quic_jinlmao@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240131082628.6288-3-quic_jinlmao@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_113826_609740_B7E14FBB X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 31, 2024 at 12:26:26AM -0800, Mao Jinlong wrote: > Current name of coresight component's folder consists of prefix of > the device and the id in the device list. When run 'ls' command, > we can get the register address of the device. Take CTI for example, > if we want to set the config for modem CTI, but we can't know which > CTI is modem CTI from all current information. > > cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0 > cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1 > > Add device-name in device tree which can provide a better description > of the coresight device. It can provide the info like the system or > HW it belongs to. > > Signed-off-by: Mao Jinlong > --- > .../devicetree/bindings/arm/arm,coresight-catu.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-cpu-debug.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-cti.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-dummy-sink.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++ > .../bindings/arm/arm,coresight-dynamic-funnel.yaml | 6 ++++++ > .../bindings/arm/arm,coresight-dynamic-replicator.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-etb10.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-etm.yaml | 6 ++++++ > .../bindings/arm/arm,coresight-static-funnel.yaml | 6 ++++++ > .../bindings/arm/arm,coresight-static-replicator.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-stm.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-tmc.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-tpiu.yaml | 6 ++++++ > .../devicetree/bindings/arm/qcom,coresight-tpda.yaml | 6 ++++++ > .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++++ Why do you need a name on everything? Funnels and replicators, for example, aren't a source of data, but just connected to things that are. ETM is tightly coupled to a CPU and you have a link to it. You have graph links to show connections. Limit this to where you actually need it. > 16 files changed, 96 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml > index 2bae06eed693..a4d20aad0c70 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml > @@ -44,6 +44,12 @@ properties: > - const: arm,coresight-catu > - const: arm,primecell > > + device-name: This is too generic of a name. Make is something closer to how it is used or what it is for. Naming sysfs devices is not how it is used. That's just an intermediate step. > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Define the name which can describe what kind of HW or system the > + device is for. > + > reg: > maxItems: 1 > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml > index 0a6bc03ebe00..6094cc9cb834 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml > @@ -39,6 +39,12 @@ properties: > - const: arm,coresight-cpu-debug > - const: arm,primecell > > + device-name: > + $ref: /schemas/types.yaml#/definitions/string If you are redefining the type multiple times, there's a problem in the structure of the schemas. Really, that's true for anything duplicated in the kernel. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel