From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39A87C4828F for ; Fri, 2 Feb 2024 20:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7gD5RUIs/dAwoVXeaU5XNxysKczfFR1lRJdv1dq/eHU=; b=F8TM+Y3aOt+fT8 yNwEcsXQ0eZ0rbO1LtnikGCzrYZHujhQ/ESs+RELdF6krK+UQrWM+h70SFFNVLbd9B7/wcELeoN/l +5qX7Uv4sjz7QLNPhVeJxsMV0eV4YVTbO4jTZDDrdqMGfo0nNUKaOaydACfVUWQEciyGePllGfCGV 20R7CfRh6/zMu1XrE4bj/VTI4HNVhR3onFhdYTSCBqcUMsfd+PP1WOx3NO5NmQZd+DOxRxg0j+jAv m0y4MSwkOIcz5rY/djYhcM49yiBOABiVuRNdnIaHFU90zM+1zX+JlFrExM0emXyTbXOZcn6fi4Ef5 9bwco58OUvxJoMS9Bx+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVzyN-0000000DM7a-2y34; Fri, 02 Feb 2024 20:17:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVzxy-0000000DM1z-0WH5 for linux-arm-kernel@lists.infradead.org; Fri, 02 Feb 2024 20:16:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8B07162866; Fri, 2 Feb 2024 20:16:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2836C433F1; Fri, 2 Feb 2024 20:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706905009; bh=u9yn+Xn2jWuc4HFEotKuyuzAo4KRtUgUurWyo7k1u0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lCWRCC2Afb5/YYmBRFKSo9rzO9PfIGnr4WMvy6VFi2vXgiPB+LYnxMFFJ0LM3DAsn 3k/jCXH2SChtKAG/l1naSQzFldPPVMx0PaFoCu8tCPBO0NNjCwLK8r92Z9BSHPfXmr 5KO8iQd0hFPyYt1rZXZZnVrrjaE0uS8EeE0g9eaaFaS44LVXz2CX2p72JerW3rp96y LTn1ZygkoD5Y5OXYXP8b3SyDvP2b2b40/PoDBub8IaGKkYoPSidXBDXDx4SdHZ4m0q iHKI7sylOIsGnsJ+Jl7MLaDIPsYHEGWA629V6qhkVJaEWdOOhNr5pe6od9/LW/WWPZ lNcszgErg44Jg== Date: Fri, 2 Feb 2024 14:16:46 -0600 From: Rob Herring To: Charles Perry Cc: mdf@kernel.org, avandiver@markem-imaje.com, bcody@markem-imaje.com, Wu Hao , Xu Yilun , Tom Rix , Krzysztof Kozlowski , Conor Dooley , Michal Simek , linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] fpga: xilinx-selectmap: add new driver Message-ID: <20240202201646.GA903809-robh@kernel.org> References: <20240129225602.3832449-1-charles.perry@savoirfairelinux.com> <20240131230542.3993409-1-charles.perry@savoirfairelinux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240131230542.3993409-1-charles.perry@savoirfairelinux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_121653_613977_FBC7D914 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 31, 2024 at 06:05:30PM -0500, Charles Perry wrote: > Hello, > > This patchset adds a new driver for the 7 series FPGA's SelectMAP > interface. > > The SelectMAP interface shares a common GPIO protocol with the SPI > interface which is already in the kernel (drivers/fpga/xilinx-spi.c). > The approach proposed in this patchset is to refactor xilinx-spi.c into > xilinx-core.c which would handle the common GPIO protocol. This is then > used to build two drivers, the already existing xilinx-spi.c driver and > a newly added xilinx-selectmap.c driver. > > The SelectMAP driver proposed only supports 8 bit mode. This is because > the 16 and 32 bits mode have limitations with regards to compressed > bitstream support as well as introducing endianness considerations. > > I'm testing xilinx-selectmap.c on a custom i.MX6 board connected to an > Artix 7 FPGA. Flashing a 913K bitstream takes 0.44 seconds. > > v2: From Krzysztof Kozlowski review's: > * Use more conventional names for gpio DT bindings > * fix example in DT bindings > * add mc-peripheral-props.yaml to DT bindings > * fix various formatting mistakes > * Remove all occurences of the "slave" word. Please label the series with the version number and don't send new versions as replies to the previous version. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel