From: Rob Herring <robh@kernel.org>
To: Georgi Djakov <quic_c_gdjako@quicinc.com>
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
robdclark@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_cgoldswo@quicinc.com, quic_sukadev@quicinc.com,
quic_pdaly@quicinc.com, quic_sudaraja@quicinc.com,
djakov@kernel.org
Subject: Re: [PATCH v4 01/10] dt-bindings: iommu: Add Translation Buffer Unit bindings
Date: Fri, 2 Feb 2024 15:17:49 -0600 [thread overview]
Message-ID: <20240202211749.GA1467077-robh@kernel.org> (raw)
In-Reply-To: <20240201210529.7728-2-quic_c_gdjako@quicinc.com>
On Thu, Feb 01, 2024 at 01:05:20PM -0800, Georgi Djakov wrote:
> Add common bindings for the TBUs to describe their properties. The
> TBUs are modelled as child devices of the IOMMU and each of them is
> described with their compatible, reg and stream-id-range properties.
> There could be other implementation specific properties to describe
> any resources like clocks, regulators, power-domains, interconnects
> that would be needed for TBU operation. Such properties will be
> documented in a separate vendor-specific TBU schema.
>
> Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com>
> ---
> .../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++
> .../devicetree/bindings/iommu/tbu-common.yaml | 28 +++++++++++++++++++
> 2 files changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iommu/tbu-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index a4042ae24770..ba3237023b39 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -235,6 +235,20 @@ properties:
> enabled for any given device.
> $ref: /schemas/types.yaml#/definitions/phandle
>
> + '#address-cells':
> + enum: [ 1, 2 ]
> +
> + '#size-cells':
> + enum: [ 1, 2 ]
> +
> + ranges: true
> +
> +patternProperties:
> + "^tbu@[0-9a-f]+$":
> + description: TBU child nodes
> + type: object
> + $ref: tbu-common.yaml#
additionalProperties: false
However, that's going to break with the extra QCom properties. In
json-schema, you can't have 2 schemas and extend the properties of
their child nodes. The validator doesn't "see" the child node schemas at
the same time. You are going to have to move QCom SMMU to its own schema
and remove it from arm,smmu.yaml.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-02 21:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 21:05 [PATCH v4 00/10] Add support for Translation Buffer Units Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 01/10] dt-bindings: iommu: Add Translation Buffer Unit bindings Georgi Djakov
2024-02-02 21:17 ` Rob Herring [this message]
2024-02-12 19:12 ` Robin Murphy
2024-02-29 18:01 ` Krzysztof Kozlowski
2024-02-12 20:25 ` Robin Murphy
2024-02-01 21:05 ` [PATCH v4 02/10] dt-bindings: iommu: Add Qualcomm TBU bindings Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 03/10] iommu/arm-smmu-qcom: Add support for TBUs Georgi Djakov
2024-02-12 17:29 ` Pratyush Brahma
2024-02-13 6:26 ` [PATCH 1/1] iommu/arm-smmu-qcom: Fix use-after-free issue in qcom_smmu_create() Pratyush Brahma
2024-02-13 8:06 ` Dmitry Baryshkov
2024-02-13 8:17 ` Pratyush Brahma
2024-02-13 11:36 ` Robin Murphy
2024-02-29 17:57 ` Krzysztof Kozlowski
2024-02-01 21:05 ` [PATCH v4 04/10] iommu/arm-smmu-qcom-tbu: Add Qualcomm TBU driver Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 05/10] iommu/arm-smmu: Allow using a threaded handler for context interrupts Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 06/10] iommu/arm-smmu-qcom: Use a custom context fault handler for sdm845 Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 07/10] arm64: dts: qcom: sdm845: Add DT nodes for the TBUs Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 08/10] dt-bindings: arm-smmu: Add TBU support for sc7280 Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 09/10] iommu/arm-smmu-qcom: Use the custom fault handler on more platforms Georgi Djakov
2024-02-01 21:05 ` [PATCH v4 10/10] arm64: dts: qcom: sc7280: Add DT nodes for the TBUs Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202211749.GA1467077-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=quic_cgoldswo@quicinc.com \
--cc=quic_pdaly@quicinc.com \
--cc=quic_sudaraja@quicinc.com \
--cc=quic_sukadev@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).