From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDC1EC4828E for ; Fri, 2 Feb 2024 21:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2+UoQSTxzEdJDdBZ+PY/9NDM9caOuF/WNPId5VuSmgg=; b=rPchUO7toyAEI5 yqmGfCuyRqvxp6JiSenUZji6Egv7BgDaqCBxJbRpU1Sh0CjxJkQpzBA09cUey5xSJGMghHJdpyptj JoOsFY+qpR18wxzqFuN4+7FeBhrb2AFoNkiEBwkhV061HeqVvyL4b0gn/KQQBNPdkvCsNuGKftpXr 97+zOoevUsSlJh1OD1F3LdRnVIuGGY92HyMZKNfVgd3eFjOPuTefVNoelC9ID3WrpW/foVeFUqVRz brxqN32QHLbIauQf6HY5twOvk8+XatrIusDstPLKP0BdoNzHZeBP9aIFvCqXuDU01EdStCrPr8/yJ UDQrS8V6PfRNefhtOqgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rW0vY-0000000DVgP-2ll6; Fri, 02 Feb 2024 21:18:24 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rW0v6-0000000DVbn-0xVO for linux-arm-kernel@lists.infradead.org; Fri, 02 Feb 2024 21:18:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 79E93CE2DE5; Fri, 2 Feb 2024 21:17:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BB59C433F1; Fri, 2 Feb 2024 21:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706908671; bh=/VCh0+HPTFG2lAHl8Ir63vVbaWY0czUg4EndhAmsGSQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yvjzg8v2QAYg2UYrB+Vbpmh7MiYTumX0/jy0ou8L09dgeEe2AjOeKOVCL38zLtq2B 3EnMHuQG6hAXgLSwJmtknf63d9V5i8YDh1rpVTeUYLV61yKuBCTvLG3v29pLYY4rV8 1P322vsYsiW3VWtNnWfWTGjTrJMC5ANbMAwJuWvxAlIok42ADCt793YIY9Rkc9FWM1 Coy70l89C4Rk6R5vGd1Uae0XVtfzACT+rF9BkzunQi0BL38hPlS2lFsw1sVmTQNW3I lcnCjL5AZ6qLnoamq/rh7NtQ+GQ91Erg9DYlSvDHqRKq0zW9fJoHt5VUEd+3kcWvYl CKI3HeTmiZgZg== Date: Fri, 2 Feb 2024 15:17:49 -0600 From: Rob Herring To: Georgi Djakov Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robdclark@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_cgoldswo@quicinc.com, quic_sukadev@quicinc.com, quic_pdaly@quicinc.com, quic_sudaraja@quicinc.com, djakov@kernel.org Subject: Re: [PATCH v4 01/10] dt-bindings: iommu: Add Translation Buffer Unit bindings Message-ID: <20240202211749.GA1467077-robh@kernel.org> References: <20240201210529.7728-1-quic_c_gdjako@quicinc.com> <20240201210529.7728-2-quic_c_gdjako@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240201210529.7728-2-quic_c_gdjako@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_131802_597695_D5CC865E X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 01, 2024 at 01:05:20PM -0800, Georgi Djakov wrote: > Add common bindings for the TBUs to describe their properties. The > TBUs are modelled as child devices of the IOMMU and each of them is > described with their compatible, reg and stream-id-range properties. > There could be other implementation specific properties to describe > any resources like clocks, regulators, power-domains, interconnects > that would be needed for TBU operation. Such properties will be > documented in a separate vendor-specific TBU schema. > > Signed-off-by: Georgi Djakov > --- > .../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++ > .../devicetree/bindings/iommu/tbu-common.yaml | 28 +++++++++++++++++++ > 2 files changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iommu/tbu-common.yaml > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index a4042ae24770..ba3237023b39 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -235,6 +235,20 @@ properties: > enabled for any given device. > $ref: /schemas/types.yaml#/definitions/phandle > > + '#address-cells': > + enum: [ 1, 2 ] > + > + '#size-cells': > + enum: [ 1, 2 ] > + > + ranges: true > + > +patternProperties: > + "^tbu@[0-9a-f]+$": > + description: TBU child nodes > + type: object > + $ref: tbu-common.yaml# additionalProperties: false However, that's going to break with the extra QCom properties. In json-schema, you can't have 2 schemas and extend the properties of their child nodes. The validator doesn't "see" the child node schemas at the same time. You are going to have to move QCom SMMU to its own schema and remove it from arm,smmu.yaml. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel