From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C17E6C4828D for ; Sat, 3 Feb 2024 15:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vYpIb84xK7dfYoIFP6CMvvW6YF/sRRCY4z5wLZueJ2A=; b=IBPW5WUIFlbVLLRgZ39DhcEriv TEEPCoM2YzF4erJAIvg4pvi7DmNZR71ohWRYfTL363if5EycU27JwkDMXx9417NH+sXqyygtEsMxc 6LYf+O6kz0SkOfYlbUsLJ+DUQIrrJZmOJrMsVVgmJ/QQqfwYuG/mTMgz8XfHWL62szsyi5EQDX1S/ X/dJ1UZNqrtSmRTJsZY0vdiF6nHi0rb2RF3reFLdB/qmF7tYS+S9yfIz54gh97mYPVJusciv70TsG j9KARvwGfQ9FoFrkg/Tk6YlazLLZzujK1JQgXzsmm0KZQudUj5ADMPA+6+itRpnMDQZBD1IhZd8Dc P9oXPhmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWHdn-0000000GgMy-1fZw; Sat, 03 Feb 2024 15:09:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWHdl-0000000GgMN-0FqW for linux-arm-kernel@lists.infradead.org; Sat, 03 Feb 2024 15:09:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C488760B2C; Sat, 3 Feb 2024 15:09:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CCEAC433F1; Sat, 3 Feb 2024 15:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706972944; bh=n3DQeWHJWDUnE82O0BBKSEXBBTFwmxZR2bU3dokNRDk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=joSUV3VM4rycs/8+EsAkn7lP3I4OCEgqt2ns7lIRdED0K6MuzzofhIRoVC+/okzGn h2tSZcGOQ/ImpmRhUNDtjcXgEekW/dCsf4sxU6THHrXqKoX4p45YcpistEcNgWRHkr eG76v8xhQJPMi+3mKYz1fD5k5GZ8tIcwg3sekctRm+0DG+EF6qR+vYzTmV+QNxmRn3 XkHIme5Ojf+GZE1ONq2wiN1yMj7QPFsMHFd6psU5HphGPF+75cvbwQjGsXfNCATfvq 3VygN4Tn4qLmc04Nlwtq/+/d7HY8cqtHRMobhbXCPHCq5cYitzAkkCdRtJ0G9JfKVB x69x7aOqw4dcQ== Date: Sat, 3 Feb 2024 15:08:59 +0000 From: Conor Dooley To: Josua Mayer Cc: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alessandro Zummo , Alexandre Belloni , Yazan Shhady , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v4 2/5] dt-bindings: rtc: abx80x: convert to yaml Message-ID: <20240203-prolonged-backfield-c659e0016d70@spud> References: <20240202-add-am64-som-v4-0-5f8b12af5e71@solid-run.com> <20240202-add-am64-som-v4-2-5f8b12af5e71@solid-run.com> MIME-Version: 1.0 In-Reply-To: <20240202-add-am64-som-v4-2-5f8b12af5e71@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240203_070909_217045_79CDB1D5 X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6210451952620371684==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6210451952620371684== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="17xXMyX9vB+FnccJ" Content-Disposition: inline --17xXMyX9vB+FnccJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Fri, Feb 02, 2024 at 05:10:49PM +0100, Josua Mayer wrote: > Convert the abracon abx80x rtc text bindings to dt-schema format. >=20 > In addition to the text description reference generic interrupts > properties and add an example. >=20 > Signed-off-by: Josua Mayer > --- > .../devicetree/bindings/rtc/abracon,abx80x.txt | 31 --------- > .../devicetree/bindings/rtc/abracon,abx80x.yaml | 74 ++++++++++++++++= ++++++ > 2 files changed, 74 insertions(+), 31 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/D= ocumentation/devicetree/bindings/rtc/abracon,abx80x.txt > deleted file mode 100644 > index 2405e35a1bc0..000000000000 > --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > +++ /dev/null > @@ -1,31 +0,0 @@ > -Abracon ABX80X I2C ultra low power RTC/Alarm chip > - > -The Abracon ABX80X family consist of the ab0801, ab0803, ab0804, ab0805,= ab1801, > -ab1803, ab1804 and ab1805. The ab0805 is the superset of ab080x and the = ab1805 > -is the superset of ab180x. > - > -Required properties: > - > - - "compatible": should one of: > - "abracon,abx80x" > - "abracon,ab0801" > - "abracon,ab0803" > - "abracon,ab0804" > - "abracon,ab0805" > - "abracon,ab1801" > - "abracon,ab1803" > - "abracon,ab1804" > - "abracon,ab1805" > - "microcrystal,rv1805" > - Using "abracon,abx80x" will enable chip autodetection. > - - "reg": I2C bus address of the device > - > -Optional properties: > - > -The abx804 and abx805 have a trickle charger that is able to charge the > -connected battery or supercap. Both the following properties have to be = defined > -and valid to enable charging: > - > - - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V) > - - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables th= e output > - resistor, the other values are in kOhm. > diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml b/= Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml > new file mode 100644 > index 000000000000..405b386a54b0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/abracon,abx80x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Abracon ABX80X I2C ultra low power RTC/Alarm chip > + > +maintainers: > + - devicetree@vger.kernel.org Ideally you put someone here, not the DT list. Usually the original author is a good choice, which I think happens to be the subsystem maintainer... Failing that, the rtc subsystem list is likely a better choice than the DT one. > + > +allOf: > + - $ref: rtc.yaml# > + - $ref: /schemas/interrupts.yaml# This should not be need. > + > +properties: > + compatible: > + description: > + Select a specific compatible chip. I'd drop this line. > + 'abracon,abx80x' has special meaning, > + it provides auto-dection based on ID register. And reword this. The compatible itself does not provide auto-detection, it's the opposite - the driver must perform auto detection if this compatible is used. > + enum: > + - abracon,abx80x > + - abracon,ab0801 > + - abracon,ab0803 > + - abracon,ab0804 > + - abracon,ab0805 > + - abracon,ab1801 > + - abracon,ab1803 > + - abracon,ab1804 > + - abracon,ab1805 > + - microcrystal,rv1805 > + > + reg: > + maxItems: 1 > + > + abracon,tc-diode: > + description: > + Trickle-charge diode type. > + Required to enable charging backup battery. > + > + Supported are 'standard' diodes with a 0.6V drop > + and 'schottky' diodes with a 0.3V drop. > + $ref: /schemas/types.yaml#/definitions/string > + enum: > + - standard > + - schottky > + > + abracon,tc-resistor: > + description: > + Trickle-charge resistor value in kOhm. > + Required to enable charging backup battery. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 3, 6, 11] > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + rtc@69 { > + compatible =3D "abracon,abx80x"; > + reg =3D <0x69>; You'll have to make a "fake" i2c bus here to satisfy the tooling. There should be lots of examples for how to do this in other rtc bindings. Thanks, Conor. > + abracon,tc-diode =3D "schottky"; > + abracon,tc-resistor =3D <3>; > + interrupt-parent =3D <&fake_intc0>; > + interrupts =3D <44 IRQ_TYPE_EDGE_FALLING>; > + }; >=20 > --=20 > 2.35.3 >=20 --17xXMyX9vB+FnccJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZb5XCwAKCRB4tDGHoIJi 0irkAQCbUpXTrsuLcaoIcKjhRCjmidmeJEVH0ydbqhZIFCeipQD9GXWfXGxujmRu u+QORduBHw9wvIq0cTbVb8HcQlZ5TAE= =ZE4k -----END PGP SIGNATURE----- --17xXMyX9vB+FnccJ-- --===============6210451952620371684== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6210451952620371684==--