From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D2B7C48286 for ; Sun, 4 Feb 2024 14:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SgMXcEmMIxZmNGK+/kaQN5DmTqZ7lm1CeUJdLkGCeeU=; b=Jpz0X2M7kvmjOL TO1Zys1kzYN5USBJuGopRTDL1ceWv9eCnE5mtU0U4072L8FLD2FCWxRPXDG0QQuKHQMH5gr8unE1h jugzvwkBk2T2kdepc7lpbe2C6PAceqQBkD4HwmnkUgZsdalOjM7YgkFpMW/2YH6H/SOsDZrbiN6Nc OOvrMqyCbmPetR6RHaRtFsJobsLJc9xPDsVzoQwOkiGtRPok+rM73bO/b9P5xlve1IDm050kpEA+F 2e2LdDW6ag3Cv0S/UVBudgTzKWwSt7o6nhPQnVtWi57ZU5VNQgVfLGpLEJTZI+wMP8Po7IoyaYTfX BpQ+NUPlsK4AchZCnJkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWdHn-00000000wFX-0y3P; Sun, 04 Feb 2024 14:15:55 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWdHk-00000000wEx-2pbD for linux-arm-kernel@lists.infradead.org; Sun, 04 Feb 2024 14:15:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9C17ACE0170; Sun, 4 Feb 2024 14:15:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59333C433C7; Sun, 4 Feb 2024 14:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707056146; bh=JmTkGp8i+vw27c+X20EOYx2e0BmRC9rlkGs/pm+GBV8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vBcdYC6oZ4MQ6fjYbAD2N4VpqR5hsL7ErqO3yCInP/aH16QftZKyMD+JtyzDVere7 RDMY0koAcQpC1VRDCdbrOUbumH2fulXE6j2ICTgi7u9rLqvpmAZ4JIG5+Nc4JdhSlo PfMIZAe6kinODgWG7CxE2r4zI9qPaTxrHkpuuTuZfQ9U1tbKm/+yOk66Ulya5gnFgM IJ7gFkIDbgybjayLEhhpmX1wVgbaqcpvVJbKv8/X4BZJQGcCanN4dhWuYAZ5RezB+1 9ElwnGuyPcxKdo0bLJORQeVZa4i442Bk8vkhDZsN/Sg/9Mcox0E4VgdoBcY08/h9xN NvrdpGSbGb6xA== Date: Sun, 4 Feb 2024 14:15:41 +0000 From: Simon Horman To: Thierry Reding Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] net: stmmac: Allow drivers to provide a default AXI configuration Message-ID: <20240204141541.GA927333@kernel.org> References: <20240202-stmmac-axi-config-v2-0-64eab2bab17b@nvidia.com> <20240202-stmmac-axi-config-v2-2-64eab2bab17b@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240202-stmmac-axi-config-v2-2-64eab2bab17b@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240204_061552_915441_756821DB X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 02, 2024 at 12:53:34PM +0100, Thierry Reding wrote: > From: Thierry Reding > > In many cases the AXI configuration can be derived from the compatible > string, so there's no need to add the configuration to DT. Allow drivers > to pass in the default AXI configuration so they can be properly set up > without extra data in DT. > > Signed-off-by: Thierry Reding ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 650ec8d2f5d7..0d5f2cebd6fc 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -91,34 +91,49 @@ static int dwmac1000_validate_ucast_entries(struct device *dev, > * if required, from device-tree the AXI internal register can be tuned > * by using platform parameters. > */ > -static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev) > +static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev, > + struct stmmac_resources *res) Hi Thierry, Please consider adding @res to the kernel doc for stmmac_axi_setup, just a few lines above this hunk. ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel