From: Andrew Davis <afd@ti.com>
To: Sebastian Reichel <sre@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-actions@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, Andrew Davis <afd@ti.com>
Subject: [PATCH v2 13/19] power: reset: msm-poweroff: Use devm_register_sys_off_handler(RESTART)
Date: Mon, 5 Feb 2024 13:44:31 -0600 [thread overview]
Message-ID: <20240205194437.180802-14-afd@ti.com> (raw)
In-Reply-To: <20240205194437.180802-1-afd@ti.com>
Use device life-cycle managed register function to simplify probe.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/power/reset/msm-poweroff.c | 23 ++++++-----------------
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/power/reset/msm-poweroff.c b/drivers/power/reset/msm-poweroff.c
index bcf04491e7022..c5831c46f69e2 100644
--- a/drivers/power/reset/msm-poweroff.c
+++ b/drivers/power/reset/msm-poweroff.c
@@ -13,35 +13,24 @@
#include <linux/reboot.h>
#include <linux/pm.h>
-static void __iomem *msm_ps_hold;
-static int deassert_pshold(struct notifier_block *nb, unsigned long action,
- void *data)
+static int do_msm_poweroff(struct sys_off_data *data)
{
+ void __iomem *msm_ps_hold = data->cb_data;
+
writel(0, msm_ps_hold);
mdelay(10000);
return NOTIFY_DONE;
}
-static struct notifier_block restart_nb = {
- .notifier_call = deassert_pshold,
- .priority = 128,
-};
-
-static int do_msm_poweroff(struct sys_off_data *data)
-{
- deassert_pshold(&restart_nb, 0, NULL);
-
- return NOTIFY_DONE;
-}
-
static int msm_restart_probe(struct platform_device *pdev)
{
- msm_ps_hold = devm_platform_ioremap_resource(pdev, 0);
+ void __iomem *msm_ps_hold = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(msm_ps_hold))
return PTR_ERR(msm_ps_hold);
- register_restart_handler(&restart_nb);
+ devm_register_sys_off_handler(&pdev->dev, SYS_OFF_MODE_RESTART,
+ 128, do_msm_poweroff, msm_ps_hold);
devm_register_sys_off_handler(&pdev->dev, SYS_OFF_MODE_POWER_OFF,
SYS_OFF_PRIO_DEFAULT, do_msm_poweroff,
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-05 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 19:44 [PATCH v2 00/19] Remove pm_power_off use in drivers/power/reset Andrew Davis
2024-02-05 19:44 ` [PATCH v2 01/19] power: reset: atc260x-poweroff: Use devm_register_sys_off_handler(RESTART) Andrew Davis
2024-02-05 19:44 ` [PATCH v2 02/19] power: reset: atc260x-poweroff: Use devm_register_sys_off_handler(POWER_OFF) Andrew Davis
2024-02-05 19:44 ` [PATCH v2 03/19] power: reset: xgene-reboot: Use devm_platform_ioremap_resource() helper Andrew Davis
2024-02-05 19:44 ` [PATCH v2 04/19] power: reset: xgene-reboot: Use devm_register_sys_off_handler(RESTART) Andrew Davis
2024-02-05 19:44 ` [PATCH v2 05/19] power: reset: tps65086-restart: " Andrew Davis
2024-02-05 19:44 ` [PATCH v2 06/19] power: reset: tps65086-restart: Remove unneeded device data struct Andrew Davis
2024-02-05 19:44 ` [PATCH v2 07/19] power: reset: brcm-kona-reset: Use devm_register_sys_off_handler(RESTART) Andrew Davis
2024-02-05 19:44 ` [PATCH v2 08/19] power: reset: axxia-reset: " Andrew Davis
2024-02-05 19:44 ` [PATCH v2 09/19] power: reset: rmobile-reset: Use devm_platform_ioremap_resource() helper Andrew Davis
2024-02-05 19:44 ` [PATCH v2 10/19] power: reset: rmobile-reset: Use devm_register_sys_off_handler(RESTART) Andrew Davis
2024-02-05 19:44 ` [PATCH v2 11/19] power: reset: mt6323-poweroff: Use devm_register_sys_off_handler(POWER_OFF) Andrew Davis
2024-02-06 9:33 ` AngeloGioacchino Del Regno
2024-02-05 19:44 ` [PATCH v2 12/19] power: reset: msm-poweroff: " Andrew Davis
2024-02-05 19:44 ` Andrew Davis [this message]
2024-02-05 19:44 ` [PATCH v2 14/19] power: reset: regulator-poweroff: " Andrew Davis
2024-02-05 19:44 ` [PATCH v2 15/19] power: reset: as3722-poweroff: " Andrew Davis
2024-02-05 19:44 ` [PATCH v2 16/19] power: reset: gemini-poweroff: " Andrew Davis
2024-02-05 19:44 ` [PATCH v2 17/19] power: reset: restart-poweroff: " Andrew Davis
2024-02-05 19:44 ` [PATCH v2 18/19] power: reset: syscon-poweroff: Move device data into a struct Andrew Davis
2024-02-06 9:36 ` AngeloGioacchino Del Regno
2024-02-05 19:44 ` [PATCH v2 19/19] power: reset: syscon-poweroff: Use devm_register_sys_off_handler(POWER_OFF) Andrew Davis
2024-02-06 9:36 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205194437.180802-14-afd@ti.com \
--to=afd@ti.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cristian.ciocaltea@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sean.wang@mediatek.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).