* [PATCH] tty: serial: samsung: Remove superfluous braces in macro
@ 2024-02-02 1:05 Sam Protsenko
2024-02-02 7:49 ` Krzysztof Kozlowski
2024-02-06 14:29 ` Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Sam Protsenko @ 2024-02-02 1:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alim Akhtar, Greg Kroah-Hartman, Jiri Slaby, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-serial
Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
leaves unnecessary empty braces. Remove those to fix the style. No
functional change.
Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
drivers/tty/serial/samsung_tty.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index fcc675603b14..23cabdab44ff 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2452,7 +2452,7 @@ static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
#endif
#if defined(CONFIG_ARCH_EXYNOS)
-#define EXYNOS_COMMON_SERIAL_DRV_DATA() \
+#define EXYNOS_COMMON_SERIAL_DRV_DATA \
.info = { \
.name = "Samsung Exynos UART", \
.type = TYPE_S3C6400, \
@@ -2477,17 +2477,17 @@ static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
} \
static const struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
- EXYNOS_COMMON_SERIAL_DRV_DATA(),
+ EXYNOS_COMMON_SERIAL_DRV_DATA,
.fifosize = { 256, 64, 16, 16 },
};
static const struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = {
- EXYNOS_COMMON_SERIAL_DRV_DATA(),
+ EXYNOS_COMMON_SERIAL_DRV_DATA,
.fifosize = { 64, 256, 16, 256 },
};
static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
- EXYNOS_COMMON_SERIAL_DRV_DATA(),
+ EXYNOS_COMMON_SERIAL_DRV_DATA,
.fifosize = { 256, 64, 64, 64 },
};
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tty: serial: samsung: Remove superfluous braces in macro
2024-02-02 1:05 [PATCH] tty: serial: samsung: Remove superfluous braces in macro Sam Protsenko
@ 2024-02-02 7:49 ` Krzysztof Kozlowski
2024-02-02 14:54 ` Sam Protsenko
2024-02-02 15:34 ` Krzysztof Kozlowski
2024-02-06 14:29 ` Greg Kroah-Hartman
1 sibling, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-02 7:49 UTC (permalink / raw)
To: Sam Protsenko
Cc: Alim Akhtar, Greg Kroah-Hartman, Jiri Slaby, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-serial
On 02/02/2024 02:05, Sam Protsenko wrote:
> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
> leaves unnecessary empty braces. Remove those to fix the style. No
> functional change.
>
> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> drivers/tty/serial/samsung_tty.c | 8 ++++----
I am pretty sure you did the patch on some old tree, not mainline rc1.
Please work on maintainers tree (or linux-next).
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tty: serial: samsung: Remove superfluous braces in macro
2024-02-02 7:49 ` Krzysztof Kozlowski
@ 2024-02-02 14:54 ` Sam Protsenko
2024-02-02 15:32 ` Krzysztof Kozlowski
2024-02-02 15:34 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Sam Protsenko @ 2024-02-02 14:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alim Akhtar, Greg Kroah-Hartman, Jiri Slaby, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-serial
On Fri, Feb 2, 2024 at 1:49 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 02/02/2024 02:05, Sam Protsenko wrote:
> > Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> > removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
> > leaves unnecessary empty braces. Remove those to fix the style. No
> > functional change.
> >
> > Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > ---
> > drivers/tty/serial/samsung_tty.c | 8 ++++----
>
> I am pretty sure you did the patch on some old tree, not mainline rc1.
> Please work on maintainers tree (or linux-next).
>
Hi Krzysztof,
I worked on linux-next, and rebased it on top of the latest linux-next
yesterday, right before submitting. I distinctly remember solving a
conflict while rebasing, due to the new commit 0b87a9fd670a ("tty:
serial: samsung: set UPIO_MEM32 iotype for gs101") which just got into
linux-next yesterday. Please let me know if you want me to rebase it
on another tree and re-submit.
Thanks!
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tty: serial: samsung: Remove superfluous braces in macro
2024-02-02 14:54 ` Sam Protsenko
@ 2024-02-02 15:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-02 15:32 UTC (permalink / raw)
To: Sam Protsenko
Cc: Alim Akhtar, Greg Kroah-Hartman, Jiri Slaby, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-serial
On 02/02/2024 15:54, Sam Protsenko wrote:
> On Fri, Feb 2, 2024 at 1:49 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 02/02/2024 02:05, Sam Protsenko wrote:
>>> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>>> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
>>> leaves unnecessary empty braces. Remove those to fix the style. No
>>> functional change.
>>>
>>> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 8 ++++----
>>
>> I am pretty sure you did the patch on some old tree, not mainline rc1.
>> Please work on maintainers tree (or linux-next).
>>
>
> Hi Krzysztof,
>
> I worked on linux-next, and rebased it on top of the latest linux-next
> yesterday, right before submitting. I distinctly remember solving a
> conflict while rebasing, due to the new commit 0b87a9fd670a ("tty:
> serial: samsung: set UPIO_MEM32 iotype for gs101") which just got into
> linux-next yesterday. Please let me know if you want me to rebase it
> on another tree and re-submit.
>
Hmm... Almost two months ago GS101 was applied which also uses
EXYNOS_COMMON_SERIAL_DRV_DATA, so should be in the hunks here, but
maybye it's gone now?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tty: serial: samsung: Remove superfluous braces in macro
2024-02-02 7:49 ` Krzysztof Kozlowski
2024-02-02 14:54 ` Sam Protsenko
@ 2024-02-02 15:34 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-02 15:34 UTC (permalink / raw)
To: Sam Protsenko
Cc: Alim Akhtar, Greg Kroah-Hartman, Jiri Slaby, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-serial
On 02/02/2024 08:49, Krzysztof Kozlowski wrote:
> On 02/02/2024 02:05, Sam Protsenko wrote:
>> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
>> leaves unnecessary empty braces. Remove those to fix the style. No
>> functional change.
>>
>> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>> drivers/tty/serial/samsung_tty.c | 8 ++++----
>
> I am pretty sure you did the patch on some old tree, not mainline rc1.
> Please work on maintainers tree (or linux-next).
My bad, Tudor's patchset changed it few days ago and I missed that it
was applied.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tty: serial: samsung: Remove superfluous braces in macro
2024-02-02 1:05 [PATCH] tty: serial: samsung: Remove superfluous braces in macro Sam Protsenko
2024-02-02 7:49 ` Krzysztof Kozlowski
@ 2024-02-06 14:29 ` Greg Kroah-Hartman
1 sibling, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-06 14:29 UTC (permalink / raw)
To: Sam Protsenko
Cc: Krzysztof Kozlowski, Alim Akhtar, Jiri Slaby, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-serial
On Thu, Feb 01, 2024 at 07:05:07PM -0600, Sam Protsenko wrote:
> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
> leaves unnecessary empty braces. Remove those to fix the style. No
> functional change.
>
> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
"no functional change" don't really deserve a "Fixes:" tag. I'll go
delete this when applying, thanks.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-06 14:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 1:05 [PATCH] tty: serial: samsung: Remove superfluous braces in macro Sam Protsenko
2024-02-02 7:49 ` Krzysztof Kozlowski
2024-02-02 14:54 ` Sam Protsenko
2024-02-02 15:32 ` Krzysztof Kozlowski
2024-02-02 15:34 ` Krzysztof Kozlowski
2024-02-06 14:29 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).