From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8D97C48297 for ; Tue, 6 Feb 2024 13:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nW80RrlfdfYE29S0XhFKJ3ix754zOuZz8fATyAPX0SU=; b=SMmJZ45b0QtF4i GY/eJ232Utp8khFG+aTNTvjFjlQ/w+hQoplAfu6rXZ8F3iJXNEW9OdHYC2XMz9+bsDm1A4AFIsQAr eLzg/wipL4/mMoeW+1+4rGxNWtQKpV8Nn4u+5KWLZEv8LGGheh8UU3HjC48ae4UMmGqsxwGWgd5B+ W3iXIJVaKYhtNqPT4nFaP7EA52YJYIB97d8cq4x5fJsDo6rtDRluJjZUBfFhJHNSfgqNRNBfXUYos 3xs6FkcuvD901NswvCxcexwmiF0vOnoSzkFaN/alEhi6i9rUMlnRHSzFTTxXY1xxQa19DATofGdRE R0dC2oKqbmIEG9tqhncA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXLVz-00000007iq5-4BUS; Tue, 06 Feb 2024 13:29:32 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXLVx-00000007ipX-0Eb4 for linux-arm-kernel@lists.infradead.org; Tue, 06 Feb 2024 13:29:30 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-56001b47285so4574412a12.1 for ; Tue, 06 Feb 2024 05:29:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707226167; x=1707830967; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T3K8mbqYkN2pkZybDOCl4vjMSCHUwiGmdLNrVAvodoY=; b=hhhrWLYHqtNQ22n7OLMgfigobQqIZC9ftHeVv0PVPNLtEPz9UlJP3Ze3MkLvksLM2F ncq8z4sqN9xAiqDTwNS7VfgTm/um9dp24dhdLvgj7jHPxOYexTPMTWRfN4Qr7BFRjYtF tKouPkJ6P5h7GVbzBQvss0YjrSHWxFDZcoMdd+BbHiayDT+rOCJTFYhG/tG2ZiUjC/WB RKnUKBM17UjZN7NPB4mK7DzHELldPLFCciTrAnXDXKHqyqglLwpHB7BhrEqKTRBukp1P 4/FmP+8RzOCiy5S9Ozn1Q1UdzlB47DGpGUV2hhNFPOQ95Q64PTLh+dIzcMhgCuEGu1cD tKRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707226167; x=1707830967; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T3K8mbqYkN2pkZybDOCl4vjMSCHUwiGmdLNrVAvodoY=; b=m/HBg/0fbQo28aBE2K9oM2UmmyDaKYoTdwJgcyTYiiNd8XwKdUmZstTYQDV4S62kPT iADMNwplSZPsM0QJWTG+HiXSDGmRxFY8wtDQ3DxPNZmRrksa9RnYhLSVVLIT0e3SemKB wrGvGMG4ySE2gjJLzBqU6M25Kgfp1U/bhl5x6o9Enh4cbaqbEXhhi6Jdj2jwezGCWV0f nLNmyRvpuWBOZkMyeMp0hi1f1YnDui/y6V8+ODlypChCS+p/4xsV43p+MA8lNQ0KzQXu sVIMX5NKUJqbfFe7M2zHa2VxQpNgI5dzWO4t0uZZQkxdiejpj2mEeyi1bnOUGZIGYtMG h1Lw== X-Gm-Message-State: AOJu0Yz5L1p49Avm4O9LLbh71VHDXuZLeISRsvXngwxfW8+WAd0NAZBz EJ/znJKywV7x+xzSyMm13kyBO/wKaO+VvHoTsaoto+huHD+CNqHh X-Google-Smtp-Source: AGHT+IGTLVlI+eqWQ1ZQHpgJ55q3BV6R5mXCQxRL1l7fryYx1ZyrC2J6wB/lmr+IJkT8F+ppYUfZzA== X-Received: by 2002:a17:907:7f17:b0:a37:7fb9:ea27 with SMTP id qf23-20020a1709077f1700b00a377fb9ea27mr2353193ejc.48.1707226166913; Tue, 06 Feb 2024 05:29:26 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXk8hbCICCWddyCzOnK4U/3MlJvCaV6Wpr8b1jGhhgqCOBdc8qhnubiPfFoS0MAPd/0dffFuFzHlR9IAyVo398lMI/r6ANV7fOIjpmQyicICoI6lbsqnHDAdu6wzUV4zswDsBD1Za/4BBdWU4s6nnP1ldHTrMw/gzlp+VIC9Fdj4AvAn6kWbRhr8lwv+QYH8qyDUdGhwHeKd1TjOEXRY0Yjaly+wKTINW1KyHG8D3XnSj6ztr1HvyDI3AdBhkt7kR3hcXuOtZsF7uriIqp3AYgU8TBlbMPMYjwQpGUj2F226OMakQwNyLODHhsFqCXKsDCYAhEm91M0VbxioWFRyH3UPGZrkcjov+nH85+ySQjCsFsULQBXJYjc2gK0Ph0VjuxbUrgAUG5NkLhcmV+O77qsehH4hWbk3ygPoU7POkNjuApBE1RRK+ManeeTi56VNVD0pnbMlg6XINvE4H2GEv5EUNjceNNiY6yJmPtPbB1PBZV9UFMYK0cGHqFLJMCk2D4LofN3JIjl2c5TgrzyVaNywp1/1aiK1+ZbpTBect2MRkezoWJOrzt0frBaBHAMnuXVJ2dUbXVPS0vuD4BOwS4hO77KB9rH69OjjO/2t8I0BgI39komLmZQ1EjULK9kow0dFApOOv6+27h6iT7EXGbdwKbRfWqvIDDSXFtnhIIdRgvQSzsf77IUz/BmUv/xrgjEtuDG Received: from skbuf ([188.25.173.195]) by smtp.gmail.com with ESMTPSA id cb6-20020a170906a44600b00a35a11fd795sm1137050ejb.129.2024.02.06.05.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 05:29:26 -0800 (PST) Date: Tue, 6 Feb 2024 15:29:23 +0200 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Florian Fainelli , Doug Berger , Andrew Lunn , Heiner Kallweit , Alexandre Torgue , bcm-kernel-feedback-list@broadcom.com, Byungho An , Clark Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, NXP Linux Team , Paolo Abeni , Shenwei Wang , Wei Fang Subject: Re: [PATCH net-next v2 6/6] net: dsa: b53: remove eee_enabled/eee_active in b53_get_mac_eee() Message-ID: <20240206132923.eypnqvqwe3cga5tp@skbuf> References: <20240206112024.3jxtcru3dupeirnj@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240206_052929_119311_ABD8410C X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 06, 2024 at 01:12:33PM +0000, Russell King (Oracle) wrote: > > I know next to nothing about EEE and especially the implementation on > > Broadcom switches. But is the information brought by B53_EEE_LPI_INDICATE > > completely redundant? Is it actually in the system's best interest to > > ignore it? > > That's a review comment that should have been made when the original > change to phylib was done, because it's already ignored in kernels > today since the commit changing phylib that I've referenced in this > series - since e->eee_enabled and e->eee_active will be overwritten by > phylib. That's fair, but commit d1420bb99515 ("net: phy: improve generic EEE ethtool functions") is dated November 2018, and my involvement with the kernel started in March 2019. So it would have been a bit difficult for me to make this observation back then. > If we need B53_EEE_LPI_INDICATE to do something, then we need to have > a discussion about it, and decide how that fits in with the EEE > interface, and how to work around phylib's implementation. Hopefully Florian or Doug can quickly clarify whether this is the case or not. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel