From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DB88C4828D for ; Tue, 6 Feb 2024 17:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OsBS1N4Hch1M/E6Yq9C8Vde8hKwhnxHz4HeDrjQrYKI=; b=Be8sJqNgnGunMx E8ES5nHFK9IN/enj+dFHDh7MT8R8SkoCVmOfXu8RiXkCh6+rhcPb4Em5qzcjKYiY/BH+6LH/frIzw 4b6zTQngdzSc/I0LOhDe+tYPRBBp8Fzamq1PGldgGP6dfC8VzUht8srRlcvGCpEzk1to06e6ICyZ2 C6yjEwJ42BUegqnmZKL03QiMWKHat4FzGJlnreS2jB0gC94Q1aU7q5nR3O9h6fm6dcPFx+7MfftAw 9PNcVlqbynLm8mS5Qrmcg5o1BxjUGBcHVvQ3jKicx6RxLbj40tIzulQnC8MuN79Pal+rKFi1Sf8El ThBAK1IySJhoW8wshOhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXPM2-00000008OtP-37kO; Tue, 06 Feb 2024 17:35:30 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXPLy-00000008Orr-36a0; Tue, 06 Feb 2024 17:35:28 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 22DE240008; Tue, 6 Feb 2024 17:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707240923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xaoA+WDat1FJlr5cBeBddcywk0i1Oklt1CF1ajVk3kM=; b=L2xZfaVhIHa26kVoZAs1UG/T1TeVIT5oX04AE6DGkHNL1za2UbistMzqLYaIIxVNm0CJ/n emHEOFg1uXnVr6famrQDH1v0K3ggxD28JjNSWSwb96rVRvNd3M/WKOzcE1UchoBl+Zb5sE wIl9l5fkr2RdOLgPs4+9HCWrlkQydC4pv+vUvTT5YGxGAMUnRfu6bOZLrdsu2MZ7o70fzQ KLphmSosUipkmfglqar4JYTOAT476ic+DoKCc5Cw7plSJd63GKv66gtOQO8krLixVGpnt5 u/QbJA/otO9hh+ODyrC5glCdsSgqkn1VJPWpqX/RjLEDqYH+nN5sLRMa/kFx7Q== Date: Tue, 6 Feb 2024 18:35:17 +0100 From: Luca Ceresoli To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, marex@denx.de, alexander.stein@ew.tq-group.com, frieder.schrempf@kontron.de, Lucas Stach , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Vinod Koul , Kishon Vijay Abraham I , Catalin Marinas , Will Deacon , Liu Ying , Ulf Hansson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH V8 02/12] phy: freescale: add Samsung HDMI PHY Message-ID: <20240206183517.2b9dfb07@booty> In-Reply-To: <20240203165307.7806-3-aford173@gmail.com> References: <20240203165307.7806-1-aford173@gmail.com> <20240203165307.7806-3-aford173@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240206_093527_075371_83AF00C0 X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 3 Feb 2024 10:52:42 -0600 Adam Ford wrote: > From: Lucas Stach > > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. > > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford > Tested-by: Alexander Stein [...] > +#define PHY_REG_33 0x84 > +#define REG33_MODE_SET_DONE BIT(7) > +#define REG33_FIX_DA BIT(1) > + > +#define PHY_REG_34 0x88 > +#define REG34_PHY_READY BIT(7) > +#define REG34_PLL_LOCK BIT(6) > +#define REG34_PHY_CLK_READY BIT(5) > + > + Nitpick: only one empty line here. > +#define PHY_PLL_REGS_NUM 48 [...] > +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy) > +{ > + struct device *dev = phy->dev; > + struct device_node *np = dev->of_node; > + struct clk_init_data init; > + const char *parent_name; > + struct clk *phyclk; > + int ret; > + > + parent_name = __clk_get_name(phy->refclk); > + > + init.parent_names = &parent_name; > + init.num_parents = 1; > + init.flags = 0; > + init.name = "hdmi_pclk"; > + init.ops = &phy_clk_ops; > + > + phy->hw.init = &init; > + > + phyclk = devm_clk_register(dev, &phy->hw); > + if (IS_ERR(phyclk)) > + return dev_err_probe(dev, PTR_ERR(phyclk), > + "failed to register clock\n"); > + > + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk); Ouch: > This function is *deprecated*. Use of_clk_add_hw_provider() instead. Appears as an easy replacement though. Otherwise looks good. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel