From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11016C4828D for ; Tue, 6 Feb 2024 17:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fmvk9gm/wINBQQYorqr1RBT/gqZ0tO6L+Z/RIUYvBxA=; b=X6b5jvfB3HJnzf f3MYCuHfIwDZjb1fHZPGaa9UmmnEIPVbjiXjLfztT0lrxgjOC7NejijWRYM4U7OEfgX7JOWdWsSk5 WDByJFhH3SnYlhHn6gEVjOS21mr4vrlr8aQ5jWSYpoLlimGbl8Fvtl1ZjHODg4LZI2DRK9jCzA2wF 9CbtzJUntxb4gpdMz9N//PSRVjkmiUVdeZ4AVua+PrSHaDBxaLPZmxoatTmzlxQuN4cZIA2/G3rwx vDtJ7s5Z7jPL8j2GwqV7iaJtOGEAUzF1NFKhwcuZ/2EePYivCIyvKiQ9jcmCIVcO3+pUPLbXyaaTj QiIx6LDOKdhiJQDGBZ0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXPMO-00000008P7T-0DNd; Tue, 06 Feb 2024 17:35:52 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXPME-00000008Ozo-39KR; Tue, 06 Feb 2024 17:35:44 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 89DCE240005; Tue, 6 Feb 2024 17:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707240941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLuicXUcmwZr7iVXdo2HwN/TuKjC2kwohE0VI92lxDs=; b=IuaVpEBeEe5/ma32gG5MmgZMvOrq2t5+fbEpAHp73fD+RHZAyHtZFODysyGWeWitS4VPmj glHDM/ex8iFFVU5cmpwLh/ok/34y1XrCbiLG2u2dvkDYpKhG7Ovjto5L7u5QOHfSOn8YPK z2+SmLsHLThVAomwzIJXC6dLKAZHUfU0iACC4NbxWCKPPf3q2Wc2E+2dhMZWg4yPDp4Kz6 ALQbMYDH/wc+LKvZtj78iAmu8sp3HwhJ8J9mlEepYr/YKI8/BO2jKsYmFX0L3uN1dA9BHU SczZ5hFDtD5M2Ea0LiCv3NPEdYcAOpmmyTP/Kj872voG3PIET650U+XAO6R25w== Date: Tue, 6 Feb 2024 18:35:37 +0100 From: Luca Ceresoli To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, marex@denx.de, alexander.stein@ew.tq-group.com, frieder.schrempf@kontron.de, Lucas Stach , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Vinod Koul , Kishon Vijay Abraham I , Catalin Marinas , Will Deacon , Liu Ying , Ulf Hansson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX Message-ID: <20240206183537.38360f1d@booty> In-Reply-To: <20240203165307.7806-10-aford173@gmail.com> References: <20240203165307.7806-1-aford173@gmail.com> <20240203165307.7806-10-aford173@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240206_093543_255119_6A7AF70B X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 3 Feb 2024 10:52:49 -0600 Adam Ford wrote: > From: Lucas Stach > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. > > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford [...] > +examples: > + - | > + #include > + #include > + #include > + > + hdmi@32fd8000 { > + compatible = "fsl,imx8mp-hdmi-tx"; > + reg = <0x32fd8000 0x7eff>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk IMX8MP_CLK_HDMI_APB>, > + <&clk IMX8MP_CLK_HDMI_REF_266M>, > + <&clk IMX8MP_CLK_32K>, > + <&hdmi_tx_phy>; > + clock-names = "iahb", "isfr", "cec", "pix"; > + power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_HDMI_TX>; > + reg-io-width = <1>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + > + hdmi_tx_from_pvi: endpoint { > + remote-endpoint = <&pvi_to_hdmi_tx>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + hdmi_tx_out: endpoint { Two excess indenting spaces on this line (port@0 is correct). Also, I think there should an empty line between properties and nodes. With these fixed: Reviewed-by: Luca Ceresoli Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel