From: Aren Moynihan <aren@peacevolution.org>
To: linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Chen-Yu Tsai <wens@csie.org>, Ondrej Jirman <megi@xff.cz>,
linux-sunxi@lists.linux.dev, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-leds@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Miles Alan <m@milesalan.com>,
Samuel Holland <samuel@sholland.org>,
Aren Moynihan <aren@peacevolution.org>
Subject: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status
Date: Tue, 6 Feb 2024 13:13:20 -0500 [thread overview]
Message-ID: <20240206185400.596979-4-aren@peacevolution.org> (raw)
In-Reply-To: <20240206185400.596979-1-aren@peacevolution.org>
The status function is described in the documentation as being a rgb led
used for system notifications on phones[1][2]. This is exactly what this
led is used for on the PinePhone, so using status is probably more
accurate than indicator.
1: Documentation/leds/well-known-leds.txt
2: include/dt-bindings/leds/common.h
Signed-off-by: Aren Moynihan <aren@peacevolution.org>
---
I can't find any documentation describing the indicator function, so
it's definitely less specific than status, but besides that I'm not sure
how it compares. Please ignore this patch if it's not useful.
(no changes since v1)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index e53e0d4579a7..6d327266e6cc 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
@@ -61,7 +61,7 @@ led2: led-2 {
multi-led {
compatible = "leds-group-multicolor";
color = <LED_COLOR_ID_RGB>;
- function = LED_FUNCTION_INDICATOR;
+ function = LED_FUNCTION_STATUS;
leds = <&led0>, <&led1>, <&led2>;
};
--
2.43.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-06 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 18:13 [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Aren Moynihan
2024-02-06 18:13 ` [PATCH v2 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state " Aren Moynihan
2024-02-06 18:13 ` [PATCH v2 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Aren Moynihan
2024-02-23 8:46 ` Ondřej Jirman
2024-02-23 15:22 ` Aren
2024-02-23 23:28 ` Ondřej Jirman
2024-02-24 2:52 ` Aren
2024-02-06 18:13 ` Aren Moynihan [this message]
2024-02-22 20:57 ` [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Jernej Škrabec
2024-02-23 10:29 ` Lee Jones
2024-02-23 16:30 ` Aren
2024-02-23 16:36 ` Jernej Škrabec
2024-02-22 21:36 ` [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Pavel Machek
2024-02-23 10:28 ` Lee Jones
2024-02-23 10:31 ` (subset) " Lee Jones
2024-02-23 10:35 ` Lee Jones
2024-02-23 15:32 ` Aren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206185400.596979-4-aren@peacevolution.org \
--to=aren@peacevolution.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=m@milesalan.com \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).