From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 702CFC4828F for ; Wed, 7 Feb 2024 13:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TOY8m2ETsFYNjXqmrKQ/zlJ4BUJvfb1qG2KuqOi8jSQ=; b=vdT5cyOdWLX/Pd Y1eoWBm+vUF8iIJIZ4qbYDMD+QUfD8D6dH5hTHN9UgRTv9YZ3AWUU8IBmL3EFiesGWNAn5LKvU421 /5LYknbnrfQckUJjt8lwYirsj1o4j+0MkOVjVyjZsoK/3dJ87ULt451fLNjs5jWvvknPEtcgY+4hZ DxRKYaDEU3IeoUS6WR+lEcO2L0Hrjr+vY/BL1ydTy5EAGXaNxXtBfzXXbaZ6v1cFW4KXHMMMbbhFD CNhL1sMmIGsPRUG7fAHibMCoTpo25IGuXzz+qPG1ntcI0oRuoAV3Ni1lzwWRldZ+f8iD83aICgwue jQNmOAG8zZ7ai/az56xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXiLj-0000000ApfH-3DFw; Wed, 07 Feb 2024 13:52:27 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXiLh-0000000Apeg-44MA for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 13:52:27 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-55fc7f63639so793067a12.1 for ; Wed, 07 Feb 2024 05:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707313943; x=1707918743; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ssucjkApVHBsZVPy7RMVbGWlOv8R81OtHKLkTIxL75E=; b=MU71Lt947VsZMed57PPMSBWoPQKGJcP02vk3gXDbR1xyrC4qU1YxmbCoV/OB1d6Owe SPAJOsAAyJfOdeczDRFrgeq/CF7RuHfVAYiucpyyyW9SD+f9NKwVkkmASkiQWsj5aAqu AOCS3LG+9SHVG5a4+U9z+zKIQobSbnewJaYlDBrCYTeAX9pXM6nArJzU0qxjLkVInsqj T2pngs6myxJZE4Z9BHHGzXuF9ieAlw62QpDWjBA8iuWEil0HnOZ7cQV3bElgNBE/gj/L VgRitvxAuku/cPOVo8oqsKBk4D9rExbvn15jNDbgJJU4zyaxdOV+PeTA7qyu9aSZblS6 urew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707313943; x=1707918743; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ssucjkApVHBsZVPy7RMVbGWlOv8R81OtHKLkTIxL75E=; b=F3E/07jKiLzcoNZUIBSma4Xwm8K8BE5k7Vb0Qpibbsi6JTr/8tV+CpZaEXg+iHCPFG kXQCpib4cc3Wy5Xkl7MnUAD0W7GxyeIySRkDV8XXQK6moOVTrayDm0v/w6XvgugzfTEq sdYYkIpEPZbpubkcsHGUh7Y6R8FFnt+TY/MDGBO1rk6Ep8EDFsHt8+/zLsSb32iNAc99 wbK40lfZ0ttBViWmWzMV55BmdgCYhc9B5EEZFIvOWZAeJ33T5/syqTsKhYEF3kcsdUTK aJH9aVmvI9ebKI+XfsFyKbZlLDw6aJU1kAnT6tyHvg0tH91AYYp0y4zZaNYVozmSbUS4 iB1Q== X-Gm-Message-State: AOJu0YzRWYXPfvFhhToK3+dWUu6/Dg/L4ggEDJTNjGzSstylZMXBQ0vz afCg8kpMpaK11DJadOpcr89mOmC7XD75pfojXxveTtlrg6RemKo0 X-Google-Smtp-Source: AGHT+IENDHIhbR7wteWQbXtL2mevl2caQhgOmSZZBbuKlHearZm4BYxKy1Kk0y3Hkngo2TMyudHymQ== X-Received: by 2002:a05:6402:1b0b:b0:560:c888:9cf4 with SMTP id by11-20020a0564021b0b00b00560c8889cf4mr1856528edb.28.1707313942560; Wed, 07 Feb 2024 05:52:22 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXi1rfmfbaYmAUzLd6Nkj/pUMld79kgFYZjdrRWY/at3fU7YbH/8fju/1n2729UouFwNWBQbDsEFVdXiGSE+FgZncZ9ioCshkawR7c1Po7aKMgk+y7tZGK887rKNw0rtKcUFAefRTGdXUPQaLFWujuzEPXMLh4RzM1V9OoTt933V62CGj8UgQ8LACqks53aUTrsaWH16//w8VErcsf8U3KensmRKmkYb84nq2+zP2O5oX7YAKkYT72iLELf3i4k2hfkBMeew0y52CtlTP44lhgji5hAtvvKm0RJEzAC1qdJjTPFDDGpD/HKWlQRgobeXVIViTxrR7pj4V47az0xBwBdsOnY0wv06IOUOY/tI/Nc0Eugf0iKN8rAPiZbOMiDrsBixTIHTXVXroh5G6RITtUvD77vIgKc1CHegNRsPD0Ounda/JjTN5UMZj4W44Vpvo9cTuZJxPf4OFTb0azG9dUMTIgmcMTmro29H9O0nomlQ7tasrXz+WRtlYSB0NCIxNoEeyPpycbXwCTqJrCF52e/pTtt6C+BE+cjIp86A4L+UJNklTi862r5IEolwJZwqklN8SDlBz+rxBCBTx7nmdQ2lJ5u6Jl8VW/LIfXdODOm3PFVozVb60knGgwJf+1l+q7Frkhv2K2Fxdpr4QkTHEORhNGbBvQhCfQqEnZle798Gne47wylrnO5s6Z+u4O6jGCIecHbo/LTInSDj5Xo6mmoRqnn6V2OYWslv31cIWxEw8meBg== Received: from skbuf ([188.25.173.195]) by smtp.gmail.com with ESMTPSA id fi25-20020a056402551900b00558a1937dddsm686175edb.63.2024.02.07.05.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 05:52:22 -0800 (PST) Date: Wed, 7 Feb 2024 15:52:19 +0200 From: Vladimir Oltean To: Florian Fainelli Cc: "Russell King (Oracle)" , Florian Fainelli , Doug Berger , Andrew Lunn , Heiner Kallweit , Alexandre Torgue , bcm-kernel-feedback-list@broadcom.com, Byungho An , Clark Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, NXP Linux Team , Paolo Abeni , Shenwei Wang , Wei Fang Subject: Re: [PATCH net-next v2 6/6] net: dsa: b53: remove eee_enabled/eee_active in b53_get_mac_eee() Message-ID: <20240207135219.7wr4hctzjuanotxv@skbuf> References: <20240206112024.3jxtcru3dupeirnj@skbuf> <20240206132923.eypnqvqwe3cga5tp@skbuf> <57406055-ff3c-4788-bbf7-8476f63f90db@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <57406055-ff3c-4788-bbf7-8476f63f90db@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_055226_032085_8F8F100D X-CRM114-Status: GOOD ( 25.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 06, 2024 at 08:25:17PM -0800, Florian Fainelli wrote: > > > On 2/6/2024 5:29 AM, Vladimir Oltean wrote: > > On Tue, Feb 06, 2024 at 01:12:33PM +0000, Russell King (Oracle) wrote: > > > > I know next to nothing about EEE and especially the implementation on > > > > Broadcom switches. But is the information brought by B53_EEE_LPI_INDICATE > > > > completely redundant? Is it actually in the system's best interest to > > > > ignore it? > > > > > > That's a review comment that should have been made when the original > > > change to phylib was done, because it's already ignored in kernels > > > today since the commit changing phylib that I've referenced in this > > > series - since e->eee_enabled and e->eee_active will be overwritten by > > > phylib. > > > > That's fair, but commit d1420bb99515 ("net: phy: improve generic EEE > > ethtool functions") is dated November 2018, and my involvement with the > > kernel started in March 2019. So it would have been a bit difficult for > > me to make this observation back then. > > > > > If we need B53_EEE_LPI_INDICATE to do something, then we need to have > > > a discussion about it, and decide how that fits in with the EEE > > > interface, and how to work around phylib's implementation. > > > > Hopefully Florian or Doug can quickly clarify whether this is the case > > or not. > > Russell's replacement is actually a better one because it will return a > stable state. B53_EEE_LPI_INDICATE would indicate when the switch port's > built-in PHY asserts the LPI signal to its MAC, which could be transient > AFAICT. > -- > Florian Thanks, Florian. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel