From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47F29C4828D for ; Wed, 7 Feb 2024 13:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ibiMHGZ39NzRbgJ5Ys8DuhaUKt/3KLjbAj1EhCwf/RI=; b=mJMquUrBikUtvo WCgwn6WXapKx1++WRJAcykVPGc9Eho6YU7RBd9D0ypVuosHBGRB1epvV7lP953DT8srBmftu3459z 3j5GOr9OOY8IMN4WNkZuEDutWYHxiOY4Iw4V4y1jos4S/5C8TeK6ttYaLXiSdi5592bA+0jsW0kAB i3vKap59hA61CfWqDw3vKUUNbvhG9WxUjoVUXtXo8mBGXNqzFmAZtYOZa+R5ImDFJrvk3ca4KZWNz kiNuoAS+OsbrLLYFoueegzmKJo3cuzx1vGddOxuvdbrIcYaMCVmNXMvT0ec5cr1sBJ80SFE8QCn98 KejRArqAZjLS8m5OOOUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXiOe-0000000Aq6s-3cPK; Wed, 07 Feb 2024 13:55:28 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXiOc-0000000Aq5I-26wJ for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 13:55:27 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-5115fcef9e9so821672e87.3 for ; Wed, 07 Feb 2024 05:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707314124; x=1707918924; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=by92DEK9XSM7323pyJ6TZwfJcKH/EW0cCEEjPXbhw7o=; b=flhDFgt2NUgSJ1JP7wvzttno+gB1MQDQiadL6Vi2n0h8ghQPw2jFEwKnmswjBgtnLh ZYrfRtRVXvXfHzdUikqMAhYnubGu42nEd1JodsTcD8al/Eav4U83CBKP6Z24MK/0nadz iiZXYUnoSakt2TV8xbwSmYX2UCHhXGFjgofx9fxRLUeMBv4pGUGqlMYxZIo4Zf1pcvYk 6bGAgsShpBSCPiKotCrloXlOOKVmC28aoEXOoSbxIdkxywMLzCawAxhZWmauM3gqeIFC XbK2Im5Y82YT9TrfC0bmUbJyX8qu7o7FQpUw1/Q3HT5QNNyDK4upi2Bq3deK49vn4WYc uc4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707314124; x=1707918924; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=by92DEK9XSM7323pyJ6TZwfJcKH/EW0cCEEjPXbhw7o=; b=lw31O9H1SlgmXY7P1tBwpC8a3vz9npjFto8M2W/QBZkzv/R9qzLXQPOsGD9FdwA0BU IM30zs5378U2HRymf4BCbXI5m8aHSVldbEuj1Atw8ORQg/qEEw+U0qGmSVCjgeN2axX8 tRTUscOgnKFck0vyPfmbs3JO/AsvN9zHsZ1uVLBe0Ylw2F4zL3trqrY61ws5kT1zH7W0 QyhNbMqU6LUfpOUnNvrgN/jHwNdpvAYSas1TbCN9l2IkouTFB0CtErdmCqLhk5WbdZp0 sRSvrqPiS1+XvPg9eJrpHP1NOG1Mfji27Zhz9vYh4GDd5fJGzvoNGqQ2CkniaDj+WeQB a9tg== X-Forwarded-Encrypted: i=1; AJvYcCWXmsE64jOlLhpdG1z0aqMc494wH8PdpRrsCw0RnMJj+FPQ6MxFBJmFo+FS9iZfV2Yi5+TxOeQKImEWPxa+KFpLTbcarb2WaY8Ls6Yh+SXnWphSjKU= X-Gm-Message-State: AOJu0Yw5sDD7nO1r9RtUXr+QkPhaJDWS6JvRhH5q1y9+IBFojh9qOKhG rdzeQLI/8qyBhTROxyk1H3/6BlfepJTkOkZxRk/RnTSi3weFnCIs X-Google-Smtp-Source: AGHT+IEOk2AGdPkr7JjjRj6vF2sVns8SA640c0gyoR1lwxnBMBbazqa3bKt4C73kzX1xoHZE68EIJQ== X-Received: by 2002:ac2:5617:0:b0:511:519f:ce76 with SMTP id v23-20020ac25617000000b00511519fce76mr3986759lfd.57.1707314123579; Wed, 07 Feb 2024 05:55:23 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUjIt/4gQu1zQesvxRtHLJAF5eS33qGSRoCJO2FtTNPXb1q75lKmjmmgZwe1g+ew0Mphc9I1vYxMMYOLQXkwgdeDq+eHtiMexn/lqKbb0sy9NKkFE/6c5/DL6oNQF+5dy82P79bLa7JDxwu3auc6KaU8xyuInyU5cY0ipGHYsIPOOyGbuJEvaUD5Wa2XtrR2e+9b1f4COALVpyqLPx8CXB7FnpkSorKs7rBrCcZb7jkPzmw++DxjFkXndUd6IheVyeQnOxIuv++wAPTOAyWWv+MhmaeEhqjPbplqioiVcNtJRv3doP0tlmqxml4u+nCPAsDS/ZVc2P9QOWfIF8zEgKckADaRZ+UBdGPoJDk759wqyxLH+8rVtj3ZQJpnKinysqyt9TbFtK4Dd1warPD+Qe6ErZyoaXPbF5BJP91mL66WEhEv2QxrEbIbzZ3IRvUFKasGsj7zt1+Mnc6fkhxjT+/wfi4Fk0ZnjwOOL93IqfUbLGz4b/yBgVUq4INNgji4r68Sm6TiDWpqFLwJ78cMFJay43NGPNUVhuX/LsCS8l35Bsx0/RRC9DVzT462gkTtSFMJpfNaNOh1P8ZVHewQrOda1lGKyeQa1UgIqN3kLsyIncLHQT3rqYkyKzTkP1shgKcXqxyoO2hhZFGIdnAJTi/5zaznFZdpIZzlJ0coO/dvSQCePXO6ZRLE0CLKnOgB+cMy9DVoscSHJ5KvBt8NP61luZA Received: from skbuf ([188.25.173.195]) by smtp.gmail.com with ESMTPSA id gr8-20020a170906e2c800b00a3840fbeef9sm779222ejb.70.2024.02.07.05.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 05:55:23 -0800 (PST) Date: Wed, 7 Feb 2024 15:55:20 +0200 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , bcm-kernel-feedback-list@broadcom.com, Byungho An , Clark Wang , "David S. Miller" , Doug Berger , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jose Abreu , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, NXP Linux Team , Paolo Abeni , Shenwei Wang , Wei Fang Subject: Re: [PATCH net-next v2 6/6] net: dsa: b53: remove eee_enabled/eee_active in b53_get_mac_eee() Message-ID: <20240207135520.2zvinnv5w3v7kruk@skbuf> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_055526_577405_AE4AEED8 X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 04, 2024 at 12:13:28PM +0000, Russell King (Oracle) wrote: > b53_get_mac_eee() sets both eee_enabled and eee_active, and then > returns zero. > > dsa_slave_get_eee(), which calls this function, will then continue to > call phylink_ethtool_get_eee(), which will return -EOPNOTSUPP if there > is no PHY present, otherwise calling phy_ethtool_get_eee() which in > turn will call genphy_c45_ethtool_get_eee(). > > genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active > with its own interpretation from the PHYs settings and negotiation > result. > > Thus, when there is no PHY, dsa_slave_get_eee() will fail with > -EOPNOTSUPP, meaning eee_enabled and eee_active will not be returned to > userspace. When there is a PHY, eee_enabled and eee_active will be > overwritten by phylib, making the setting of these members in > b53_get_mac_eee() entirely unnecessary. > > Remove this code, thus simplifying b53_get_mac_eee(). > > Reviewed-by: Andrew Lunn > Reviewed-by: Florian Fainelli > Signed-off-by: Russell King (Oracle) > --- Reviewed-by: Vladimir Oltean I see the series was put in "Changes Requested", possibly due to my clarification question. Let's see if I can change that. --- pw-bot: under-review _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel