From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E06D6C4828D for ; Wed, 7 Feb 2024 13:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W93hOTNrNTAJp9siSkLrA67U73s56niSV8LETTUXA2g=; b=3M7E8Xq5mkVT+b 8V9dPhAVk4P+t0+21IRkwebu/xBNtke481b9uK+Vm3JMBMJr4sLx4TggpIFtHuNkaUTbp83ra2eAf zK7ilYmaDp51fHtOC9yrGW89TDkaRmusiVE/czdrfqWGwzgCnI6gCiJIrzMBe32O5cnJodfvxcL/c hM0/ehR9Uq4KFKOCvuk8zPcjrn/3MnStRyaAw0Ol4IAV9eLIIlCGZQjen0Y8coY0eVQ7GoRlwpcuG gLG5yHIPQ2T/O9mHAvJPShrNBymScFFOb+0w8Ockt5qu5bbo5edWlEDBCG/AITg37SjKScD863X3H p2/rO1kBAbHnQlRqDaFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXiQk-0000000AqQC-41fx; Wed, 07 Feb 2024 13:57:38 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXiQi-0000000AqPf-19lK; Wed, 07 Feb 2024 13:57:37 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 018AEA27; Wed, 7 Feb 2024 14:56:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1707314171; bh=QMGIgzK3ks407x+VtjPVEK4eOUKLE0Kww8D7ARO/WPg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hIkS4nxw6ve6FBd5Fy4ZqwwoWvpQfO4Qg++yrNnC4c9yu7KftLygQmqk0lzcisdtM 2HKf1bVJ6wa8wBIQY9EYVmUfweqqnwJhyDKicMxYV3q2v+L/aLG7U2EZIwp5z/El34 SzFGzO2seoakuCc1jIdWPBz4DtF2uIYBMel3kflA= Date: Wed, 7 Feb 2024 15:57:37 +0200 From: Laurent Pinchart To: Kuninori Morimoto Subject: Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint() Message-ID: <20240207135737.GI2827@pendragon.ideasonboard.com> References: <87ttmmnvzh.wl-kuninori.morimoto.gx@renesas.com> <87plxanvx1.wl-kuninori.morimoto.gx@renesas.com> <20240206162506.GC2827@pendragon.ideasonboard.com> <875xz1tave.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <875xz1tave.wl-kuninori.morimoto.gx@renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_055736_479247_012F2835 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Alim Akhtar , Sam Ravnborg , Alexandre Torgue , dri-devel@lists.freedesktop.org, "Lad, Prabhakar" , Andrzej Hajda , Sylwester Nawrocki , Sakari Ailus , David Airlie , linux-stm32@st-md-mailman.stormreply.com, linux-omap@vger.kernel.org, Florian Fainelli , Dave Stevenson , Hugues Fruchet , Helge Deller , Alexey Brodkin , Russell King , Broadcom internal kernel review list , =?utf-8?Q?=22Uwe_Kleine-K=C3=B6nig=22?= , Jessica Zhang , linux-media@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , Tim Harvey , Maarten Lankhorst , Eugen Hristev , linux-samsung-soc@vger.kernel.org, Maxime Ripard , linux-fbdev@vger.kernel.org, Biju Das , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Neil Armstrong , Thomas Zimmermann , Claudiu Beznea , Krzysztof Kozlowski , Daniel Vetter , Hans Verkuil , linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 06, 2024 at 11:45:58PM +0000, Kuninori Morimoto wrote: > > Hi Laurent > > Thank you for your review > > > > diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > > index 686ca8753ba2..3f8bea2e3934 100644 > > > --- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > > +++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > > @@ -728,7 +728,7 @@ static int s5pcsis_parse_dt(struct platform_device *pdev, > > > &state->max_num_lanes)) > > > return -EINVAL; > > > > > > - node = of_graph_get_next_endpoint(node, NULL); > > > + node = of_graph_get_endpoint_by_regs(node, 0, -1); > > > > This is not correct, see > > Documentation/devicetree/bindings/media/samsung,exynos4210-csis.yaml. > > Hmm... Then, It can be like this ? > > + node = of_graph_get_endpoint_by_regs(node, -1, -1); I suppose that would work, even if we should really try not to pass -1 for the port. Rob, any opinion ? -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel