From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5730AC4828F for ; Thu, 8 Feb 2024 18:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AS2dKooFiLfhM3f1xnoh1jlxoyfx2lwKRr2VCg4b9i0=; b=Nbjq6ndC7zog8Ksq5uWQaMqrbV MNL53fsl0bx2ey1qrQyUpDfwO5gdtttwR3GQM9Sk+rdrkmA7kpPs6ft8Z7jfCHABitPjoPROVW3Jc EPMx3TkK0eL/mAWAZXAYqCHl+YYXg147wgfv/cOKPyOlk1ATEQWZVLkVrmFmmZ7ik+ng64ioiA+hx f9uWQZ4enQxw+N2VWM3G2PtRdwTF87K7oDex1f+6Lv9eMXFn1V9cxEDcIxbRrVASG8Y+pzaO/DlhA ta8MrPbbBGRBbGrCnjCRN55YIigBtjsjZPaUFf514CZz8jhsOI7UvjxK50DGWp6hfzUbKKO6mNa4C ODlmZgwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY94Q-0000000Ebcj-0UIL; Thu, 08 Feb 2024 18:24:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY94N-0000000EbcB-0mHe for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 18:24:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 51EA561EC7; Thu, 8 Feb 2024 18:24:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5C38C43394; Thu, 8 Feb 2024 18:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707416658; bh=NhYY0t1oDuUXa7DHyLNcCO0JhwCrsEO5ZObT6pq9Q+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qvQo1cpIymsOA3kSoD0y9VckEBA+Ta+ycoUt9JP9dXHWQegPw+LvQ7lTUnEoSz9pm qVv+/+yxOqlislPjf/Hh8DaDtdRBCY/MvP3eZw//elsZFexiUmgy8RChjf2wd1ZBbl U0ehVQ6CYlQeKUwb5g7F7HuedHsUDkQfB+gl+WmCO2eXaUEi+2Bb1Z2zBdhOvvWWSD 3zYjziw72b9zDuJhm2pjpmctQfBCGzJHgviJC+/R3AP02hCDV2nCiopFXWEZxuA1fa qaM5rdwdsKWq6y66H7CRgsxfy0FRVvgrz/4MjsZ6BsIgVk/G4ZXyQD4hsLz4agi/hg OaWLO72DWW5Gw== Date: Thu, 8 Feb 2024 18:24:12 +0000 From: Conor Dooley To: Tudor Ambarus Cc: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH 01/12] spi: dt-bindings: introduce the ``fifo-depth`` property Message-ID: <20240208-grating-legwarmer-0a04cfb04d61@spud> References: <20240208135045.3728927-1-tudor.ambarus@linaro.org> <20240208135045.3728927-2-tudor.ambarus@linaro.org> MIME-Version: 1.0 In-Reply-To: <20240208135045.3728927-2-tudor.ambarus@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_102419_333645_54307B55 X-CRM114-Status: GOOD ( 16.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3386465803727272857==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3386465803727272857== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rPlINU3cZvGxB9hH" Content-Disposition: inline --rPlINU3cZvGxB9hH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 08, 2024 at 01:50:34PM +0000, Tudor Ambarus wrote: > There are instances of the same IP that are configured by the integrator > with different FIFO depths. Introduce the fifo-depth property to allow > such nodes to specify their FIFO depth. >=20 > We haven't seen SPI IPs with different FIFO depths for RX and TX, thus > introduce a single property. Some citation attached to this would be nice. "We haven't seen" offers no detail as to what IPs that allow this sort of configuration of FIFO size that you have actually checked. I went and checked our IP that we use in FPGA fabric, which has a configurable fifo depth. It only has a single knob for both RX and TX FIFOs. The Xilinx xps spi core also has configurable FIFOs, but again RX and TX sizes are tied there. At least that's a sample size of three. One of our guys is working on support for the IP I just mentioned and would be defining a vendor property for this, so Reviewed-by: Conor Dooley Thanks, Conor. >=20 > Signed-off-by: Tudor Ambarus > --- > Documentation/devicetree/bindings/spi/spi-controller.yaml | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/= Documentation/devicetree/bindings/spi/spi-controller.yaml > index 524f6fe8c27b..99272e6f115e 100644 > --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml > @@ -69,6 +69,11 @@ properties: > Should be generally avoided and be replaced by > spi-cs-high + ACTIVE_HIGH. > =20 > + fifo-depth: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Size of the data FIFO in bytes. > + > num-cs: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > --=20 > 2.43.0.687.g38aa6559b0-goog >=20 --rPlINU3cZvGxB9hH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZcUcTAAKCRB4tDGHoIJi 0j4tAP9wfGzupRs/uJ9s16k8o3KzbLzjn/TaEfWzAuiE4hxX4wEA5U1nuuXWBR0x gYqzzLuJIoHfQ4vImDfzN6zyxv0HEAA= =glJv -----END PGP SIGNATURE----- --rPlINU3cZvGxB9hH-- --===============3386465803727272857== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3386465803727272857==--