From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AF11C4828F for ; Thu, 8 Feb 2024 10:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vQ44/uHhi0yVQW2xpYKC9t2dI97teE1mjZkX59zNDW0=; b=VoPBVBXP96mRwV 9s/0N+qzQEX/tMOU6k5vb7bElWVJplPn4PPeeLfxslW3p8Z6gFHZX05hRCG/lcn1JVNAkpZV5BaJW 7xMZHwF7aJA/nn3PryC/MnxfkLLyb08wA3EYW1dJWS7oC691MsrlDLuHnKg8FacZCK6BPP3SubPtN EAdCvGmpcdccPwz4xaQQepfJE6D2uLT81CLnttEOV7/rmwjx9RUMF6oLTjqKN6RkBAMSAex8iEQor NhfutwDXijeWmaf5pGQL4e6ShhSXq7BZ6duAGGboh1wZisKxdHNHs7T16Y1yu/NQ7UZuGak0BMMLd 6OVl69sHjTaDgPWEh8pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY1vx-0000000DPuv-3QRh; Thu, 08 Feb 2024 10:47:09 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY1vu-0000000DPtD-2Am5 for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 10:47:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0251A61B63; Thu, 8 Feb 2024 10:47:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8277C433F1; Thu, 8 Feb 2024 10:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707389225; bh=sPqmIJG0j0Uvrtvc2UIvS8rx1hAClYJBsgbyABemMpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G9199IHza2HfLtJsyzAbJ18admPXPU3144BdmYC+e/ReX9WePUpmSYTjcuFbQuIjC 3hVYZURLW3bZARH1YuG6vCmxGNtH5ucIoZ+q02Mr2ENTTt2aCbK+oP0LZfYcZ69XwL 3gTLpKPLvo37O7k5ERr1PBtFHgwer4ptn4flr9kWQfXxmjkwCWuWqprhy7sm+8/zGH 8wIgej8BYwDHBsJePSMPe5dbvlbc59Uq5qmjlY2v/6yip0dQmdcXCQ5Ud4IAyA7gI8 RXSOGB8AxJwx1WnuyWa4EqEF1nBRVVui7TaFWFqZLaen3c0ztBCtAJUGrIxUvCp+ob v42RS4V8GEGHw== Date: Thu, 8 Feb 2024 10:47:00 +0000 From: Simon Horman To: Diogo Ivo Cc: danishanwar@ti.com, rogerq@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, vigneshr@ti.com, jan.kiszka@siemens.com, dan.carpenter@linaro.org, robh@kernel.org, grygorii.strashko@ti.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop() Message-ID: <20240208104700.GF1435458@kernel.org> References: <20240206152052.98217-1-diogo.ivo@siemens.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240206152052.98217-1-diogo.ivo@siemens.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_024706_619113_C42B9C8B X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 06, 2024 at 03:20:51PM +0000, Diogo Ivo wrote: > Remove the duplicate calls to prueth_emac_stop() and > prueth_cleanup_tx_chns() in emac_ndo_stop(). > > Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver") > Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support") > Signed-off-by: Diogo Ivo Hi Doigo, I see that there are indeed duplicate calls, but I do wonder if this is a cleanup rather than a bug: is there a user-visible problem that this addresses? If so, I think it would be good to spell this out in the commit message. ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel