From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21CDEC4828F for ; Thu, 8 Feb 2024 12:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VICua6x/DG2PKZEVaWvvm9lOE9VnWVJHJ83dICvJOEI=; b=MOQwpkAlwfAayd Er2sN5eT/bu1YSZv8KCmaIFgM+fol2s83D0VfJkjGaqw4Oh5ZuaZPlA232U2XoaDmZWzb2oDFOdBy RJoP3OJ1dClt1iG6vfbu2b4+u+kv2D9IQTP93SAnHEfY+3my9LhTHQoAwEMNSopS+yUtlGDGKssSg k/i7ENDFHxVY2UsZr6Np0AnfffmtxxAasgqyrDPG78/5ouhPPkEAtDtCGiR1ARAplDEL6rT+Zajlf JIxvZxxEqUqotn/okIdGi4MVdlT/cChsMng3pTh4T03iDXKlsGvj7EO4zGLk/6PYpVcIjtwMygB8K rUH5s6wAYjYh7VK/UHpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY3OR-0000000Dhc0-29x4; Thu, 08 Feb 2024 12:20:39 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY3OO-0000000Dha6-1fUY for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 12:20:37 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TVww84svfz6K98Q; Thu, 8 Feb 2024 20:17:12 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 9EA0A140136; Thu, 8 Feb 2024 20:20:30 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 8 Feb 2024 12:20:30 +0000 Date: Thu, 8 Feb 2024 12:20:29 +0000 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , , Subject: Re: [PATCH 3/7] drivers/perf: hisi_pcie: Add more events for counting TLP bandwidth Message-ID: <20240208122029.000005e1@Huawei.com> In-Reply-To: <20240204074527.47110-4-yangyicong@huawei.com> References: <20240204074527.47110-1-yangyicong@huawei.com> <20240204074527.47110-4-yangyicong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_042036_627361_77A05215 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 4 Feb 2024 15:45:23 +0800 Yicong Yang wrote: > From: Yicong Yang > > A typical PCIe transaction is consisted of various TLP packets in both > direction. For counting bandwidth only memory read events are exported > currently. Add memory write and completion counting events of both > direction to complementation. complementation? > > Signed-off-by: Yicong Yang Reviewed-by: Jonathan Cameron > --- > drivers/perf/hisilicon/hisi_pcie_pmu.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c > index 9623bed93876..83be3390686c 100644 > --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c > +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c > @@ -726,10 +726,18 @@ static struct attribute *hisi_pcie_pmu_events_attr[] = { > HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_cnt, 0x10210), > HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_latency, 0x0011), > HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_cnt, 0x10011), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mwr_flux, 0x0104), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mwr_time, 0x10104), > HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x0804), > HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x10804), > + HISI_PCIE_PMU_EVENT_ATTR(rx_cpl_flux, 0x2004), > + HISI_PCIE_PMU_EVENT_ATTR(rx_cpl_time, 0x12004), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mwr_flux, 0x0105), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mwr_time, 0x10105), > HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x0405), > HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x10405), > + HISI_PCIE_PMU_EVENT_ATTR(tx_cpl_flux, 0x1005), > + HISI_PCIE_PMU_EVENT_ATTR(tx_cpl_time, 0x11005), > NULL > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel