From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D774C4828F for ; Thu, 8 Feb 2024 15:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4j4MqQ3akRPV8H4Nn9knD+GA3YzNB178aqPoO8/vz8g=; b=CpczEE0wzu1vtU hWGAO+aaE+wnNoYkTTD5p1owBTkRgS99fYufHHG/aCkxbFZjr4TDqEIbGKtdYMMHv0ATo+ii5XuB2 rokm6j4Kv+xTLG05X0f4zG5HLvWKAHEX2o6x9Arvrpa+UfGfzz2kGsuhUgzeuChR0+OyYK490RxcW KTyX5aqgVuvdd3nESU1lIPEA3DfZxAZAhqdQBmXxPSwZ15ESNkMogZjO8RY/3IEl9GzNQ+JUv7UcJ SL2EG2MLKdCMylNq1rATEj9fwBqHh8k5qOtnCN5bDP+gYItB1vteBPfzUxPEODuVVqnzFglkaCvGc jslTqpMFOndgUjMlpa6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY6Z4-0000000ECPa-0iyT; Thu, 08 Feb 2024 15:43:50 +0000 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY6Z0-0000000ECPC-3lgr for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 15:43:48 +0000 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6e2c680f91aso101590a34.3 for ; Thu, 08 Feb 2024 07:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1707407024; x=1708011824; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=42fCYQTEim9hrnMCqp+EazxamRSYzlJTG+y6cKqWJb4=; b=bVC0i2mVMzGyXIYdR4J9rcuiyg5k0P6lUd5/C7/Y113cq1JfSvHZgk/2iQuLGNCe7u b5uovowN2yaehOCc93ZinURRWzyr732vhzWJi/BC0gZ+9BYwjq4WeI5PsGA5cK+kq3AJ zqEzmdJASGuOw39MqFki6sb4MAkWuPMm7+NhxG+wEqSwyyo9ojvk5fyxn3SndT++GbyY WdoIQi3dAniGjdzxZ0x/U2denzQtqHiuJJZUAGCfr09mB9mTfOV3XFuZAYbAuP7g9dW3 BsjH948h9lPqYMrnGO9GE7QLQ5pBVSfFsRpsPB+qYcjqW5Pa9J+3T0uw9ICqZ+HaHHx/ 3e3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707407024; x=1708011824; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=42fCYQTEim9hrnMCqp+EazxamRSYzlJTG+y6cKqWJb4=; b=S8+SvyXF3myqZzjqtyPeD8RyMkWAaNh6W+hgiNnC3xHh4hf6XOvkGMAuNFjzs14LcB jsT5cnamNanLdQgfmvg7Rx5nEM8Em+PvNk4mNZSBOXk2Lr8RMLQaLFG36hRVE5ys83hd jUFte5xFv/Zr/lmnvog+e5hzKRLuZLAcrTpelhhEtmra2/uAXz8b0alMdk+OSqYnPzyr 8ZtwtZQQ94P0nbEWGY6ZD2PONl0Ob3Fh3x35ynXpboQl4cgyfj9k5Fa1i8NWLuDHV8f7 8p/pp8zE+Fua6unLgyj60dTS1zoHlqNt8AMapoJ+4hb7KKUjiVh2c1NaA9oq1zCVybO8 NsjA== X-Forwarded-Encrypted: i=1; AJvYcCUyQw3Np8PvdeFHtKgkmsngjN8MiD3iR2nCvg4TK8PAv+xTgaL9Jlm+Kl65jUb+jgq/bsN+wUzvc7Dm3UTE6TTNaJ4ULod5LKoovt2BkXRg354vOi8= X-Gm-Message-State: AOJu0YxtOeZxPZiyag5i3B5ptVly9d5SxzVeLvq4oUIH3bDqDSqyCQmX SEeZgp6/Zy/b++wrreM1T3ZfP1RovPkRmYjvl9+MfuVftwMXfpzOJfhhZX9sw3Erok7AAYQKo6Y 7 X-Google-Smtp-Source: AGHT+IF3FjBMczgGjBzvG8YNkJEYtMzlNp4gkaCQSwrhLDd62dAkSovFu4zT3VE8jqZVndY/ZXxDlg== X-Received: by 2002:a9d:7692:0:b0:6e0:e52b:ccad with SMTP id j18-20020a9d7692000000b006e0e52bccadmr9448106otl.16.1707407024266; Thu, 08 Feb 2024 07:43:44 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUy9Rv8dR6osIwGKkh+Uw//I7/9AqSZbUIwaLPMCn1d0CFcvfsy0etmKamm1kX8HW4VknXjc4+1VHqUIDKYJhOaB6R0yPlYfF4M+Felb0fJ3ckSJQTJ3Svem8lh8Zc8cE935goYrk2tQ4WSYvqMdaYxqmHFVhj7ZRNV0U9an+3dTmKTL8XL++yZLJAiHR54Ssc9vBo0CkM3S2qMDziNKb1hHHKiH1dQExWOI/ZBBcjo8WU5u4cDzlIqcZPcTM20173tMAeBhhk1q0vw3aFVFAFEILFJS366poCgMec+ieKMXqzDpeCZM82X62ASA53goyBMVQiplsOqH7at0Gf0Tq+ffSekhbgTmwKlPMsrMb38AxBgTUMxB+1JkHf78dzLEsaXEjUx6aX9gB/XG/2qG6QjT6ehjmp0mGE= Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id n6-20020a9d64c6000000b006dc5edf4de7sm583267otl.32.2024.02.08.07.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 07:43:43 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rY6Yx-00Eu84-2G; Thu, 08 Feb 2024 11:43:43 -0400 Date: Thu, 8 Feb 2024 11:43:43 -0400 From: Jason Gunthorpe To: Shameer Kolothum Cc: kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, kevin.tian@intel.com, alex.williamson@redhat.com, maz@kernel.org, oliver.upton@linux.dev, will@kernel.org, robin.murphy@arm.com, jean-philippe@linaro.org, jonathan.cameron@huawei.com Subject: Re: [RFC PATCH v2 5/7] iommu: Pass in kvm pointer to domain_alloc_user Message-ID: <20240208154343.GQ31743@ziepe.ca> References: <20240208151837.35068-1-shameerali.kolothum.thodi@huawei.com> <20240208151837.35068-6-shameerali.kolothum.thodi@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240208151837.35068-6-shameerali.kolothum.thodi@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_074346_959732_99819412 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 08, 2024 at 03:18:35PM +0000, Shameer Kolothum wrote: > diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c > index 4283dd8191f0..75e0f4e9253a 100644 > --- a/drivers/iommu/amd/iommu.c > +++ b/drivers/iommu/amd/iommu.c > @@ -2244,6 +2244,7 @@ static struct iommu_domain *amd_iommu_domain_alloc(unsigned int type) > static struct iommu_domain * > amd_iommu_domain_alloc_user(struct device *dev, u32 flags, > struct iommu_domain *parent, > + struct kvm *kvm, > const struct iommu_user_data *user_data) It would also be fine to stick this in iommu_user_data - since it is fully optional to any driver. The other parameters are things the drivers must check and do something with. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel