From: Francesco Dolcini <francesco@dolcini.it>
To: Udit Kumar <u-kumar1@ti.com>
Cc: nm@ti.com, kristo@kernel.org, ssantosh@kernel.org,
chandru@ti.com, rishabh@ti.com, kamlesh@ti.com, vigneshr@ti.com,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3] clk: keystone: sci-clk: Adding support for non contiguous clocks
Date: Sun, 11 Feb 2024 16:54:59 +0100 [thread overview]
Message-ID: <20240211155459.GA4443@francesco-nb> (raw)
In-Reply-To: <20240207091100.4001428-1-u-kumar1@ti.com>
On Wed, Feb 07, 2024 at 02:41:00PM +0530, Udit Kumar wrote:
> Most of clocks and their parents are defined in contiguous range,
> But in few cases, there is gap in clock numbers[0].
> Driver assumes clocks to be in contiguous range, and add their clock
> ids incrementally.
>
> New firmware started returning error while calling get_freq and is_on
> API for non-available clock ids.
>
> In this fix, driver checks and adds only valid clock ids.
>
> Fixes: 3c13933c6033 ("clk: keystone: sci-clk: add support for dynamically probing clocks")
>
> [0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html
> Section Clocks for NAVSS0_CPTS_0 Device,
> clock id 12-15 not present.
>
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
no empty lines in between tags and only tags at the end of the commit
message, this [0] reference needs to be before or moved to a `Link:` tag,
whatever works best for you.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-11 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 9:11 [PATCH v3] clk: keystone: sci-clk: Adding support for non contiguous clocks Udit Kumar
2024-02-07 9:53 ` Kamlesh Gurudasani
2024-02-07 12:54 ` Nishanth Menon
2024-02-07 13:45 ` Kamlesh Gurudasani
2024-02-07 14:23 ` Kumar, Udit
2024-02-09 17:25 ` Nishanth Menon
2024-02-09 18:55 ` Kamlesh Gurudasani
2024-02-09 19:02 ` Nishanth Menon
2024-02-09 20:01 ` Kamlesh Gurudasani
2024-02-11 15:54 ` Francesco Dolcini [this message]
2024-02-12 4:36 ` Kumar, Udit
2024-02-12 7:58 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240211155459.GA4443@francesco-nb \
--to=francesco@dolcini.it \
--cc=chandru@ti.com \
--cc=kamlesh@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=rishabh@ti.com \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).