From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52638C4829A for ; Sun, 11 Feb 2024 15:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cMbE4s9TlZmzX3yTN9jFWFW0st+WdDxzFu6qFnhZgso=; b=qgKLYP1r6EZ/AK ic0OdQihGNwtnqgAp5Jl0VuvBw6hbsjqdYbcGhNZEmOJnSLEUu8vFAmwkws2lxqzlG6xNkyvLsylf YRc3K2jKMRPYwgs2474DE+VFTY0nLZA7jcjXw2l5Ro3ZW7t9US1ek9v1oVXezDyXGU1WpkmsGOTXa qcPWNkbfsWXIGTPVnesamQJph+nMHSPlVqDHvT5u2gBn4W2AqBgLTA4YUePLWF2n5sWmY0wAR0SER nnyJKIUjjwHhyuSTvdGKaOfE+L/JJwCASM5pE4hdYMTtyWR1PWwUYhaMGOFKr0JkI/dJQ65Ga9k1K /uKqtQRuLdl0B06VIFlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZCAe-00000002xwa-0bam; Sun, 11 Feb 2024 15:55:08 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZCAb-00000002xw9-2XyL for linux-arm-kernel@lists.infradead.org; Sun, 11 Feb 2024 15:55:07 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id A0D5820751; Sun, 11 Feb 2024 16:55:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1707666904; bh=8M/NTInG6Nop42RnQgfHsyNKhHaJCOtRgNV478Trz5s=; h=From:To:Subject; b=cnVsoZYHZj3wakEHaE3KqHdWFZRhHvPtr03SyIlO4jn5FP8usu86QomBnG5UgPCWS cBe7+Qje074Ri72ZEtjZhQIQCzKKsEVCLfsQQRJpHibC8pj5q+y1kpbqSuFQ5rG3G4 iXY/DYLzq/WlN8XIKYPLqVPR7itfjstv+NPE0qgK39OK9YGRGfh7x9NL0zShJQXQew XTG5Mq2EdM/yjJN+EIJX0zao7ZrjyvMuWMV+BD706waEG1jIcMzYvOj9dqnqC6bu4B IdHBl//d3NzIYTnl93VSm+4w93+yCEoaVq5J/7tlbeFIE+KcWtElMpJlEVPdTCMBdn 2r5vcZmNZXPMQ== Date: Sun, 11 Feb 2024 16:54:59 +0100 From: Francesco Dolcini To: Udit Kumar Cc: nm@ti.com, kristo@kernel.org, ssantosh@kernel.org, chandru@ti.com, rishabh@ti.com, kamlesh@ti.com, vigneshr@ti.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v3] clk: keystone: sci-clk: Adding support for non contiguous clocks Message-ID: <20240211155459.GA4443@francesco-nb> References: <20240207091100.4001428-1-u-kumar1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240207091100.4001428-1-u-kumar1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240211_075505_830035_241D5BA7 X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 07, 2024 at 02:41:00PM +0530, Udit Kumar wrote: > Most of clocks and their parents are defined in contiguous range, > But in few cases, there is gap in clock numbers[0]. > Driver assumes clocks to be in contiguous range, and add their clock > ids incrementally. > > New firmware started returning error while calling get_freq and is_on > API for non-available clock ids. > > In this fix, driver checks and adds only valid clock ids. > > Fixes: 3c13933c6033 ("clk: keystone: sci-clk: add support for dynamically probing clocks") > > [0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html > Section Clocks for NAVSS0_CPTS_0 Device, > clock id 12-15 not present. > > Signed-off-by: Udit Kumar no empty lines in between tags and only tags at the end of the commit message, this [0] reference needs to be before or moved to a `Link:` tag, whatever works best for you. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel