From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAADFC48297 for ; Mon, 12 Feb 2024 03:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xx5xtkD+tE8XI4zy7rf+M1zfRNHbluFDRad3EibNAjk=; b=pW+W7KoefJP3hn GYYeg0H61CUrg/E//M77E7gfbWDEque0y9f9vX1ZTLJ6taYq+bnL2jZ3W25obmHOpUfdQToNinN7F NZ65bVIf3wvNW9LQBuaJRh1IS5l1wBwJ1iXwY4zhCA/z95KOwlSjdvYgHoMs5BVUvaYgEGqp8V+Ui Gk5Mo1N4pUWdSqkQZ2msFE1qVxRZtp0Eygr0epg48Ty1IaUYEJd4tzii6Np2RpHUKI6JT5z1q6S+l WfFXgwDmkDqW+26CtSZzlW/1XVk6PHeTfQuKQQ4xNDJLnsrJsZTUdOAmhfMeUw20F7d8S+Q2uakoc c6XPEaQUEfcGYEc8+uKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZNFr-00000004GjV-25kP; Mon, 12 Feb 2024 03:45:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZJsR-00000003dOp-2oaL for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 00:08:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B651DA7; Sun, 11 Feb 2024 16:09:29 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DA6B3F5A1; Sun, 11 Feb 2024 16:08:45 -0800 (PST) Date: Mon, 12 Feb 2024 00:07:27 +0000 From: Andre Przywara To: Andrey Skvortsov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris , Alexey Klimov , Daniel Lezcano Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add thermal trip points for GPU Message-ID: <20240212000727.4690bdb6@minigeek.lan> In-Reply-To: References: <20240211105326.506049-1-andrej.skvortzov@gmail.com> <20240211125209.15d58462@minigeek.lan> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240211_160852_581720_718E09AE X-CRM114-Status: GOOD ( 35.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 11 Feb 2024 17:24:19 +0300 Andrey Skvortsov wrote: Hi Andrey, > Hi Andre, > > On 24-02-11 12:52, Andre Przywara wrote: > > On Sun, 11 Feb 2024 13:53:26 +0300 > > Andrey Skvortsov wrote: > > > > Hi Andrey, > > > > > From: Alexey Klimov > > > > > > Without trip points for GPU, the following errors are printed in the > > > dmesg log and the sun8i-thermal driver fails to load: > > > > So how does that post differ from Alexey one's a few weeks back: > > https://lore.kernel.org/linux-arm-kernel/20240101000008.65747-1-alexey.klimov@linaro.org/ > > It seems like the same patch? > > Yes, it's the same patch. I've added only information about failed > dtbs_check errors in already supported boards to commit message. > I've found this patch from June 2023 without any feedback. [1] Since I've > worked on dts changes for PinePhone A64, I've decided to resend > it. Sorry, I wasn't aware that Alexey resent it in the mean time. No worries, that's fine, thanks for the explanation. > It's better to continue discussion in original Alexey's patch. Will Alexey have time to reply and resend? If not, or if you are not sure (it's been a while), it's fine to take over this series, and send a v2, by yourself. If you can just explicitly state that the GPU trip point values are copied from the CPU ones (because they share a die), I am happy as far as my comment is concerned. This is arguably somewhat mentioned in the commit message already, but I missed it on the first read, so would like to see this more prominently stated. As mentioned before, and also stated by Jernej, consider this patch purely device-specific, not related to any Linux behaviour, and give rationale only based on the binding, which requires trip points. Something simple as "The DT binding requires trip points, and dt-validate complains about them missing for any A64 boards." should suffice. Thanks, Andre > > And Jernej and I had some comments (no mentioning of "Linux" in commit > > message, add cooling maps, source of trip temperature values), can you > > please try to address them? > > > > > > > thermal_sys: Failed to find 'trips' node > > > thermal_sys: Failed to find trip points for thermal-sensor id=1 > > > sun8i-thermal: probe of 1c25000.thermal-sensor failed with error -22 > > > > I think it's pretty obvious that the trip points are missing when they > > shouldn't, so this does not need too much explanation or rationale in > > the commit message, so you can cut this short. > > > > > When thermal zones are defined, trip points definitions are mandatory. > > > Trip values for the GPU are assumed to be the same values as the CPU > > > ones. The available specs do not provide any hints about thermal regimes > > > for the GPU and it seems GPU is implemented on the same die as the CPU. > > > > > > 'make dtbs_check' complains about problem in dts for 18 A64-based boards > > > supported by the kernel: > > > > > > sun50i-a64-pine64.dtb: thermal-zones: gpu0-thermal: 'trips' is a required property > > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# > > > sun50i-a64-pine64.dtb: thermal-zones: gpu1-thermal: 'trips' is a required property > > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# > > > > > > Tested on Pine a64+ and PinePhone 1.2. > > > > > > Cc: Samuel Holland > > > Cc: Jernej Skrabec > > > Cc: Chen-Yu Tsai > > > Cc: Daniel Lezcano > > > Cc: devicetree@vger.kernel.org > > > Signed-off-by: Alexey Klimov > > > Tested-by: Andrey Skvortsov > > > > You would need your Signed-off-by: here, since you send this, even when > > on Alexey's behalf. > > > > Cheers, > > Andre > > > > 1. https://lkml.org/lkml/2023/6/4/416 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel