From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7EAFC4829B for ; Mon, 12 Feb 2024 15:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cNymZ6s1i0d8sPJdx9FF14eP97+2/EieFMZyv+6RLVk=; b=Ce6K6/L5SkwTqf AKd8wzcPES0/kG+GcfDGRwGsauJwmg1NnwHTwwMCGsXg+ivMycO/ggVc+8lwC97OgE7pengY9hsfV SJTx7+XM5mq+8K5Lr7yhU41aOX4ZrTNq+U2191Cxnx+xBhiTDayHPpBFiFN4CQgpeg5F2hpDOfHce cH5h+lgcQW4IwER3U1mSLiat5R7wNO8G9kfPpTgHOeGXd1SzeAbiG8KHQsjbNamzCkLAieJbN4uZo BXX7jqFbygAqlYLQWf/pqbRKzj949vvLqrlmgqXj4UTKKL0gsLxChYdkgpnttkKbN9xDxqD99QlVR 8qObVudyxFrjNlZxKMUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZXyo-00000005uwO-2xbh; Mon, 12 Feb 2024 15:12:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZXyl-00000005uvp-3oI3 for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 15:12:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D7AB360B54; Mon, 12 Feb 2024 15:12:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7ABDC433C7; Mon, 12 Feb 2024 15:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707750738; bh=kkseZIm6ZlPIBsB/X53FwjKVu7CXE4Epox0B+g9MJeg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bMTUa2QCLsbGNLWbUPbgaTt9otlhqe1tgjkWfCtjSgAvdn2wJNCrGyQsd5n9scCLw 5Fz4N5jfe4zD520UhntjBsU5glOd4SG0eAnR77tgdKNaVuJiXXSc5daTKQV+qcXaS6 iqKts6KvMuZhqG/VhNKOCdce5rZFzBq7j98L43f8TMfWKL5/C8Kom+3SJtj4RjqL4F 78/+KFJg3kVxwdnAdlf/+FSYuI2vJYCvjGPwXUJZ6OmzNMdYxDIvwULQ2y+kdIKLH3 f2q7MBT+mgjqnOh+uNFkUv+1nLo94sacS9jB4ynSJ6+s6M022SNsm0hn9tZsGMRBO9 sJaq3VRN93+Yw== Date: Mon, 12 Feb 2024 07:12:16 -0800 From: Jakub Kicinski To: Kurt Kanzenbach Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Yannick Vignon , Sebastian Andrzej Siewior , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: stmmac: Simplify mtl IRQ status checking Message-ID: <20240212071216.21e36c5c@kernel.org> In-Reply-To: <87il2t98ri.fsf@kurt.kurt.home> References: <20240208-stmmac_irq-v1-1-8bab236026d4@linutronix.de> <87il2t98ri.fsf@kurt.kurt.home> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_071220_023140_4D9D8734 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Feb 2024 13:17:37 +0100 Kurt Kanzenbach wrote: > On Thu Feb 08 2024, Kurt Kanzenbach wrote: > > Commit 8a7cb245cf28 ("net: stmmac: Do not enable RX FIFO overflow > > interrupts") disabled the RX FIFO overflow interrupts. However, it left the > > status variable around, but never checks it. > > > > As stmmac_host_mtl_irq_status() returns only 0 now, the code can be > > simplified. > > > > Signed-off-by: Kurt Kanzenbach > > why did this got marked as Changes Requested. What changes have to be > made? Sorry, restored! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel