From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1294C48297 for ; Mon, 12 Feb 2024 13:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nlYqo/zgBnPdWqYiGM7+9ywdKBVY9j7NzLyrpXTKGyM=; b=0cXfBKPcJwi+HT QKmWS7uNflgjcexYeL+LSi4hqEqRF6O3ZD3qmJsJIiDWrrR11CoBHGlcWnb1hQirRWyBzhuTXaVLu dw9Pmm6fNEs/A6QPqjmDXFTbGdy6NYqGKcQcYIHkgVifiYaj4WC0rLcnricDQ6v5WyUplKlRvCt7Z PZDJMzH7kiM1pSfuJbz0xgifUkVoIx0XW9HIZYqL660DzZREcCZXlpmHRLTbQickXotqqvso/3iMv noE2X3vBUBysb2xSiJnqGEWfGiGiP63kcHnzZOKSydHxVkRGfUvmkl30zwZe2jVC6px5k+ZXPg1Wv Uz1NxeHSwlb8FUaxNNYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZWCP-00000005SIQ-4AYg; Mon, 12 Feb 2024 13:18:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZWAl-00000005QvS-1a6q for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 13:16:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 550DA60FAA; Mon, 12 Feb 2024 13:16:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE4D6C433C7; Mon, 12 Feb 2024 13:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707743794; bh=9sevq/yqb1NYFYOfIyOHJePYkgdalV/0E1nKUcbcKNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YBQqvgd8VpHznL+2fPx1BpJzFkdBIj+hfBKMURUlx4Z+sCT3dE9pI+lR3o8sdRVJG p+D5J1WaYWTFQDs2QJXQPx9aZnFO89wgHY/ouZlRqC5hUnR+PFwKNi292GrE6S97d3 euxsGhWTecaAeQ5MK1A8v56g4a1VT8zgUJWWSTFeustlByzP4NcYIJCLZFATGU8g74 lt2+P+kXZz+E7Ayk/tTCBiZt6M33n/ecVTYrVQHwwqLt/DqC5g/lIAVM58SHTTdVj3 epfb/TKkslN0bqdi4JsxDSRCtQpo7npzpbcEKBZ0Bdg34yNqNweKkNq/O1S2ovqtBG LqJV0tJs8rUzg== Date: Mon, 12 Feb 2024 07:16:31 -0600 From: Rob Herring To: Sebastian Reichel Cc: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Dong Aisheng , Linus Walleij , Dmitry Torokhov , Mark Brown , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 02/14] dt-bindings: bus: imx-weim: convert to YAML Message-ID: <20240212131631.GA13910-robh@kernel.org> References: <20240210012114.489102-1-sre@kernel.org> <20240210012114.489102-3-sre@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240210012114.489102-3-sre@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_051635_751426_CD719EDA X-CRM114-Status: GOOD ( 24.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 10, 2024 at 02:18:06AM +0100, Sebastian Reichel wrote: > Convert the i.MX Wireless External Interface Module binding to YAML. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/bus/fsl,imx-weim.yaml | 225 ++++++++++++++++++ > .../devicetree/bindings/bus/imx-weim.txt | 117 --------- > 2 files changed, 225 insertions(+), 117 deletions(-) > create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml > delete mode 100644 Documentation/devicetree/bindings/bus/imx-weim.txt > > diff --git a/Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml b/Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml > new file mode 100644 > index 000000000000..3d27bdaef304 > --- /dev/null > +++ b/Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml > @@ -0,0 +1,225 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bus/fsl,imx-weim.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX Wireless External Interface Module (WEIM) > + > +maintainers: > + - Shawn Guo > + - Sascha Hauer > + > +description: > + The term "wireless" does not imply that the WEIM is literally an interface > + without wires. It simply means that this module was originally designed for > + wireless and mobile applications that use low-power technology. The actual > + devices are instantiated from the child nodes of a WEIM node. > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx1-weim > + - fsl,imx27-weim > + - fsl,imx50-weim > + - fsl,imx51-weim > + - fsl,imx6q-weim > + - items: > + - enum: > + - fsl,imx31-weim > + - fsl,imx35-weim > + - const: fsl,imx27-weim > + - items: > + - enum: > + - fsl,imx6sx-weim > + - fsl,imx6ul-weim > + - const: fsl,imx6q-weim > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 1 > + > + ranges: true > + > + fsl,weim-cs-gpr: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + Phandle to the system General Purpose Register controller that contains > + WEIM CS GPR register, e.g. IOMUXC_GPR1 on i.MX6Q. IOMUXC_GPR1[11:0] > + should be set up as one of the following 4 possible values depending on > + the CS space configuration. > + > + IOMUXC_GPR1[11:0] CS0 CS1 CS2 CS3 > + --------------------------------------------- > + 05 128M 0M 0M 0M > + 033 64M 64M 0M 0M > + 0113 64M 32M 32M 0M > + 01111 32M 32M 32M 32M > + > + In case that the property is absent, the reset value or what bootloader > + sets up in IOMUXC_GPR1[11:0] will be used. > + > + fsl,burst-clk-enable: > + type: boolean > + description: > + The presence of this property indicates that the weim bus should operate > + in Burst Clock Mode. > + > + fsl,continuous-burst-clk: > + type: boolean > + description: > + Make Burst Clock to output continuous clock. Without this option Burst > + Clock will output clock only when necessary. > + > +patternProperties: > + "^.*@[0-7],[0-9a-f]+$": > + description: Devices attached to chip selects are represented as subnodes. > + type: object > + additionalProperties: true > + properties: > + fsl,weim-cs-timing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + Timing values for the child node. > + required: > + - fsl,weim-cs-timing This needs to go in its own schema doc and then added to memory-controllers/mc-peripheral-props.yaml We should probably also move this binding to memory-controllers/ > + > +allOf: > + - if: > + properties: > + compatible: > + not: > + contains: > + enum: > + - fsl,imx50-weim > + - fsl,imx6q-weim > + then: > + properties: > + fsl,weim-cs-gpr: false > + fsl,burst-clk-enable: false > + - if: > + properties: > + fsl,burst-clk-enable: false > + then: > + properties: > + fsl,continuous-burst-clk: false > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx1-weim > + then: > + patternProperties: > + "^.*@[0-7],[0-9a-f]+$": > + properties: > + fsl,weim-cs-timing: > + items: > + items: > + - description: CSxU > + - description: CSxL > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx27-weim > + - fsl,imx31-weim > + - fsl,imx35-weim > + then: > + patternProperties: > + "^.*@[0-7],[0-9a-f]+$": > + properties: > + fsl,weim-cs-timing: > + items: > + items: > + - description: CSCRxU > + - description: CSCRxL > + - description: CSCRxA > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx50-weim > + - fsl,imx51-weim > + - fsl,imx6q-weim > + - fsl,imx6sx-weim > + - fsl,imx6ul-weim > + then: > + patternProperties: > + "^.*@[0-7],[0-9a-f]+$": > + properties: > + fsl,weim-cs-timing: > + items: > + items: > + - description: CSxGCR1 > + - description: CSxGCR2 > + - description: CSxRCR1 > + - description: CSxRCR2 > + - description: CSxWCR1 > + - description: CSxWCR2 > + > +required: > + - compatible > + - reg > + - clocks > + - '#address-cells' > + - '#size-cells' > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + weim@21b8000 { bus or external-bus > + compatible = "fsl,imx6q-weim"; > + reg = <0x021b8000 0x4000>; > + clocks = <&clks 196>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0x08000000 0x08000000>; > + fsl,weim-cs-gpr = <&gpr>; > + > + nor@0,0 { > + compatible = "cfi-flash"; > + reg = <0 0 0x02000000>; > + #address-cells = <1>; > + #size-cells = <1>; > + bank-width = <2>; > + fsl,weim-cs-timing = <0x00620081 0x00000001 0x1c022000 > + 0x0000c000 0x1404a38e 0x00000000>; > + }; > + }; > + - | > + weim@21b8000 { > + compatible = "fsl,imx6q-weim"; > + reg = <0x021b8000 0x4000>; > + clocks = <&clks 196>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0x08000000 0x02000000 > + 1 0 0x0a000000 0x02000000 > + 2 0 0x0c000000 0x02000000 > + 3 0 0x0e000000 0x02000000>; > + fsl,weim-cs-gpr = <&gpr>; > + > + acme@0,0 { > + compatible = "acme,whatever"; Real bindings only please. > + reg = <0 0 0x100>, <0 0x400000 0x800>, > + <1 0x400000 0x800>; > + fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100 > + 0x00000000 0xa0000240 0x00000000>; > + }; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel