From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C36DDC4829E for ; Tue, 13 Feb 2024 01:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sxWtUQqRMFuYwhVWWcLZB9zNzyZS9ul06meNxL/Bv+Q=; b=KBVOCytC5iGTJn kVMvbVkW4+IaJc4TdZD/fRsLwjvo2ZedIQ3q3TVHKBUUwO9gi2dw8jC5oUQlLmpS2h2LIAc9Lj0he oVMTbFW12slf9i4DgFlOeaHyRfIbK71OwpzmyLptAwHWYSUFScIpOMKKp68veaqyN4KyeoSER7G9I JyxRsos3qjTDDEYPBE7YncvMZof0Ep3+NsSChNFwoX54jZT5VzV4/JypQmdyVJooSEgu0lLEbr6VQ pSNhsP6w/l2ClmDjqDCyC24fyQs3cjRcX7WYZ7yzSelfK4HxwyjksYZ/zWzGU04fqtvMNfoilxDyY 9BoTWhzll/7H6DNnxCyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZhcs-00000007egd-1QIn; Tue, 13 Feb 2024 01:30:22 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZhcp-00000007efP-2T6o for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 01:30:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CBEC9CE18C3; Tue, 13 Feb 2024 01:30:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 808CDC433C7; Tue, 13 Feb 2024 01:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707787817; bh=JdTHedcxVO15s3B4sRid8zTpEzYkN8lo7pBe02dMOIA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f7FzUXFTQaQH8sST/82MCPpBjozyaFswVdXgob1DuM96d49GvcQ8wdCMwWZLzkxgb UJgmMIkE6HmuBTiwWJJ6jbHzUIBgH/uaV2/oVNOH4xgI1gpyjHC1FKtodkkM88NPb5 LyLBx4QyM/e4GbXQ9l/97+7UnUSKW79+3X60suDirIZ49zHBqCVf9kc5JZJbMEEuBU lj1FTyIPXxlSxynmRWq9W8yZkHNr8N0DDAMX7DKO/qDNJnO27yCwoSnhWfXInum8fD dpSzPJHVFS8eWxVFGFi/KxHI9rP3OGCCxyjAQig1Jl5af3KmOGPZSpKo/QKejms+s5 N9fniz4acy2nQ== Date: Mon, 12 Feb 2024 17:30:15 -0800 From: Jakub Kicinski To: Sneh Shah Cc: Vinod Koul , Bhupesh Sharma , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Andrew Halaney Subject: Re: [PATCH net-next v4] net: stmmac: dwmac-qcom-ethqos: Add support for 2.5G SGMII Message-ID: <20240212173015.0341f0ee@kernel.org> In-Reply-To: <20240208111714.11456-1-quic_snehshah@quicinc.com> References: <20240208111714.11456-1-quic_snehshah@quicinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_173019_836830_5BFDB3E0 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 8 Feb 2024 16:47:14 +0530 Sneh Shah wrote: > Serdes phy needs to operate at 2500 mode for 2.5G speed and 1000 > mode for 1G/100M/10M speed. > Added changes to configure serdes phy and mac based on link speed. > Changing serdes phy speed involves multiple register writes for > serdes block. To avoid redundant write operations only update serdes > phy when new speed is different. Sounds like 2 separate changes in one patch, please split the optimization of not writing the registers multiple times and the 2.5G support. > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 31631e3f89d0..6bbdbb7bef44 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -106,6 +106,7 @@ struct qcom_ethqos { > struct clk *link_clk; > struct phy *serdes_phy; > unsigned int speed; > + int serdes_speed; Why signed if speed itself is unsigned? > /* Enable and restart the Auto-Negotiation */ > if (ane) > value |= GMAC_AN_CTRL_ANE | GMAC_AN_CTRL_RAN; > + else > + value &= ~GMAC_AN_CTRL_ANE; That looks unrelated. Either a separate patch or please explain in the commit msg why. -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel