From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 959DCC4829A for ; Tue, 13 Feb 2024 11:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HCXDxyQKGTTkb7wFJGIxx3qcZzz/ZX8IWJokhgoqGPE=; b=gzVamI0PWNcw8+ LGv1DOxJYMosUQmV0ScZ+LZvEk6CyfrB2X5n5pz799p1do0XRf6pN3DJY9Jhr5Klqb611iBbDoDqn C2UGkiQQcmY8X+ohb5Neqsc4d+I1t9ddnMheRVBUbzFWVsDn0XX76uxOpiWwxw64Qiw9AtiwlRaZB v4xLT+gQvBEaHaFLP2C9Spt24EPTYM29WRS3SaUd9yUNBUJ7s27wN36xgdFae6owVhwu9ENFbH54h 5Obf5gFTZnKb0jFPUC7GlfgyCmh4xMPoYcQV5fSnndXwgVjGN1Kvqf9F3LXnxJA2cVvDMEzUVUyHb x6Q0HbSABwpWTstOnsPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZqm9-00000008yUw-3m0t; Tue, 13 Feb 2024 11:16:33 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZqm7-00000008ySc-0DD5 for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 11:16:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5BBCBCE1A90; Tue, 13 Feb 2024 11:16:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EE6FC433C7; Tue, 13 Feb 2024 11:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707822988; bh=5OBFEb/Yhbyz47XlEWUtNwEBCHbFaYgeQmRlDSCCss8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tTsJUqBcIu23GtL5cSHYE+YLbKXgOJW4YdIMDkg+KwE59sEphYtG4q3tsFOQVMWgS joLbfUnRTGHpV9qwmzGhIA3Pqrmn+5PEGwt5mL/BF52UdhdYNjgcIqTHddC3X1dTPw G68NS8So2d6yGqK0MKh8LAcIDk3mlbiJlKI6oQWe8sMh/4c/sy9qfOgbdlbOECvW/f Sv/H0AYQuWvmfigWhsqY8YjJpj7pSDCxReQzINJHucifwPaV7ibVDGTBx74d7AHp7n zRMUPQYf6fbj/fSn1PR8FuqFTnj4B6Q77DPsci9821wpsFYJtQYspEYW5bWrfx+ndY QalhvNEZFXHMQ== Date: Tue, 13 Feb 2024 11:16:23 +0000 From: Will Deacon To: Dmitry Baryshkov Cc: Robin Murphy , Jason Gunthorpe , iommu@lists.linux.dev, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, nicolinc@nvidia.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 5/5] iommu/arm-smmu: Convert to domain_alloc_paging() Message-ID: <20240213111623.GA28517@willie-the-truck> References: <5-v2-c86cc8c2230e+160bb-smmu_newapi_jgg@nvidia.com> <20240209200538.917366-1-dmitry.baryshkov@linaro.org> <20240209222349.GA923780@nvidia.com> <6511a289-fee6-4d08-9e01-695bd38d4ad6@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_031631_410877_1066D2D8 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 12:55:38PM +0200, Dmitry Baryshkov wrote: > On Tue, 13 Feb 2024 at 12:20, Robin Murphy wrote: > > On 2024-02-13 7:51 am, Dmitry Baryshkov wrote: > > > On Sat, 10 Feb 2024 at 00:23, Jason Gunthorpe wrote: > > >> And then we may get a clue from the backtraces it generates. I only > > >> saw one iommu group reported in your log so I'd expect one trace? > > > > > > I added dev_info + mdelays() around the arm_smmu_init_domain_context() > > > and I can see that it crashes within that function. > > > > Yeah, this is totally broken. We can't just call the unmodified > > arm_smmu_init_domain_context() at domain allocation because half of what > > it's doing belongs to the attach operation. We should not be allocating > > context banks, IRQs, etc. for a not-yet-attached domain, and we > > certainly shouldn't be touching hardware there outside of RPM. > > Should I send a revert? If reverting the patch fixes the issue for you, then yes please! Hopefully you can help Jason test a reworked verson for the future, as it's evident that Tegra doesn't tickle the power management side of things in the same way. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel