From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92719C48260 for ; Tue, 13 Feb 2024 12:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xRNaPtm+NWN4J1Qk5AtWkjjakaeDU8vUwxXdXeq6h8I=; b=eNSwxW+ERAGh4Y iCl8ivuy/e4T+Kn8F+d/7aCEJgRQRxRJH5F/HrHAI3v1zdf33MhpRYlKOOVPO/J61blm57s8Mq1te Bn0XQBH7/FbjzkcIBep0K9DnK7lPts7wEaJAeotnKyVBj6VKaOUw4NjfuP8CR7vXSYSSQym+n3REs bBBqZXNoztM8bLKssBaxhTBFeW2d1XP+jBu7YlR2sDVulHSqKTAHdJRAMnT6yGErDN13WoJ2W+63r 7EA6T7TEDNu4Sejrd9rD9xgYrPQvLaAVfefoek1hnKXyn9CRORAW1x8h1WKyc22D1vRGwpnGSQAuI UICHwfMNpZd81yHltXdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZres-000000098e1-14O6; Tue, 13 Feb 2024 12:13:06 +0000 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZrep-000000098bk-2ojo for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 12:13:05 +0000 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-206689895bfso3061677fac.1 for ; Tue, 13 Feb 2024 04:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1707826379; x=1708431179; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lh2S53PNrVSpQ9ctYNwyUkzWXBkJcw0etvJ1hxA115I=; b=Tlwsn+DtD45XXwUtlm8qJB60/FnjRT6gL4IBFXIEnYDil3w/vJV9smO5o6wY03HGyW 8Oam4hgaE11nOlX4W7PDIFZ1Di5rjBMSniB9cn3jBdwJoyJp4SZBi7aIqi92wMqRcAQY GsIEEgQabXnXkZsSDyy4Q5Q0+W78QVbnHka5AQxR6tU0v978ady0aEmDt0NnbBt+uCGM tDi+F7uF+qv1Jx9RAU02kSMfR4wQ5SGZvZWrcqr6wpf/Hvleilaaa0vpL/MmlummcMe8 tw9+SKB/8Z36Ek0sTNyyXh5PtVIDPh/wsgkk8f5S3ZJoP1cRDln75dixXXuXSUmS8U72 La9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707826379; x=1708431179; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lh2S53PNrVSpQ9ctYNwyUkzWXBkJcw0etvJ1hxA115I=; b=nwfYnN/Gp9W15RR6iHOqhE2DZKSzamkXsdgq+mTroSHWtwwSqAV+mBMYkahU8Q2lLO fUcLki9jjYtxsyQPR9eNqCixpL8cqaGdmIC28l4jHKZjDMdhypZBaftLICxTYSpPv+lx xBVzjdDc2w1KWulr29XOK/PCMiTP5CIobBHxA4MrqvjqEbwNhlTIhRv+No/GjW6C71Mm 8R9aFTRgHhw6a6U2DwHHrIrBsH6WL9T9frYnkqrvc9yw9RV2dFcWX6L/zHvGfdVHUATN KfkbjmqJFdfpnTripEb22sjy6VpBwNPZNzSNZmlr3qhv4cHLHlqRpnvjPv8XdTtul0aN 5LFg== X-Forwarded-Encrypted: i=1; AJvYcCWVZ7m3GpTLzw7fRUwwc93LUNsjOfQNxWMNIS/1NtF0Bi0OHecqdWBbCbotv72KY1gj3QkCAdH8ztSzGQuK05f1Owp8w/RWgqJNQgbun+TtkUoYbfA= X-Gm-Message-State: AOJu0YyD0DQGLP5YmkIsd7LgqQRW20G12WjviPnhTg2mLoA0lBYRePCX qAmKjoSxQd9GN85rK0ZyWeYSxGhfl2Fr56jgRkto1NLtRAweRaJIelDjptO7MrA= X-Google-Smtp-Source: AGHT+IF2S9NvcWTIHZLBSkIb+Q4dx69PQhLwBzE8c7PMO/UI2iadkvy+/2caCK/VF1CqKs//+EdA9Q== X-Received: by 2002:a05:6870:c08e:b0:21d:d9b:c3fd with SMTP id c14-20020a056870c08e00b0021d0d9bc3fdmr139240oad.55.1707826379654; Tue, 13 Feb 2024 04:12:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW2Ro/6j76H4+eYPLEB5BTAvd5rTrW/8UhzECCu6fwZzxbdzMM0SdAuI9ybj/E0Ugy+RxmKQivEi89dwRYWHXUIov3z8oBQvUatKs1hPmwzqhXOKVMnf0YuRjqnAJla4DB7u9rv5wn3+HrOYc3ZlQhF9e3PBvPk8irT7HZRtTTMkcJmdsbJZz6PjYRMBYW3FTjQxp3zfWwwCDMW3DgZtW7PyPHfBGvfntvE3sFPdLhIwMZq7CwPMkMw+92tC7iX46F53xxoCrI= Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id p9-20020a0568301d4900b006e2df9470d4sm435849oth.80.2024.02.13.04.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 04:12:58 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rZrej-0040Cc-KN; Tue, 13 Feb 2024 08:12:57 -0400 Date: Tue, 13 Feb 2024 08:12:57 -0400 From: Jason Gunthorpe To: Dmitry Baryshkov Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Clark , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] Revert "iommu/arm-smmu: Convert to domain_alloc_paging()" Message-ID: <20240213121257.GI765010@ziepe.ca> References: <20240213-iommu-revert-domain-alloc-v1-1-325ff55dece4@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240213-iommu-revert-domain-alloc-v1-1-325ff55dece4@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_041303_837553_9E0B0D6D X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 01:31:56PM +0200, Dmitry Baryshkov wrote: > This reverts commit 9b3febc3a3da ("iommu/arm-smmu: Convert to > domain_alloc_paging()"). It breaks Qualcomm MSM8996 platform. Calling > arm_smmu_write_context_bank() from new codepath results in the platform > being reset because of the unclocked hardware access. > > Fixes: 9b3febc3a3da ("iommu/arm-smmu: Convert to domain_alloc_paging()") > Signed-off-by: Dmitry Baryshkov > --- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) Please no, as I said in the other email the only thing that should be reverted is this: > @@ -875,15 +879,6 @@ static struct iommu_domain *arm_smmu_domain_alloc_paging(struct device *dev) > mutex_init(&smmu_domain->init_mutex); > spin_lock_init(&smmu_domain->cb_lock); > > - if (dev) { > - struct arm_smmu_master_cfg *cfg = dev_iommu_priv_get(dev); > - > - if (arm_smmu_init_domain_context(smmu_domain, cfg->smmu, dev)) { > - kfree(smmu_domain); > - return NULL; > - } > - } > - > return &smmu_domain->domain; > } Everything else is fine, you already tested with that arrangement. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel