From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 651DDC48260 for ; Tue, 13 Feb 2024 12:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bOTGxSXbPf8TNIwUumDLTHvQwObIwgM97csjzziSR94=; b=EciLKEeCmsmTrq Df21nDK70nUbj8tbvosYsSUU38sY1QDMpogkL70vrliz1dq6K4WcbdKu8EdTH1vKfSV3i8l9wv4QY AqQuowoByFWkAcltWi0X8ZC6RYNEoTbtWnu6a/zv8gA51FcBV0jz439p5N1XZvMjzOUfioxa2AfGO IQSjTD7DEngSlKD9CDjZwAf/mVcQyPgfGKmQtM5QYUiibTbiujMIo8CG35e6tiNcAD83hJovzJbTx LhPADQsT8yr2UnESxwRq4QjZt/zfqGNuWZl0QanwtUTeAzdePgzSExx/EP75p9qmJq5Qh72gcBg/f 8dL8FEqj+6NqdAjZAkYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZsHe-00000009F4o-0OXV; Tue, 13 Feb 2024 12:53:10 +0000 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZsHb-00000009F4S-1Atw for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 12:53:08 +0000 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-218eea4f1a7so2384373fac.3 for ; Tue, 13 Feb 2024 04:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1707828786; x=1708433586; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PYlY4epw8eo23hBH5onki0iwHafDPOFpum80B41NzZM=; b=jwTbvIiVwQQj1nnsvjFuD3kRisEGBYj+Xh0LEzfZEnK1089r90OmS5ZqWUD8Ud09J4 zQ6MnBxRzU6zHEM325IozVo40ja5Am8WGUxI4+JVQgyI7Q196dhPgX4L6Goou1adsaKL BONlLAHCviBvDv82ziVEBPnsnPbO07XoCAmZVZuaLcmQxYQwDko7TIWXrZDXjHKs169g /zf2+tCx78CWZBAtASZ3Qgdx0xj+PM/53J0cBnLSvfPTfkWRLOjK38QwNHQlOti+YX6a G92Wbr/M6VpwOlC2LsSW/4Sb6EB7FFNpILrfgw+CWIdwStJQJp1EyW7avHyVur5jjGBa l6yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707828786; x=1708433586; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PYlY4epw8eo23hBH5onki0iwHafDPOFpum80B41NzZM=; b=fgHZmuWwTf/SY4xsy/8g4lRy1I0eb6t9NaQCt2CfRD9bLQ2ONIqAUl7VR+sp6pCFvJ 5DL7Q40d+9ksQjalEB4jCCCT/9XJcfB3kzcvSFSiLkzhgL7wRb4A9LtUrMcxWyjxB9/N dKNriv8jWKhgpoN3AP2/dYvRDpD974HtZ2cXelkSh/QOrvi5mxmwPqumwVbemghaaJK9 +369dKRfT/2sQFt10nmIphP9Ok/rPqGX1Rocalqucg1CMUm/bhIM7EfoOA3o736pd6Ia k7+XM0MzWSrarpUCOVp4dGwDpLfLDGUjQZxwR9xUBjTL9hPTFMUR61NGsama+Rn15bLW 1PLQ== X-Gm-Message-State: AOJu0YyTS2Bn88I13ZtX0zKxQB07GbrC+Xz6e3xJQ7pkb5bOMqOHLjZK hyFB/l+cT+mqQWRrYXUHdx0eLR6aUHzU3dGWyhfMKOAxGaSgDCHBEVNJAUu2UfU= X-Google-Smtp-Source: AGHT+IGXkMm8BsVHGtdwe6ZYkH1WocH0C7Za2EnH5WwIcROjlfnVZ2BR2bYIkyqLIlksNy6/7ZFRdg== X-Received: by 2002:a05:6870:5246:b0:218:f129:8a98 with SMTP id o6-20020a056870524600b00218f1298a98mr9525379oai.42.1707828784969; Tue, 13 Feb 2024 04:53:04 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXH/vangM+zSm7yay+2+1sIJ4NTSgXE8HgI1nWybWorcFukbgqOIOm6VMAJ5kCF1To1NOYQ9+ty/g2/Dt1TQ2VjkwVQfPQIEDIabvSg9RseMpSokfeENM0DTL+kDfGOYbyWuj6LKI9N2Bd86AClZZAil1QlHaLfl7pTiydNo9Bp2oX1Kgz6R2b42UApdFW2J9x6KzZA6VpJfIW4MBwlflRudb2eNoXbaT7hbaw79qLz5lj0omrABNtOVLwJ9QELiQqDkWM7tIE= Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id hz10-20020a05687153ca00b0021a714d556asm683907oac.41.2024.02.13.04.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 04:53:04 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rZsHX-0048lN-Hc; Tue, 13 Feb 2024 08:53:03 -0400 Date: Tue, 13 Feb 2024 08:53:03 -0400 From: Jason Gunthorpe To: Will Deacon Cc: Dmitry Baryshkov , Robin Murphy , Joerg Roedel , Rob Clark , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] Revert "iommu/arm-smmu: Convert to domain_alloc_paging()" Message-ID: <20240213125303.GJ765010@ziepe.ca> References: <20240213-iommu-revert-domain-alloc-v1-1-325ff55dece4@linaro.org> <20240213121257.GI765010@ziepe.ca> <20240213121934.GA28726@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240213121934.GA28726@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_045307_338825_482BC362 X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 12:19:34PM +0000, Will Deacon wrote: > > > @@ -875,15 +879,6 @@ static struct iommu_domain *arm_smmu_domain_alloc_paging(struct device *dev) > > > mutex_init(&smmu_domain->init_mutex); > > > spin_lock_init(&smmu_domain->cb_lock); > > > > > > - if (dev) { > > > - struct arm_smmu_master_cfg *cfg = dev_iommu_priv_get(dev); > > > - > > > - if (arm_smmu_init_domain_context(smmu_domain, cfg->smmu, dev)) { > > > - kfree(smmu_domain); > > > - return NULL; > > > - } > > > - } > > > - > > > return &smmu_domain->domain; > > > } > > > > Everything else is fine, you already tested with that arrangement. > > Partial reverts are a recipe for confusion, so I'll take this and if you'd > like to bring back some of the hunks, please can you send a patch on top > that does that? The typical kernel standard is to fix bugs in patches and only reach for a wholesale revert if the community is struggling with bug fixing. Dmitry already tested removing that hunk, Robin explained the issue, we understand the bug fix is to remove the arm_smmu_init_domain_context() call. Nothing justifies a full scale revert. I'll send another patch if you want, but it seems like a waste of all our time. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel