From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1556CC48260 for ; Tue, 13 Feb 2024 22:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cXfanc8xeLvmxZbZgf3gbBQEHCotUz3H+vWdCukuyWg=; b=CKgq4fkWKFA6Fx ZdWSyTFCuT1ybKMbgmgKFvVjNxvMqfr8UP1la7yW1hnRGtK0iDcDblWfDRpbFEmQw+lWC2W14jJOn 89fD6lezua+SNjDvzBMxv8/tLXH4WabA24zflQwLdj/jEjgtbtWXBvHItuezAssKrm0QsKBJWlbVi ph/XYUimcPrBthRi1hzSuGiwe+XKIogLgBPAXeho7rRTXueOOsOsN0dMnsouF0TYdqGnw6aw0ATxg W6Ri5LkGaAb9DDsBGVXp7r15ICtIf5ZreCWn+WP93ji5szQOZq8Gw4MnyqAHparazBJyLwnatkTyz Rba/JI5H2bLb7K/ZY1iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ra1GB-0000000B3uL-12sM; Tue, 13 Feb 2024 22:28:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ra1G7-0000000B3td-3goM; Tue, 13 Feb 2024 22:28:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 53BE8614CD; Tue, 13 Feb 2024 22:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C98C7C433C7; Tue, 13 Feb 2024 22:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707863291; bh=oFFuZOUNHSicGqYZMLonLDDYLy/GpUY8EBDB1WTG0es=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JGYwGyrXK0nZVTCamXE68PrmsELblm6cb8mI3mbXPZc25oIOSYbHIWJoHI51r7Vn3 TsCNlOmBf2Hr9SQCZzeHfyBJlackDsH7UzciNBg0CANB3tAk7ds4Ue0VTyOQHCUbKK jhNqA0EcAEftZD4goOrxFg6NJU/4a79BHiGCcTvWTdY4YBjVst8sfWyS3RibS3sCIO gmfkzc/KkApqmTn1NKZF6W8R2y9dds7mKR+skzNlXlIOfAjwrVrg25PApvx5eLsEdo Dtufo9gsq9TAGe/CpwxVRE3DV0DhYTTwFC4SphIJPic5hhMp4gJRLyqaS7TxOL3ZOt VlqZKTej1QzQg== Date: Tue, 13 Feb 2024 16:28:08 -0600 From: Rob Herring To: Manojkiran Eda Cc: Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , jk@codeconstruct.com.au, Patrick Rudolph , Chia-Wei Wang , Ryan Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, openbmc@lists.ozlabs.org, zev@bewilderbeest.net Subject: Re: [PATCH] Add eSPI device driver (flash channel) Message-ID: <20240213222808.GA2490812-robh@kernel.org> References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240213-espi_driver-v1-1-92741c812843@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_142812_035700_7610B2E7 X-CRM114-Status: GOOD ( 31.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 08:06:08PM +0530, Manojkiran Eda wrote: > This patch adds the driver support for the eSPI controller of > Aspeed 5/6th generation SoCs. This controller is a slave device > communicating with a master over Enhanced Serial Peripheral > Interface (eSPI). > > eSPI supports 4 channels, namely peripheral, virtual wire, > out-of-band, and flash, and operates at max frequency of 66MHz. > > But at the moment, this patch set only supports the flash channel. You're not going to need binding changes to add support for those, right? > > Signed-off-by: Manojkiran Eda > --- > Hello everyone, > > I'm presenting a revised version of the eSPI device driver patch series found at the following link: > > https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ > > This update addresses the issues identified during the review process. > > While the previous patch series attempted to incorporate support for all four different channels of eSPI, > this new series focuses on upstreaming the flash channel initially, ensuring that all review comments are > duly addressed, before progressing further. > > Results: > > Successfully conducted a flash update via eSPI. > > Note: > > This marks my inaugural endeavor in contributing code to the kernel subsystem. I kindly request reviewers > to incorporate as many details as possible in the review comments. Please start with submitting-patches.rst and the DT specific version of that. > --- > .../devicetree/bindings/soc/aspeed/espi.yaml | 125 ++++++ This should be a separate patch. checkpatch.pl will tell you this and other things. Filename should match compatible. > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 16 +- This is another patch. > drivers/mtd/mtdcore.c | 2 +- Yet another patch. But really, this one will be rejected most likely unless you can justify why it is needed. > drivers/soc/aspeed/Kconfig | 10 + > drivers/soc/aspeed/Makefile | 3 + > drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 +++++++++ > drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 ++++++++ > drivers/soc/aspeed/aspeed-espi-flash.c | 466 +++++++++++++++++++++ > drivers/soc/aspeed/aspeed-espi-flash.h | 45 ++ > include/uapi/linux/espi/aspeed-espi-ioc.h | 103 +++++ Your own interface to userspace is probably not going to be accepted either. > 10 files changed, 1134 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/aspeed/espi.yaml b/Documentation/devicetree/bindings/soc/aspeed/espi.yaml > new file mode 100644 > index 000000000000..6521a351d18d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/aspeed/espi.yaml > @@ -0,0 +1,125 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# # Copyright (c) 2021 Aspeed Technology Inc. It's 2024 now. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/aspeed/espi.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Aspeed eSPI Controller > + > +maintainers: > + - Manojkiran Eda > + - Patrick Rudolph > + - Chia-Wei Wang > + - Ryan Chen > + > +description: > + Aspeed eSPI controller implements a slave side eSPI endpoint device s/slave/device/ > + supporting the four eSPI channels, namely peripheral, virtual wire, > + out-of-band, and flash. > + > +properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2500-espi > + - aspeed,ast2600-espi > + - const: simple-mfd > + - const: syscon > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: true > + > +patternProperties: > + "^espi-ctrl@[0-9a-f]+$": > + type: object Is this really a separate sub-block? As in could it be reused somewhere else or in a different combination of blocks? > + > + description: Control of the four basic eSPI channels > + > + properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2500-espi-ctrl > + - aspeed,ast2600-espi-ctrl > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + flash,dma-mode: > + type: boolean > + description: Enable DMA support for eSPI flash channel > + > + flash,safs-mode: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 0, 1, 2 ] > + default: 0 > + description: Slave-Attached-Sharing-Flash mode, 0->Mix, 1->SW, 2->HW > + > + required: > + - compatible > + - interrupts > + - clocks > + > + "^espi-mmbi@[0-9a-f]+$": > + type: object Is this really a separate sub-block? > + > + description: Control of the PCH-BMC data exchange over eSPI peripheral memory cycle > + > + properties: > + compatible: > + const: aspeed,ast2600-espi-mmbi > + > + interrupts: > + maxItems: 1 > + > + required: > + - compatible > + - interrupts > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + > + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; > + }; > + > + espi_mmbi: espi-mmbi@800 { > + compatible = "aspeed,ast2600-espi-mmbi"; > + reg = <0x800 0x50>; > + interrupts = ; > + }; > + }; > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > index c4d1faade8be..08d7a2689086 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > @@ -453,7 +453,21 @@ video: video@1e700000 { > interrupts = ; > status = "disabled"; > }; > - > + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>,<0x0 0x4000000>; > + reg-names = "espi_ctrl","espi_flash"; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; > + status = "disabled"; > + }; Wrong indentation. > + }; > gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel