From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89C57C48260 for ; Tue, 13 Feb 2024 22:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zkd7j9ee3LwEF8iPHtn7ueLF8z9QFA45zC/YNXvNr5E=; b=aEN9QhWK2LI0wM TFlm5BRWTagpPtrbm9iyoESKoRkpWQQggzrrUkRv0lQ/HW4+LD0FdpeNevHFnjXkdbSrkK83s3zIe +HnSdufgkpFbBe/MGvqxQf4mzl72b7goEek3Fc+Dq1SfB5YtmGIvFFxmGMJBM8gbDYipWuXQJpTtr mLTeJlU+Qu/6uKPnEKVDyry5S1i77siUn2ZuYpWlQq6sJEzueMmW6MgQueJB3/uVUnbcXm2wwzJlm kHkfBUgzXdfVSpF+/fhT2t/IRNcZlbgdTkjlzI2RN8b5afltmm7r1B6FdJG9odJBGEFTC67beehvC U0VDk+o/M1iwq2GBNHHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ra1JS-0000000B56E-2oTg; Tue, 13 Feb 2024 22:31:38 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ra1JP-0000000B54w-0GQN for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 22:31:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 39692CE1F65; Tue, 13 Feb 2024 22:31:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D7F7C433F1; Tue, 13 Feb 2024 22:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707863492; bh=tUMsXY/XfFkqr7u0iiEPY04YFBGnHpoUhaqNlD4VLF4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kj9Ww9VMf2s40wjwtHIk/4onEZen6N4x8brxw8zIQYpWt9ckJpLD0s1PsT1D7Ia4b rr2biX+69XirmVQ1ZHWV7XJ9mxseJb1hE58+/+s8cwIBW5dBHX+PexEUR3sGzke4rZ 5m5gzjxGgFtIZ5SssmS9sjsAjZDSIz77/F0zzHUbpK5uHdFlzlge/QvRan4fgWux6N gLyH70dAC1VOq5bTjKC60y4/PcpqjtK8rKpSz9hy3y67IEX7NhDqNy/GzlnJ3sXT2y J/1vuXMajieuCWoMVIgh7QSHrLpk+Kgbqc1Rpd0Z5dxLiCzoeCkFOgO3j0g76rHU5U 9W+cutZzWdbBw== Date: Tue, 13 Feb 2024 16:31:30 -0600 From: Rob Herring To: Tanmay Shah Cc: andersson@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-remoteproc@vger.kernel.org, michal.simek@amd.com, Radhey Shyam Pandey , ben.levinsky@amd.com, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v10 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Message-ID: <20240213223130.GA2504650-robh@kernel.org> References: <20240213175450.3097308-1-tanmay.shah@amd.com> <20240213175450.3097308-3-tanmay.shah@amd.com> <170785205177.2155555.1311787541370066483.robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_143135_468977_ED9D3FFE X-CRM114-Status: GOOD ( 25.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 02:37:49PM -0600, Tanmay Shah wrote: > Hello, > = > Thanks for reviews please find my comments below. > = > On 2/13/24 1:20 PM, Rob Herring wrote: > > On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote: > > > From: Radhey Shyam Pandey > > > = > > > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > > > UltraScale+ platform. It will help in defining TCM in device-tree > > > and make it's access platform agnostic and data-driven. > > > = > > > Tightly-coupled memories(TCMs) are low-latency memory that provides > > > predictable instruction execution and predictable data load/store > > > timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memo= ry > > > banks on the ATCM and BTCM ports, for a total of 128 KB of memory. > > > = > > > The TCM resources(reg, reg-names and power-domain) are documented for > > > each TCM in the R5 node. The reg and reg-names are made as required > > > properties as we don't want to hardcode TCM addresses for future > > > platforms and for zu+ legacy implementation will ensure that the > > > old dts w/o reg/reg-names works and stable ABI is maintained. > > > = > > > It also extends the examples for TCM split and lockstep modes. > > > = > > > Signed-off-by: Radhey Shyam Pandey > > > Signed-off-by: Tanmay Shah > > > --- > > > = > > > Changes in v10: > > > - modify number of "reg", "reg-names" and "power-domains" entries > > > based on cluster mode > > > - Add extra optional atcm and btcm in "reg" property for lockstep m= ode > > > - Add "reg-names" for extra optional atcm and btcm for lockstep mode > > > - Drop previous Ack as bindings has new change > > > = > > > Changes in v9: > > > - None > > > Changes in v8: > > > - None > > > Changes in v7: > > > - None > > > Changes in v6: > > > - None > > > Changes in v5: > > > - None > > > = > > > Changes in v4: > > > - Use address-cells and size-cells value 2 > > > - Modify ranges property as per new value of address-cells > > > and size-cells > > > - Modify child node "reg" property accordingly > > > - Remove previous ack for further review > > > = > > > v4 link: https://lore.kernel.org/all/20230829181900.2561194-2-tanmay.= shah@amd.com/ > > > = > > > .../remoteproc/xlnx,zynqmp-r5fss.yaml | 192 ++++++++++++++++= -- > > > 1 file changed, 170 insertions(+), 22 deletions(-) > > > = > > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_chec= k' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > ./Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml:1= 18:13: [warning] wrong indentation: expected 10 but found 12 (indentation) > Ack. I will fix this. > = > However, can I still get reviews on patch itself so if something else nee= ds to be fixed I can fix in next revision as well. > = > Also, I tried to run yamllint with following command: > = > make DT_CHECKER_FLAGS=3D-m dt_binding_check DT_SCHEMA_FILES=3DDocumentati= on/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml O=3D../build/zynqm= p/linux-next/ > = > = > However, I see following logs without any error on bindings: > = > =A0 LINT=A0=A0=A0 Documentation/devicetree/bindings > invalid config: unknown option "required" for rule "quoted-strings" > *xargs: /usr/bin/yamllint: exited with status 255; aborting* > =A0 CHKDT=A0=A0 Documentation/devicetree/bindings/processed-schema.json > =A0 SCHEMA=A0 Documentation/devicetree/bindings/processed-schema.json > =A0 DTEX=A0=A0=A0 Documentation/devicetree/bindings/remoteproc/xlnx,zynqm= p-r5fss.example.dts > =A0 DTC_CHK Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fs= s.example.dtb > = > I am not sure if my system is missing something but, yamllint tool is fai= ling. "unknown option" means old version of yamllint. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel