From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D020EC48BC1 for ; Wed, 14 Feb 2024 17:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X6qDdhieCfeauaIzdQoZbeYPlddWtrHXn8T8SdlkzaA=; b=lITZ3mnGNcsx04DlTfUeyAR2+g Y8rYfxGaYyPVL8GIQQpiotVC9ZoKKAdQ3hxW8TDNDgRZbkkYJOh/kPxcC+6eBz3UPWx07egHM3gy3 4JqGmGFTeeX4iZKZahy1RmTzfeU953vQqRg6YOv08TAxlzAgo7YnJWsyG/ZoIsNR3nR4Lzh/9sWSg vhegtF/bEU3ndHTCHgKLTM4mHfBWM6itrmkjiQyAp3iDTCXVkNe/sWRzhL/KLOLZi5/5PK2Pr3JZx hngVlTRvVCiMSCA9vW/88ocau4u/Mvd5xFkTpNobUkewWX9AVFEYjILBRGx7z/okdcev/D0chr4XL 9QfPF4vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raJCI-0000000DlWd-2vxE; Wed, 14 Feb 2024 17:37:26 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raJCG-0000000DlVp-16pH for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 17:37:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 889FFCE234B; Wed, 14 Feb 2024 17:37:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4215EC433C7; Wed, 14 Feb 2024 17:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707932241; bh=ek0NtWmXn+TPNiS8vFBud6b8Ud2vwDMcMY53ZCY+JtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F+LwPgyIF84VQbj5U8WQ+0p7pORiBON/e13af5EX5X7Kn0Pt9QWqdSovyNxFILQWK U9ITu+xJiXrz5c0ZeNeTcx/mxJvD7pvy+xa0NkE+9w4NFX9TMtPrH5fM9eaStrHcAy KcTLqGw2jSbhQGt1Ffukl9WrwMjT69hNeLzhwjsmH8jL/kopEgTM0NKjZTvzr56e6/ d70KfOke0axc7ffOtRboRbA8935VXmWEnJzSukRXW9hV0+lnVhpB0PnpCVx59ISIwK DRT4alC+YWwSTAQ/tylUdm4UZTWhjh/fgwNpJv3HUEeorDJOq3YUFhsdfuniDGUBva nZ4GHIYvu8rIw== Date: Wed, 14 Feb 2024 17:37:17 +0000 From: Conor Dooley To: Laurent Pinchart Cc: Daniel Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240214-velcro-pushy-0cbd18b23361@spud> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240214142825.GA7873@pendragon.ideasonboard.com> MIME-Version: 1.0 In-Reply-To: <20240214142825.GA7873@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_093724_653865_DB11F612 X-CRM114-Status: GOOD ( 25.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9129922613001226139==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9129922613001226139== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O6sj7yKlLqG4SpJ7" Content-Disposition: inline --O6sj7yKlLqG4SpJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 14, 2024 at 04:28:25PM +0200, Laurent Pinchart wrote: > Hi Dan, >=20 > Thank you for the patch. >=20 > On Wed, Feb 14, 2024 at 02:19:03PM +0000, Daniel Scally wrote: > > Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > >=20 > > Acked-by: Nayden Kanchev > > Signed-off-by: Daniel Scally > > --- > > Changes in v2: > >=20 > > - Added clocks information > > - Fixed the warnings raised by Rob > >=20 > > .../bindings/media/arm,mali-c55.yaml | 77 +++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c5= 5.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml = b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > new file mode 100644 > > index 000000000000..30038cfec3a4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > @@ -0,0 +1,77 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ARM Mali-C55 Image Signal Processor > > + > > +maintainers: > > + - Daniel Scally > > + - Jacopo Mondi > > + > > +properties: > > + compatible: > > + const: arm,mali-c55 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: ISP video clock >=20 > I wonder if we need this clock. Granted, it's an input clock to the ISP, > but it's part of the input video bus. I don't expect anyone would ever > need to control it manually, it should be provided by the video source > automatically. I'd say that if there's a clock controller providing this clock, even if it is implicit in the video feed it's good to have here. Being able to increment the refcount on that clock would be good, even if you don't actually control it manually? >=20 > > + - description: ISP AXI clock > > + - description: ISP AHB-lite clock >=20 > These two other clocks look good to me. >=20 > > + > > + clock-names: > > + items: > > + - const: vclk > > + - const: aclk > > + - const: hclk Why not "video" "axi" "ahb-lite"? There's 3 useful letters between the tree clock names you've provided - they're all clocks, so having "clk" in them is just noise :) Cheers, Conor. --O6sj7yKlLqG4SpJ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZcz6TAAKCRB4tDGHoIJi 0qn4AQCdJgBnLTSQ8gusKx8Zo7Jon05mtC/gi+jhKni5OcXmEgD+LLunh7p+YkjY 0u9tdxfmxPW4Wa7dkDdQSr7iSDDlUwY= =B5rx -----END PGP SIGNATURE----- --O6sj7yKlLqG4SpJ7-- --===============9129922613001226139== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9129922613001226139==--