From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A354C48BC4 for ; Wed, 14 Feb 2024 10:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RJBKyU5SCFEd1Qb0SryYmP71aTB5XkqSIu+J6gkwHj4=; b=setkQGGxTHuxI8 EyzTnHkpksxtJYgbYnhSs0GIXC0GyKrDubQYv/XcuLuQY6QxN2R3gGgFfg20xgFRi3mSIeeFiGRd0 4ErFe1aP9ldV7EW0f4kn4+DaJ6DesH4OZIFTcHwV2ZAmL+HAlsgDj9wf8SylZ3wkE/iPDLJIhUsyx 0caAJbCo9boMcr0CgPxJc9yDpXnAwOXCEk+iPbCnUD3B/M+W2ejmy3yzj1B/iR4viH7um1CDmHgVw EHze4rz4Ved7ualfdirRLbgp8aebAouv1JCP3KCpZ/bIJ/pYxifnJG/w6kfsS+bAQI3PcJvZV0QA2 w5Og7dz5GrUQVRYggSaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raCsg-0000000CaCJ-2dNO; Wed, 14 Feb 2024 10:52:46 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raCsb-0000000CaAr-3oU9 for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 10:52:45 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id EEE8120272; Wed, 14 Feb 2024 11:52:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1707907951; bh=3piN2479mTbGHmItuCrKboZS6ZZmmMJocdeKlE4lYoE=; h=From:To:Subject; b=oAl2KAv9Kq22FWnYKpuVm7S8yQAERPms1HXNxtnhCAb1VQsKEm6h+7T4DoHJJ83p+ Pr/E70uV1Q4fDGsd5DmS1l3z9qS5LELsTRZ0rGOUlAghjM2qvRi2iLGQnle0ANkJdR ZHtgIMsf479bU24I5iHEXsJpqRwRsI2/9GjWLsAFD539zRjjzOYXhxTOyaxEojcSSN wUzHKVPplmA5iYL5xyGZipDc0nOVO5ID5rIWB7gZ25qMylzIuo9C61U1htvN2BL+b9 JxI6Wu6H+V9L1R34yQyfU4Fcbm6rWXls6lqLsFPUQ484YJQGC6rPsqXtmFkGAYPihJ SEIXw8b8X/2Fg== Date: Wed, 14 Feb 2024 11:52:23 +0100 From: Francesco Dolcini To: Roland Hieber , Linux Regressions Cc: Hiago De Franco , Marco Felsch , Shawn Guo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Philipp Zabel , kernel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: MXSFB error: -ENODEV: Cannot connect bridge Message-ID: <20240214105223.GA78582@francesco-nb> References: <34yzygh3mbwpqr2re7nxmhyxy3s7qmqy4vhxvoyxnoguktriur@z66m7gvpqlia> <20240212110706.ibrreoj2wgzhltyw@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240212110706.ibrreoj2wgzhltyw@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_025243_865956_A883B9ED X-CRM114-Status: GOOD ( 31.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Linux regression. This is a regression on v6.8-rc1. On Mon, Feb 12, 2024 at 12:07:06PM +0100, Roland Hieber wrote: > On Thu, Feb 08, 2024 at 12:58:02PM -0300, Hiago De Franco wrote: > > Hello all, > > > > while doing some tests with kernel v6.8-rc3 and Colibri iMX7D, we > > noticed the following error: > > > > [ 0.432547] mxsfb 30730000.lcdif: error -ENODEV: Cannot connect bridge > > > > This was introduced by commit edbbae7fba495284f72f05768696572691231558 > > ("ARM: dts: imx7: add MIPI-DSI support"). This patch is routing the > > lcdif to the mipi_dsi_in_lcdif endpoint, however we do not have the DSI > > pins available in our edge connector. Instead, we use the parallel RGB > > LCD interface directly with, as example, an external LVDS transmitter: > > > > &lcdif { > > ... > > status = "disabled"; > > > > port { > > lcdif_out: endpoint { > > remote-endpoint = <&lcd_panel_in>; > > }; > > }; > > }; > > > > By applying the following patch, the issue is gone and the LVDS works > > again: > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7s.dtsi b/arch/arm/boot/dts/nxp/imx/imx7s.dtsi > > index ebf7befcc11e..9c81c6baa2d3 100644 > > --- a/arch/arm/boot/dts/nxp/imx/imx7s.dtsi > > +++ b/arch/arm/boot/dts/nxp/imx/imx7s.dtsi > > @@ -834,16 +834,6 @@ lcdif: lcdif@30730000 { > > <&clks IMX7D_LCDIF_PIXEL_ROOT_CLK>; > > clock-names = "pix", "axi"; > > status = "disabled"; > > - > > - port { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - lcdif_out_mipi_dsi: endpoint@0 { > > - reg = <0>; > > - remote-endpoint = <&mipi_dsi_in_lcdif>; > > - }; > > - }; > > }; > > > > mipi_csi: mipi-csi@30750000 { > > @@ -895,22 +885,6 @@ mipi_dsi: dsi@30760000 { > > samsung,esc-clock-frequency = <20000000>; > > samsung,pll-clock-frequency = <24000000>; > > status = "disabled"; > > - > > - ports { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - port@0 { > > - reg = <0>; > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - mipi_dsi_in_lcdif: endpoint@0 { > > - reg = <0>; > > - remote-endpoint = <&lcdif_out_mipi_dsi>; > > - }; > > - }; > > - }; > > }; > > }; > > > > I would like to know your opinion about this patch before sending it, > > does it makes sense for you? I understand that routing to endpoint > > should be done in the SoM device tree, so we are free to rout other > > endpoint without issues. > > As far as I understood, the LCDIF -> DSI connection is always present in > the SoC. Can you overwrite the routing in your dts like this:? > > &lcdif_out_mipi_dsi { > remote-endpoint = <&lcd_panel_in>; > }; > > I'm not sure what is the best default solution here for imx7s.dtsi. Also > the labels don't work out in that case, this could be improved. For sure for something to be defined a solution it should not introduce regressions :-) This commit makes other boards not work anymore, specifically this reports is about colibri-imx7. With that said, the following patch solves the issue diff --git a/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi index 9fe51884af79..966ad13e7c78 100644 --- a/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi @@ -536,12 +536,15 @@ &lcdif { status = "disabled"; port { - lcdif_out: endpoint { + lcdif_out: endpoint@0 { + reg = <0>; remote-endpoint = <&lcd_panel_in>; }; }; }; +/delete-node/ &mipi_dsi_in_lcdif; + /* Colibri PWM */ &pwm1 { pinctrl-names = "default"; However, ... I do not really like the delete node, but it's required to prevent this error: arch/arm/boot/dts/nxp/imx/imx7s.dtsi:908.37-911.9: Warning (graph_endpoint): /soc/bus@30400000/dsi@30760000/ports/port@0/endpoint@0: graph connection to node '/soc/bus@30400000/lcdif@30730000/port/endpoint@0' is not bidirectional With that said, unless you have a better solution I would just send a revert for your change. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel