From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96666C48BC4 for ; Wed, 14 Feb 2024 11:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mfUZjrVask0dYGuMDn44tGkGOmVhKuEjnLzk5mZeTLs=; b=uzbgvjvQbFTc/D v2F+mgTj/HOjFCflmcXi9H+BDfb/ehh1ho5iv9fecAvrwsMzY7/fskjW2oApcRWMpsufzLl1C7k0l xyyprQ40PhRU5szVEsExejEpGK0Iq42RF2l3tHcRlyXFO9/JivwqTz/0yVTPCIbfQubOlTV652G7/ 9iPVRJ3a6XTxUgXqbkAexE0AVB/fo5TFzwY+KvDO53fyrhN8LkLY2QfZMS9tWg9djL/MgIEMJrmOl QGnh3d4F0kxe6n847sSYKFudiHy9z8oLSDg+L0jy5y3FcEUS8QcMI8TQ3OcIKvSEl79mu3m6kWp3L uAEyzbOd0CzQBKE5TNXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raDEC-0000000CclH-2NIQ; Wed, 14 Feb 2024 11:15:00 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raDE9-0000000Cci0-0ePJ; Wed, 14 Feb 2024 11:14:58 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2D3341C0008; Wed, 14 Feb 2024 11:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707909293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbCd7AZVKzULogAVyD2ctlD8U9qaBuXdnxYtEHWg6Bs=; b=MG50v+hrg+y7Sg5emV0Q18hc73S4l6SuVbSRMoOxiZZBMANq1M+y6VRkBFK4vpDQ3KUF47 3FCLA/2bvWoZ00xAnOsQvvulgAZlVVWUYZHxY5JuIH5zVV2Cit7f8L4iRyPpepzCuTiGgK K9dvysh0wmA9opy9aJRcIHC8s54VV880sbMcQF34Faqw7Th2DyifiHQJYqwvk0QHwvXVnb Jst/ZTtDH3mWZbe6mRbre1Bh+Hjmw4rHB6+ThnGlvMVRhHhGl15ZjosN5OWrU8xF9pfg2W 13VL4yRUELvVZ8etF64wkowQ61DjwUu9htb2XYIWh2JX555GVMMKY+sSWXoTQg== Date: Wed, 14 Feb 2024 12:14:48 +0100 From: Luca Ceresoli To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, marex@denx.de, aford@beaconembedded.com, Lucas Stach , Richard Leitner , Marco Felsch , Alexander Stein , Frieder Schrempf , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 2/6] phy: freescale: add Samsung HDMI PHY Message-ID: <20240214121448.451e2e1c@booty> In-Reply-To: <20240210204606.11944-3-aford173@gmail.com> References: <20240210204606.11944-1-aford173@gmail.com> <20240210204606.11944-3-aford173@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_031457_500671_FB05BE99 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 10 Feb 2024 14:45:58 -0600 Adam Ford wrote: > From: Lucas Stach > > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. Based on downstream implementation from > Sandor Yu . According to the TRM, the PHY > receives parallel data from the link and serializes it. It > also sets the PLL clock needed for the TX serializer. > > Tested-by: Luca Ceresoli (v2) > Tested-by: Richard Leitner (v2) > Co-developed-by: Marco Felsch > Signed-off-by: Marco Felsch > Signed-off-by: Lucas Stach > Tested-by: Alexander Stein > Tested-by: Frieder Schrempf # Kontron BL > Tested-by: Luca Ceresoli > Signed-off-by: Adam Ford [...] > +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy) > +{ > + struct device *dev = phy->dev; > + struct device_node *np = dev->of_node; > + struct clk_init_data init; > + const char *parent_name; > + struct clk *phyclk; > + int ret; > + > + parent_name = __clk_get_name(phy->refclk); > + > + init.parent_names = &parent_name; > + init.num_parents = 1; > + init.flags = 0; > + init.name = "hdmi_pclk"; > + init.ops = &phy_clk_ops; > + > + phy->hw.init = &init; > + > + phyclk = devm_clk_register(dev, &phy->hw); > + if (IS_ERR(phyclk)) > + return dev_err_probe(dev, PTR_ERR(phyclk), > + "failed to register clock\n"); > + > + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk); As per my v8 review, this function is deprecated: https://elixir.bootlin.com/linux/v6.8-rc4/source/drivers/clk/clk.c#L4881 However: [Tested using Avnet MSC SM2S-IMX8PLUS SoM on Avnet MSC SM2-MB-EP1] Tested-by: Luca Ceresoli Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel