From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F888C48BC3 for ; Wed, 14 Feb 2024 14:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1FKx8fGWCLKA2bRm9qdExc/IZnU7G6msTdj+nVbjyzQ=; b=cQFl2bifr7IZO7 zjn0NBVkz075CA8jHYUHy1lf2PBzqsVTJw87A835k3zcgD7ONf3JEwQgl7W7eXNXYkC+C4WTjapeO BoEPQzFyGRGPsq5EWuSs0iTtu6IxSnRt+HngP7MgpOChfB4v+2zwuQygqQtdhSKo5snA2u0oY/tx+ r3mvtyl9BtRU6WZGOrpfp/gb4AWJJw9lvxjBIW4zq/0zdmWM3IlcrJ0OyFWyZEjfqdmwT8FRyj09k 1hpcKH8PCFZxbpHFBcjrG4ujBIMqFd+DOWNYLS0RKEVf2egYl/X6ExAT2yUv71oU4qMnDS4sP53/J fXKpeAgT8nduTzWpeaOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raGFR-0000000DARP-3Ekl; Wed, 14 Feb 2024 14:28:29 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raGFP-0000000DAQs-0dso for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 14:28:28 +0000 Received: from pendragon.ideasonboard.com (85-76-48-253-nat.elisa-mobile.fi [85.76.48.253]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C26D1B3; Wed, 14 Feb 2024 15:28:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1707920901; bh=Fgpr7G+xiPL9+Bqa70xzdEPo/a3bsJ7epPYvlzYyGi0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmN5GpzPyYF8c/MW379dyWK7VZd/lBHPMga6p8Yy2Dno9bxz59ayHeT2lzbb2pMNd oI/q7fQ/dQr5TcEy/kyULcmdUWkn0SjdMbm8eZvawZa9nIBdVLa2y768gbic9ZD/3m 3RFD3eyB4qqn6EgBymwz3Pru4rqN0kzRMy84BG+0= Date: Wed, 14 Feb 2024 16:28:25 +0200 From: Laurent Pinchart To: Daniel Scally Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240214142825.GA7873@pendragon.ideasonboard.com> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240214141906.245685-3-dan.scally@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_062827_359456_4655195A X-CRM114-Status: GOOD ( 19.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan, Thank you for the patch. On Wed, Feb 14, 2024 at 02:19:03PM +0000, Daniel Scally wrote: > Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > > Acked-by: Nayden Kanchev > Signed-off-by: Daniel Scally > --- > Changes in v2: > > - Added clocks information > - Fixed the warnings raised by Rob > > .../bindings/media/arm,mali-c55.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > new file mode 100644 > index 000000000000..30038cfec3a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARM Mali-C55 Image Signal Processor > + > +maintainers: > + - Daniel Scally > + - Jacopo Mondi > + > +properties: > + compatible: > + const: arm,mali-c55 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ISP video clock I wonder if we need this clock. Granted, it's an input clock to the ISP, but it's part of the input video bus. I don't expect anyone would ever need to control it manually, it should be provided by the video source automatically. > + - description: ISP AXI clock > + - description: ISP AHB-lite clock These two other clocks look good to me. > + > + clock-names: > + items: > + - const: vclk > + - const: aclk > + - const: hclk > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/properties/endpoint > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + mali_c55: isp@400000 { > + compatible = "arm,mali-c55"; > + reg = <0x400000 0x200000>; > + clocks = <&clk 0>, <&clk 1>, <&clk 2>; > + clock-names = "vclk", "aclk", "hclk"; > + interrupts = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + isp_in: endpoint { > + remote-endpoint = <&mipi_out>; > + }; > + }; > + }; > + }; > +... -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel