From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EC88C48BC4 for ; Thu, 15 Feb 2024 00:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zixnYuFIMn3UGjj7i/QXVFXywW3yXa69YqaYHAi+/8k=; b=4SbvO+z+21RPEM aNcbolew5Yj31I0ngK8ah1LBy2OoY7cfNwIN3E6o6xfMpM0lo2YF4kSAyO0PR0RTCoLkEMM9QJOzF wTXNfzv6sHxdnDXCxzQ4efC79XP5Abh+78NykBV/U/7J3nYlJ/IOgxCvMZHGX9K8QnKByea1Gr9f8 CFwW29VcqrQfpF3vaDZrXg5fJRh4YYxrXNljVFeYGAfNrHPdF5Fw5slFBT4eE1DjEiw7mDsTV8UNf bbPzGdNx9JRKVSQPvzOdFCEqWuMKi8+czBtCA59L8sRc77HyL8+zSG9P7UXTm4kkk0qc4DnxwCTuA FS1w9ITnuOqKpWToFo7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raQ5k-0000000EiUl-1CL2; Thu, 15 Feb 2024 00:59:08 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raQ5h-0000000EiUP-1wPE for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 00:59:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C33DE6125A; Thu, 15 Feb 2024 00:59:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DE8AC433F1; Thu, 15 Feb 2024 00:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707958744; bh=Nl+odjlfK+R+k/m+CZLLi9s6iAFfj0YBGYAq3Za4WGA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZMf6Eq5RsvfPskmrJzatmYAiSPCm41VIsaNzxFrS0QiNVtEA2VPMn8J7L8y1+pejr WuJsto4TmDDe5hdsHhdUrNBvNL3/yNSaDj0oLMpmz/VdDaUfrHZl6fWRtN3gSnC2ky ykmOESm2qcDTvwibwgOoQ4SwG2Ss1zHETKGb5rOZUNv+s2DLmvHUErat+yqt3n+n1S OcsInxQJwNmzMBmlK6l7RV4jmrVRCroySN8v0LgilU2biEn7gvTVJHbZZPYPiv78mb fkWnpwTS2wMQLMBLKEAHNME6yx5OmVQFLLWG2PxsiyLBHlqDj2rJ8o/W+uDONbh4QQ TvJi3MTFT1xfA== Date: Wed, 14 Feb 2024 16:59:02 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v7 00/13] Introduce PHY listing and link_topology tracking Message-ID: <20240214165902.55bf3a04@kernel.org> In-Reply-To: <20240213150431.1796171-1-maxime.chevallier@bootlin.com> References: <20240213150431.1796171-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_165905_578339_ADA1C449 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 13 Feb 2024 16:04:17 +0100 Maxime Chevallier wrote: > This is V7 for the link topology addition, allowing to track all PHYs > that are linked to netdevices. > > The main change in V7 is the protection of the main internal API > entrypoints (link_topo_init/cleanup, link_topo_add/del_phy) by > IS_REACHABLE(CONFIG_PHYLIB). > > That's restrictive, but it looks difficult to do otherwise while still keep the > data structure opaque and not add dependency clutter with PHYLIB. > > As you can tell, I'm unsure about this, so please don't hesitate to > comment on that part :) > > The other changes are very minor, the only one is a call to netdev_put > in the .done() netlink callback. > > As a remainder, here's what the PHY listings would look like : > - eth0 has a 88x3310 acting as media converter, and an SFP module with > an embedded 88e1111 PHY > - eth2 has a 88e1510 PHY Needs a rebase, core has been busy lately: Applying: net: phy: Introduce ethernet link topology representation Using index info to reconstruct a base tree... M MAINTAINERS M drivers/net/phy/Makefile M drivers/net/phy/phy_device.c M include/linux/netdevice.h M include/linux/phy.h M net/core/dev.c Falling back to patching base and 3-way merge... Auto-merging net/core/dev.c CONFLICT (content): Merge conflict in net/core/dev.c Auto-merging include/linux/phy.h Auto-merging include/linux/netdevice.h Auto-merging drivers/net/phy/phy_device.c Auto-merging drivers/net/phy/Makefile Auto-merging MAINTAINERS Recorded preimage for 'net/core/dev.c' -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel