From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14B2AC4829E for ; Thu, 15 Feb 2024 19:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lKGBtGByJvx9JZ/R/1BxJitTsXoyBaJB/VNRvjasZqs=; b=JQSvLgtAve/WGaZ1BS5pYNqswp bemYINElSKQ2Fv1RNhM+PpW2Lu2QorAmeTQXzd58s+Cp1qBpB4EgI8XTzBX2HNNBojs/O6mddR488 Tg6MbNQzgePr6sqkWY3aac7WdSRMONOPbUaEMlwqqrczSJZBndOZBKgrBub0gHHNIWvnBML5WRW37 t9v11lANKwbQXMBtPfYeCbz8B2elgn0tbuzIO2A3ty4A80l7LBRDo0WxXi+JeLDw+2expto25oq8r C6xnLylXPlfqgeiUaTf/h1IjQuqNIZ5USrKU3Hni2hG3/8QTfJpocCcik1jLF4x5FNzCuQXTZNbqM zoGmlUjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rahVS-0000000HWdv-0Ul3; Thu, 15 Feb 2024 19:34:50 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rahVN-0000000HWbQ-2tam for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 19:34:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EDC2C61DAA; Thu, 15 Feb 2024 19:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D989C433C7; Thu, 15 Feb 2024 19:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708025684; bh=yRnLyISh3ozdfGzOQyeO/YUOe2fAUcXlNVFlHde4M6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hcxBanyLQEEN6fX42vS/bUklK63T/N6Rwy5XBP0I5CnNlTL7f1HtGGJLePgvd/uO4 3/1JJYefxII4USHvReXc3uKbI2dZgEGsyR4smQXzrUvoXR0P9jhtBchK1CUhwMwKo3 QZP5/c37D/Zg1bI4rE7nO7Ur+AUmtAC7i/CWwbHzKQ2/6tq3pKNSAEe+5rVphEXPdr 2h5lbxOXn8jZCGwUELfWVzg0X9A0h3p+JOXzR2TRL3GUicxZ83I26A5/v5bdYKNfHi QtkONIKQdtF3KlCs8Z/XOKqRn/J8mYzjWShJAk9KwLh0HemfW92ggpIDKpPVWJdf/8 YK1J1J8qEQZbQ== Date: Thu, 15 Feb 2024 19:34:39 +0000 From: Conor Dooley To: Durai Manickam KR Subject: Re: [PATCH] dt-bindings: dma: convert atmel-xdma.txt to YAML Message-ID: <20240215-snowstorm-quack-fdb7f9c35c2e@spud> References: <20240215-xdma-v1-1-1139960cf096@microchip.com> MIME-Version: 1.0 In-Reply-To: <20240215-xdma-v1-1-1139960cf096@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_113445_859062_526C44EF X-CRM114-Status: GOOD ( 27.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Conor Dooley , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Claudiu Beznea , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3183186445558179480==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3183186445558179480== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2uNUAPuRLcz3Tc2D" Content-Disposition: inline --2uNUAPuRLcz3Tc2D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 04:25:15PM +0530, Durai Manickam KR wrote: > Added a description, required properties and appropriate compatibles > for all the SoCs that are supported by microchip for the XDMAC. >=20 > Signed-off-by: Durai Manickam KR > --- > .../devicetree/bindings/dma/atmel-xdma.txt | 54 --------------- > .../bindings/dma/microchip,at91-xdma.yaml | 77 ++++++++++++++++= ++++++ > 2 files changed, 77 insertions(+), 54 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/dma/atmel-xdma.txt b/Docum= entation/devicetree/bindings/dma/atmel-xdma.txt > deleted file mode 100644 > index 76d649b3a25d..000000000000 > --- a/Documentation/devicetree/bindings/dma/atmel-xdma.txt > +++ /dev/null > @@ -1,54 +0,0 @@ > -* Atmel Extensible Direct Memory Access Controller (XDMAC) > - > -* XDMA Controller > -- interrupts: Should contain DMA interrupt. > -- #dma-cells: Must be <1>, used to represent the number of integer cells= in > -the dmas property of client devices. > - - The 1st cell specifies the channel configuration register: > - - bit 13: SIF, source interface identifier, used to get the memory > - interface identifier, > - - bit 14: DIF, destination interface identifier, used to get the per= ipheral > - interface identifier, > - - bit 30-24: PERID, peripheral identifier. > - > -Example: > - > -dma1: dma-controller@f0004000 { > - compatible =3D "atmel,sama5d4-dma"; > - reg =3D <0xf0004000 0x200>; > - interrupts =3D <50 4 0>; > - #dma-cells =3D <1>; > -}; > - > - > -* DMA clients > -DMA clients connected to the Atmel XDMA controller must use the format > -described in the dma.txt file, using a one-cell specifier for each chann= el. > -The two cells in order are: > -1. A phandle pointing to the DMA controller. > -2. Channel configuration register. Configurable fields are: > - - bit 13: SIF, source interface identifier, used to get the memory > - interface identifier, > - - bit 14: DIF, destination interface identifier, used to get the per= ipheral > - interface identifier, > - - bit 30-24: PERID, peripheral identifier. > - > -Example: > - > -i2c2: i2c@f8024000 { > - compatible =3D "atmel,at91sam9x5-i2c"; > - reg =3D <0xf8024000 0x4000>; > - interrupts =3D <34 4 6>; > - dmas =3D <&dma1 > - (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) > - | AT91_XDMAC_DT_PERID(6))>, > - <&dma1 > - (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) > - | AT91_XDMAC_DT_PERID(7))>; > - dma-names =3D "tx", "rx"; > -}; > diff --git a/Documentation/devicetree/bindings/dma/microchip,at91-xdma.ya= ml b/Documentation/devicetree/bindings/dma/microchip,at91-xdma.yaml > new file mode 100644 > index 000000000000..0bd79c7b5e6f > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/microchip,at91-xdma.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/microchip,at91-xdma.yaml# Filename matching a compatible please. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel Extensible Direct Memory Access Controller (XDMAC) > + > +maintainers: > + - Durai Manickam KR > + > +description: | The | is not needed, you've no formatting to preserve. > + The Atmel Extensible Direct Memory Access Controller (XDMAC) performs = peripheral > + data transfer and memory move operations over one or two bus ports thr= ough the > + unidirectional communication channel. Each channel is fully programmab= le and > + provides both peripheral or memory-to-memory transfers. > + > +properties: > + compatible: > + oneOf: > + - enum: > + - atmel,sama5d4-dma > + - microchip,sama7g5-dma > + - microchip,sam9x7-dma The text binding says: > -- compatible: Should be "atmel,sama5d4-dma", "microchip,sam9x60-dma" or > - "microchip,sama7g5-dma" or > - "microchip,sam9x7-dma", "atmel,sama5d4-dma". That's not what you have here at all. > + - items: > + - const: atmel,sama5d4-dma > + - const: microchip,sam9x60-dma This looks backwards. > + reg: > + description: Should contain DMA registers location and length. > + maxItems: 1 Same comments here about descriptions for well known properties as the other DMA controller. > + > + interrupts: > + description: Should contain the DMA interrupts associated to the DMA= channels. > + maxItems: 1 > + > + "#dma-cells": > + description: | > + Must be <1>, used to represent the number of integer cells in the = dmas > + property of client device. > + -The 1st cell specifies the channel configuration register: > + -bit 13: SIF, source interface identifier, used to get the memory > + interface identifier, > + -bit 14: DIF, destination interface identifier, used to get the pe= ripheral > + interface identifier, > + -bit 30-24: PERID, peripheral identifier. > + const: 1 > + > + clocks: > + description: Should contain a clock specifier for each entry in cloc= k-names. > + maxItems: 1 And here about adding properties. Please explain in your commit message where the new properties came from. > + > + clock-names: > + description: Should contain the clock of the DMA controller. > + const: dma_clk > + > +required: > + - compatible > + - reg > + - interrupts > + - "#dma-cells" > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + dma0: dma-controller@f0004000 { And same here about the label :) Cheers, Conor. > + compatible =3D "atmel,sama5d4-dma"; > + reg =3D <0xffffec00 0x200>; > + interrupts =3D <50 4 0>; > + #dma-cells =3D <1>; > + clocks =3D <&pmc 2 20>; > + clock-names =3D "dma_clk"; > + }; > + > +... >=20 > --- > base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d > change-id: 20240215-xdma-36e8bdbf8141 >=20 > Best regards, > --=20 > Durai Manickam KR >=20 --2uNUAPuRLcz3Tc2D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc5nTwAKCRB4tDGHoIJi 0mWeAQDyxMRExEs8PvvE6a8W3mU1c68idO13L6qbJOJZzZggbwD+PeCtNY1Irgpl 9q5poFzXZZ7w/mux7+IUq6SBm6lUzA4= =pFvp -----END PGP SIGNATURE----- --2uNUAPuRLcz3Tc2D-- --===============3183186445558179480== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3183186445558179480==--